nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/shadow-dom/media-shadow-manipulation-e...

6 lines
88 B
Plaintext
Raw Permalink Normal View History

REGRESSION (r209490): [ios-simulator] LayoutTest fast/shadow-dom/media-shadow-manipulation.html is failing https://bugs.webkit.org/show_bug.cgi?id=165590 Unreviewed. Revert r209490 on this test and make the check conditional since iOS and Mac implements video element differently. In any case, these tests aren't testing anything useful after r209486. We should consider removing them or make them use internals.shadowRoot instead in a near term. * fast/shadow-dom/media-shadow-manipulation-expected.txt: * fast/shadow-dom/media-shadow-manipulation.html: Canonical link: https://commits.webkit.org/183191@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-12-08 08:07:42 +00:00
PASS Passes if we did not debug assert.
Use 'childOfType' template when retrieving Shadow DOM elements https://bugs.webkit.org/show_bug.cgi?id=165145 <rdar://problem/29331830> Reviewed by Antti Koivisto. Source/WebCore: Tests: fast/shadow-dom/color-input-element-shadow-manipulation.html fast/shadow-dom/file-input-element-shadow-manipulation.html fast/shadow-dom/keygen-shadow-manipulation.html fast/shadow-dom/media-shadow-manipulation.html fast/shadow-dom/range-input-element-shadow-manipulation.html fast/shadow-dom/textarea-shadow-manipulation.html Switch to using 'childOfType' when retrieving Shadow DOM elements, rather than relying on expected element positions, as these can be changed by JavaScript. Drive by fix: Make more use of is<> and downcast<> templates rather than blindly casting. * dom/Element.h: (WebCore::Element::isUploadButton): Added. (WebCore::Element::isSliderContainerElement): Added. * html/ColorInputType.cpp: (WebCore::ColorInputType::shadowColorSwatch): Use 'childOfType' rather than assuming the first child is the one we want. * html/FileInputType.cpp: (isType): Added. (WebCore::FileInputType::disabledAttributeChanged): Use 'childOfType' rather than assuming the first child is the one we want. (WebCore::FileInputType::multipleAttributeChanged): Ditto. * html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::shadowSelect): Ditto. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaControls): Ditto. (WebCore::HTMLMediaElement::hasMediaControls): Ditto. * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::innerTextElement): Ditto. * html/RangeInputType.cpp: (WebCore::RangeInputType::sliderTrackElement): Ditto. * html/shadow/SliderThumbElement.h: (isType): Added. * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::targetClone): Use 'childOfType' rather than assuming the first child is the one we want. LayoutTests: * fast/shadow-dom/color-input-element-shadow-manipulation-expected.txt: Added. * fast/shadow-dom/color-input-element-shadow-manipulation.html: Added. * fast/shadow-dom/file-input-element-shadow-manipulation-expected.txt: Added. * fast/shadow-dom/file-input-element-shadow-manipulation.html: Added. * fast/shadow-dom/keygen-shadow-manipulation-expected.txt: Added. * fast/shadow-dom/keygen-shadow-manipulation.html: Added. * fast/shadow-dom/media-shadow-manipulation-expected.txt: Added. * fast/shadow-dom/media-shadow-manipulation.html: Added. * fast/shadow-dom/range-input-element-shadow-manipulation-expected.txt: Added. * fast/shadow-dom/range-input-element-shadow-manipulation.html: Added. * fast/shadow-dom/textarea-shadow-manipulation-expected.txt: Added. * fast/shadow-dom/textarea-shadow-manipulation.html: Added. Canonical link: https://commits.webkit.org/182831@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-11-30 20:20:32 +00:00
PASS successfullyParsed is true
TEST COMPLETE
Rebaseline tests after r209486. Also updated media-shadow-manipulation.html now that range is null. * fast/shadow-dom/color-input-element-shadow-manipulation-expected.txt: * fast/shadow-dom/file-input-element-shadow-manipulation-expected.txt: * fast/shadow-dom/media-shadow-manipulation-expected.txt: * fast/shadow-dom/media-shadow-manipulation.html: * fast/shadow-dom/range-input-element-shadow-manipulation-expected.txt: * fast/shadow-dom/textarea-shadow-manipulation-expected.txt: Canonical link: https://commits.webkit.org/183154@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-12-07 23:53:10 +00:00