nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/scrolling/v-rl-scrollbars-initial-pos...

8 lines
353 B
HTML
Raw Permalink Normal View History

Place vertical scrollbars at (inline/block)-end edge in all writing modes. https://bugs.webkit.org/show_bug.cgi?id=224224 Reviewed by Simon Fraser. LayoutTests/imported/w3c: * web-platform-tests/css/css-scroll-snap/snap-inline-block-expected.txt: * web-platform-tests/css/cssom-view/scrollLeftTop-expected.txt: Source/WebCore: Tests: fast/scrolling/v-rl-scrollbars-initial-position-dynamic.html fast/scrolling/v-rl-scrollbars-initial-position.html fast/scrolling/vertical-scrollbar-position.html We currently only consider moving a vertical scrollbar to the left for `writing-mode: horizontal-{tb,bt}; direction: rtl` containers. But ideally we should always place the vertical scrollbar at the end edge of the container (whether that's the inline-end edge, when using a horizontal writing mode, or the block-end edge, when using a vertical writing mode). Some functions calling the existing shouldPlaceBlockDirectionScrollbarOnLeft instead really care about whether the vertical scrollbar is on the left, not whether the block direction scrollbar is on the left (since for vertical writing modes, the block direction scrollbar is the horizontal one on the bottom). So we rename this to shouldPlaceVerticalScrollbarOnLeft, make it return true for `writing-mode: vertical-rl`, and adjust callers that really do care only about block direction scrollbars to additionally check their writing mode. * page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): * page/FrameView.cpp: (WebCore::FrameView::shouldPlaceVerticalScrollbarOnLeft const): * page/FrameView.h: * platform/ScrollView.cpp: (WebCore::ScrollView::documentScrollPositionRelativeToViewOrigin const): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollCornerRect const): (WebCore::ScrollView::locationOfContents const): * platform/ScrollableArea.h: * platform/adwaita/ScrollbarThemeAdwaita.cpp: (WebCore::ScrollbarThemeAdwaita::paint): * platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::widgetTypeForScrollbar): (WebCore::ScrollbarThemeGtk::paint): * platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::didCreateScrollerImp): * platform/win/PopupMenuWin.h: * rendering/RenderBlock.cpp: (WebCore::RenderBlock::logicalLeftOffsetForContent const): (WebCore::RenderBlock::logicalRightOffsetForContent const): * rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::determineLogicalLeftPositionForChild): * rendering/RenderBox.cpp: (WebCore::RenderBox::paddingBoxRect const): (WebCore::RenderBox::contentBoxLocation const): (WebCore::RenderBox::overflowClipRect const): (WebCore::RenderBox::computePositionedLogicalWidth const): (WebCore::RenderBox::flippedClientBoxRect const): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::constrainingRectForStickyPosition const): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::resize): (WebCore::RenderLayer::overflowControlsRects const): (WebCore::RenderLayer::offsetFromResizeCorner const): * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::positionForClipLayer const): * rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::shouldPlaceVerticalScrollbarOnLeft const): * rendering/RenderLayerModelObject.h: * rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::shouldPlaceVerticalScrollbarOnLeft const): (WebCore::RenderLayerScrollableArea::overflowControlsRects const): (WebCore::RenderLayerScrollableArea::computeScrollOrigin): (WebCore::RenderLayerScrollableArea::updateScrollbarsAfterLayout): (WebCore::RenderLayerScrollableArea::drawPlatformResizerImage): (WebCore::RenderLayerScrollableArea::hitTestResizerInFragments const): (WebCore::RenderLayerScrollableArea::updateScrollbarsAfterStyleChange): * rendering/RenderLayerScrollableArea.h: * rendering/RenderListBox.cpp: (WebCore::RenderListBox::itemBoundingBoxRect): (WebCore::RenderListBox::paintScrollbar): (WebCore::RenderListBox::isPointInOverflowControl): (WebCore::RenderListBox::listIndexAtOffset): (WebCore::RenderListBox::invalidateScrollbarRect): (WebCore::RenderListBox::convertFromScrollbarToContainingView const): (WebCore::RenderListBox::convertFromContainingViewToScrollbar const): * rendering/RenderListBox.h: * rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle const): * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::shouldPlaceVerticalScrollbarOnLeft const): * rendering/style/RenderStyle.h: Source/WebKit: * UIProcess/win/WebPopupMenuProxyWin.h: * WebProcess/Plugins/PDF/PDFPlugin.h: LayoutTests: iOS test failure expectations and skips are because we don't support non-overlay scrollbars on the left on that platform. * TestExpectations: * css3/flexbox/child-overflow-expected.html: * fast/repaint/vertical-overflow-parent-expected.txt: * fast/repaint/vertical-overflow-same-expected.txt: * fast/scrolling/v-rl-scrollbars-initial-position-dynamic-expected.html: Added. * fast/scrolling/v-rl-scrollbars-initial-position-dynamic.html: Added. * fast/scrolling/v-rl-scrollbars-initial-position-expected.html: Added. * fast/scrolling/v-rl-scrollbars-initial-position.html: Added. * fast/scrolling/vertical-scrollbar-position-expected.txt: Added. * fast/scrolling/vertical-scrollbar-position.html: Added. * platform/ios/TestExpectations: * platform/ios/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-inline-block-expected.txt: Added. * platform/ios/imported/w3c/web-platform-tests/css/cssom-view/scrollLeftTop-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/scrollLeftTop-expected.txt. Canonical link: https://commits.webkit.org/236665@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2021-04-16 23:55:14 +00:00
<!DOCTYPE html>
<div style="width: 100px; height: 100px; direction: rtl; overflow: scroll;">
<div style="width: 192px; height: 192px; border: 4px solid black;"></div>
</div>
<div style="width: 100px; height: 100px; direction: ltr; overflow: scroll; margin-top: 1em;">
<div style="width: 192px; height: 192px; border: 4px solid black;"></div>
</div>