nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/repaint/outline-auto-with-default-w...

7 lines
185 B
Plaintext
Raw Permalink Normal View History

Cleanup outline-style: auto painting. https://bugs.webkit.org/show_bug.cgi?id=148159 Reviewed by Simon Fraser. Old platform style required the focus ring to be painted with an offset. (https://trac.webkit.org/r5358) (and it has the side effect of growing outline-width adds further, unwanted offset) Default css for :focus is adjusted to remove this offset by setting the outline-width to 5px and the outline-offset to -2px. (https://trac.webkit.org/r13639) This patch removes both the old logic and the workaround for getting rid of the unwanted offset. Source/WebCore: Test: fast/repaint/outline-auto-with-default-width-and-offset-repaint.html * css/html.css: (:focus): (input:focus, textarea:focus, isindex:focus, keygen:focus, select:focus): Deleted. * platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing): * rendering/RenderElement.cpp: (WebCore::RenderElement::computeMaxOutlineSize): (WebCore::RenderElement::paintFocusRing): (WebCore::RenderElement::paintOutline): Short circuit painting outline when painting is disabled. It only change behaviour for non-auto outlines -which are anyway not supposed to be painted when painting is disabled. * rendering/RenderObject.cpp: (WebCore::RenderObject::adjustRectForOutlineAndShadow): * rendering/RenderTheme.h: (WebCore::RenderTheme::platformFocusRingWidth): (WebCore::RenderTheme::platformFocusRingMaxWidth): Deleted. LayoutTests: * fast/repaint/outline-auto-with-default-width-and-offset-repaint-expected.txt: Added. * fast/repaint/outline-auto-with-default-width-and-offset-repaint.html: Copied from LayoutTests/fast/repaint/outline-with2px-auto-repaint-rect.html. * fast/repaint/outline-with1px-auto-repaint-rect.html: * fast/repaint/outline-with2px-auto-repaint-rect.html: * fast/repaint/outline-with3px-auto-repaint-rect.html: Canonical link: https://commits.webkit.org/166310@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@188652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-08-19 22:09:27 +00:00
PASS window.internals.repaintRectsAsText().indexOf('4 6') is not -1
PASS window.internals.repaintRectsAsText().indexOf('4 46') is not -1
PASS successfullyParsed is true
TEST COMPLETE