nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/mediastream/MediaStream-video-element-c...

5 lines
72 B
Plaintext
Raw Permalink Normal View History

No audio output when unplugged wired headset during a call https://bugs.webkit.org/show_bug.cgi?id=216389 <rdar://problem/68692800> Reviewed by Eric Carlson. Source/WebCore: Implement shouldOverridePauseDuringRouteChange for media elements. If it is a media stream backed video element, do not pause on active audio route change. Implement internal API to write a layout test. Refactoring to share more code between WebCore and WebKit and implement the internal API. Improve isolation of MediaSessionHelper by moving all its members from protected to private. Test: fast/mediastream/MediaStream-video-element-change-audio-route.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::shouldOverridePauseDuringRouteChange const): * html/HTMLMediaElement.h: * platform/audio/ios/MediaSessionHelperIOS.h: (WebCore::MediaSessionHelper::MediaSessionHelper): * platform/audio/ios/MediaSessionHelperIOS.mm: (MediaSessionHelper::activeAudioRouteDidChange): (MediaSessionHelper::applicationWillEnterForeground): (MediaSessionHelper::applicationDidEnterBackground): (MediaSessionHelper::applicationWillBecomeInactive): (MediaSessionHelper::applicationDidBecomeActive): (MediaSessionHelper::mediaServerConnectionDied): (MediaSessionHelper::externalOutputDeviceAvailableDidChange): (MediaSessionHelper::isPlayingToAutomotiveHeadUnitDidChange): (MediaSessionHelper::activeVideoRouteDidChange): (MediaSessionHelper::startMonitoringWirelessRoutes): (MediaSessionHelper::stopMonitoringWirelessRoutes): (MediaSessionHelperiOS::MediaSessionHelperiOS): (MediaSessionHelperiOS::startMonitoringWirelessRoutesInternal): (MediaSessionHelperiOS::stopMonitoringWirelessRoutesInternal): (MediaSessionHelperiOS::mediaServerConnectionDied): (MediaSessionHelperiOS::setIsPlayingToAutomotiveHeadUnit): (MediaSessionHelperiOS::activeAudioRouteDidChange): (MediaSessionHelperiOS::activeVideoRouteDidChange): (MediaSessionHelperiOS::externalOutputDeviceAvailableDidChange): (MediaSessionHelperiOS::startMonitoringWirelessRoutes): Deleted. (MediaSessionHelperiOS::stopMonitoringWirelessRoutes): Deleted. (MediaSessionHelperiOS::applicationDidBecomeActive): Deleted. (MediaSessionHelperiOS::applicationDidEnterBackground): Deleted. (MediaSessionHelperiOS::applicationWillBecomeInactive): Deleted. (MediaSessionHelperiOS::applicationWillEnterForeground): Deleted. * testing/Internals.cpp: (WebCore::Internals::activeAudioRouteDidChange): * testing/Internals.h: * testing/Internals.idl: Source/WebKit: Make use of WebCore methods instead of reimplementing them here. * WebProcess/GPU/media/ios/RemoteMediaSessionHelper.cpp: (WebKit::RemoteMediaSessionHelper::startMonitoringWirelessRoutesInternal): (WebKit::RemoteMediaSessionHelper::stopMonitoringWirelessRoutesInternal): (WebKit::RemoteMediaSessionHelper::activeVideoRouteDidChange): (WebKit::RemoteMediaSessionHelper::startMonitoringWirelessRoutes): Deleted. (WebKit::RemoteMediaSessionHelper::stopMonitoringWirelessRoutes): Deleted. (WebKit::RemoteMediaSessionHelper::applicationWillEnterForeground): Deleted. (WebKit::RemoteMediaSessionHelper::applicationDidEnterBackground): Deleted. (WebKit::RemoteMediaSessionHelper::applicationWillBecomeInactive): Deleted. (WebKit::RemoteMediaSessionHelper::applicationDidBecomeActive): Deleted. (WebKit::RemoteMediaSessionHelper::externalOutputDeviceAvailableDidChange): Deleted. (WebKit::RemoteMediaSessionHelper::isPlayingToAutomotiveHeadUnitDidChange): Deleted. (WebKit::RemoteMediaSessionHelper::activeAudioRouteDidChange): Deleted. * WebProcess/GPU/media/ios/RemoteMediaSessionHelper.h: LayoutTests: * fast/mediastream/MediaStream-video-element-change-audio-route-expected.txt: Added. * fast/mediastream/MediaStream-video-element-change-audio-route.html: Added. Canonical link: https://commits.webkit.org/236080@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2021-04-02 13:19:00 +00:00
PASS MediaStream video should not be paused when audio route changes