nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/mediastream/MediaStream-removeTrack-whi...

5 lines
34 B
Plaintext
Raw Permalink Normal View History

MediaPlayerPrivateMediaStreamAVFObjC should unobserve the tracks from its audio and video track sets https://bugs.webkit.org/show_bug.cgi?id=211444 <rdar://problem/62886221> Reviewed by Eric Carlson. Source/WebCore: Test: fast/mediastream/MediaStream-removeTrack-while-playing.html * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC): We keep maps of audio and video tracks we are observing. Use these two maps to properly unobserve all tracks at destruction time. While this is not strictly needed since we are using weak pointers, this helps keeping the code healthy. * platform/mediastream/MediaStreamTrackPrivate.cpp: (WebCore::MediaStreamTrackPrivate::forEachObserver): Add a debug ASSERT so that we ensure add/remove observers is done properly. LayoutTests: * fast/mediastream/MediaStream-removeTrack-while-playing-expected.txt: Added. * fast/mediastream/MediaStream-removeTrack-while-playing.html: Added. Canonical link: https://commits.webkit.org/224345@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-05 16:05:54 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS removeTrack while playing
MediaPlayerPrivateMediaStreamAVFObjC should unobserve the tracks from its audio and video track sets https://bugs.webkit.org/show_bug.cgi?id=211444 <rdar://problem/62886221> Reviewed by Eric Carlson. Source/WebCore: Test: fast/mediastream/MediaStream-removeTrack-while-playing.html * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC): We keep maps of audio and video tracks we are observing. Use these two maps to properly unobserve all tracks at destruction time. While this is not strictly needed since we are using weak pointers, this helps keeping the code healthy. * platform/mediastream/MediaStreamTrackPrivate.cpp: (WebCore::MediaStreamTrackPrivate::forEachObserver): Add a debug ASSERT so that we ensure add/remove observers is done properly. LayoutTests: * fast/mediastream/MediaStream-removeTrack-while-playing-expected.txt: Added. * fast/mediastream/MediaStream-removeTrack-while-playing.html: Added. Canonical link: https://commits.webkit.org/224345@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-05 16:05:54 +00:00