nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/media/mq-viewport-units-expected.txt

11 lines
192 B
Plaintext
Raw Permalink Normal View History

Fix viewport units in Media Queries https://bugs.webkit.org/show_bug.cgi?id=144260 Reviewed by Darin Adler. Source/WebCore: This patch makes sure that viewport units are considered "length units" in the context of Media Queries, by having MediaQueryExp use the unit logic that is in CSSPrimitiveValue. It does that by turning the relevant methods in CSSPrimitiveValue into static. It also makes sure that the logic for "resolution units" is not maintained separately in MediaQueryExp, to avoid similiar issues in the future with resolution units. Test: fast/media/mq-viewport-units.html * css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::isViewportPercentageLength): Added a static variant. (WebCore::CSSPrimitiveValue::isLength): Added a static variant. (WebCore::CSSPrimitiveValue::isResolution): Added a static variant. * css/MediaQueryExp.cpp: (WebCore::featureWithValidPositiveLenghtOrNumber): Call CSSPrimitiveValue's length unit logic. (WebCore::featureWithValidDensity): Call CSSPrimitiveValue's resolution unit logic. LayoutTests: These tests make sure that viewport units are working as expected inside of Media Queries. * fast/media/mq-viewport-units-expected.txt: Added. * fast/media/mq-viewport-units.html: Added. Canonical link: https://commits.webkit.org/162268@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@183404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-04-27 18:42:29 +00:00
Description
This tests validates that the viewport units work in media queries.
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS vw unit sanity check
PASS vh unit sanity check
PASS vmax unit sanity check
PASS vmin unit sanity check
Fix viewport units in Media Queries https://bugs.webkit.org/show_bug.cgi?id=144260 Reviewed by Darin Adler. Source/WebCore: This patch makes sure that viewport units are considered "length units" in the context of Media Queries, by having MediaQueryExp use the unit logic that is in CSSPrimitiveValue. It does that by turning the relevant methods in CSSPrimitiveValue into static. It also makes sure that the logic for "resolution units" is not maintained separately in MediaQueryExp, to avoid similiar issues in the future with resolution units. Test: fast/media/mq-viewport-units.html * css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::isViewportPercentageLength): Added a static variant. (WebCore::CSSPrimitiveValue::isLength): Added a static variant. (WebCore::CSSPrimitiveValue::isResolution): Added a static variant. * css/MediaQueryExp.cpp: (WebCore::featureWithValidPositiveLenghtOrNumber): Call CSSPrimitiveValue's length unit logic. (WebCore::featureWithValidDensity): Call CSSPrimitiveValue's resolution unit logic. LayoutTests: These tests make sure that viewport units are working as expected inside of Media Queries. * fast/media/mq-viewport-units-expected.txt: Added. * fast/media/mq-viewport-units.html: Added. Canonical link: https://commits.webkit.org/162268@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@183404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-04-27 18:42:29 +00:00