nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/editing/indent-pre-user-select-all-...

2 lines
122 B
Plaintext
Raw Permalink Normal View History

Nullptr crash in WebCore::lastPositionInNode when indenting text node that has user-select:all parent. https://bugs.webkit.org/show_bug.cgi?id=210016 <rdar://problem/61014577> Reviewed by Ryosuke Niwa. Source/WebCore: In rangeForParagraphSplittingTextNodesIfNeeded, added null check for previousSibling() after splitTextNode is called, and returns empty positions to caller. In formatSelection, check the returned positions from rangeForParagraphSplittingTextNodesIfNeeded and stop indenting the rest of the paragraphs. Test: fast/editing/indent-pre-user-select-all-crash.html * editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::formatSelection): (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): LayoutTests: Added a regression test for the crash. * fast/editing/indent-pre-user-select-all-crash-expected.txt: Added. * fast/editing/indent-pre-user-select-all-crash.html: Added. Canonical link: https://commits.webkit.org/223000@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-04-07 01:45:56 +00:00
Tests indenting pre element that has user-select:all parent. The test passes if WebKit doesn't crash or hit an assertion.