nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/dom/insert-template-parent-into...

14 lines
803 B
Plaintext
Raw Permalink Normal View History

appendChild should throw when inserting an ancestor of a template into its content adopted to another document https://bugs.webkit.org/show_bug.cgi?id=195984 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaselined the test that is not fully passing. * web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/template-content-hierarcy-expected.txt: Source/WebCore: The WPT test caught a bug that appendChild and other DOM insertion functions were incorrectly assuming that any node that's in a HTML template element has the current document's template document as its owner. The assumption is wrong when the template element's content DocumentFragment is adopted to another document. Fixed the bug by always checking the ancestor host elements in checkAcceptChild. Also Test: fast/dom/insert-template-parent-into-adopted-content.html * dom/ContainerNode.cpp: (WebCore::isInTemplateContent): Deleted. This code is simply wrong. (WebCore::containsConsideringHostElements): Deleted. Call sites are updated to use containsIncludingHostElements. (WebCore::containsIncludingHostElements): Moved from Node.cpp and optimized this code a bit. It's more efficient to get the parent node and check for ShadowRoot and DocumentFragment only when the parent is null than to check for those two node types before getting the parent node. (WebCore::checkAcceptChild): Merged two code paths to call containsIncludingHostElements. The early return for a pseudo element is there only to prevent tree corruption in release build even in the presence of a major bug so it shouldn't be an spec compliance issue. * dom/Node.cpp: (WebCore::Node::containsIncludingHostElements const): Deleted. * dom/Node.h: LayoutTests: Added a regression test. * fast/dom/insert-template-parent-into-adopted-content-expected.txt: Added. * fast/dom/insert-template-parent-into-adopted-content.html: Added. Canonical link: https://commits.webkit.org/210299@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-03-20 20:26:18 +00:00
This tests inserting the parent of a template element into its content document fragment
after adopting the document fragment to another document. WebKit should throw HierarchyRequestError
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS template.content.appendChild(templateParent) threw exception HierarchyRequestError: The operation would yield an incorrect node tree..
PASS template.content.insertBefore(templateParent, template.content.firstChild) threw exception HierarchyRequestError: The operation would yield an incorrect node tree..
PASS template.content.replaceChild(templateParent, template.content.firstChild) threw exception HierarchyRequestError: The operation would yield an incorrect node tree..
PASS successfullyParsed is true
TEST COMPLETE