nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/css/overscroll-behavior-invalid...

18 lines
772 B
Plaintext
Raw Permalink Normal View History

Runtime-disabled CSS features still appear enabled via CSS.supports() https://bugs.webkit.org/show_bug.cgi?id=222280 rdar://74595641 Reviewed by Sam Weinig. Source/WebCore: When parsing CSS.supports() for a runtime-disabled property, we'd successfully parse a CSS-wide keyword like "inherit" and report that the property is supported. We need to explicitly check for runtime-disabled properties. Tests: css3/color-filters/color-filter-exposed-if-disabled.html fast/css/scroll-behavior-exposed-if-disabled.html * css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::isPropertyRuntimeDisabled const): (WebCore::CSSParserImpl::consumeDeclaration): * css/parser/CSSParserImpl.h: LayoutTests: * css3/color-filters/color-filter-exposed-if-disabled-expected.txt: Added. Fails tracked in webkit.org/b/217626 * css3/color-filters/color-filter-exposed-if-disabled.html: Added. * fast/css/overscroll-behavior-invalidate-if-disabled-expected.txt: * fast/css/overscroll-behavior-invalidate-if-disabled.html: * fast/css/scroll-behavior-exposed-if-disabled-expected.txt: Added. * fast/css/scroll-behavior-exposed-if-disabled.html: Added. Canonical link: https://commits.webkit.org/234512@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2021-02-24 16:45:08 +00:00
Tests that overscroll-behavior is not exposed when the feature is disabled
Support overscroll-behavior parsing https://bugs.webkit.org/show_bug.cgi?id=219305 Reviewed by Simon Fraser. Based on Frédéric Wang's patch. LayoutTests/imported/w3c: Update expectations for overscroll-behavior parsing tests. * web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * web-platform-tests/css/css-overscroll-behavior/inheritance-expected.txt: * web-platform-tests/css/css-overscroll-behavior/overscroll-behavior-logical-expected.txt: * web-platform-tests/css/css-overscroll-behavior/parsing/overscroll-behavior-computed-expected.txt: * web-platform-tests/css/css-overscroll-behavior/parsing/overscroll-behavior-valid-expected.txt: * web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Source/WebCore: Support parsing CSS properties: overscroll-behavior, overscroll-behavior-x and overscroll-behavior-y. Tests: fast/css/overscroll-behavior-invalidate-if-disabled.html fast/css/overscroll-behavior-validate-if-enable.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::settings const): (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/CSSComputedStyleDeclaration.h: * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator OverscrollBehavior const): * css/CSSProperties.json: * css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::settings const): (WebCore::CSSStyleDeclaration::namedItem): (WebCore::CSSStyleDeclaration::setNamedItem): (WebCore::CSSStyleDeclaration::supportedPropertyNames const): * css/CSSStyleDeclaration.h: * css/CSSValueKeywords.in: * css/StyleProperties.cpp: (WebCore::StyleProperties::getPropertyValue const): (WebCore::StyleProperties::asText const): * css/parser/CSSParserContext.cpp: (WebCore::CSSParserContext::CSSParserContext): (WebCore::operator==): * css/parser/CSSParserContext.h: (WebCore::CSSParserContextHash::hash): * css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): (WebCore::CSSParserFastPaths::isKeywordPropertyID): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeOverscrollBehavior): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::CSSPropertyParser::consumeOverscrollBehaviorShorthand): (WebCore::CSSPropertyParser::parseShorthand): * css/parser/CSSPropertyParser.h: * platform/ScrollTypes.h: * rendering/style/RenderStyle.h: (WebCore::RenderStyle::overscrollBehaviorX const): (WebCore::RenderStyle::overscrollBehaviorY const): (WebCore::RenderStyle::setOverscrollBehaviorX): (WebCore::RenderStyle::setOverscrollBehaviorY): (WebCore::RenderStyle::initialOverscrollBehaviorX): (WebCore::RenderStyle::initialOverscrollBehaviorY): * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator== const): * rendering/style/StyleRareNonInheritedData.h: Source/WebKitLegacy/win: Add an experimental feature flag for overscroll-behavior. * Interfaces/IWebPreferencesPrivate.idl: * WebPreferenceKeysPrivate.h: * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::overscrollBehaviorEnabled): (WebPreferences::setOverscrollBehaviorEnabled): * WebPreferences.h: * WebView.cpp: (WebView::notifyPreferencesChanged): Source/WTF: Add an experimental feature flag for overscroll-behavior. * Scripts/Preferences/WebPreferencesExperimental.yaml: Tools: Add support for testing overscroll-behavior parsing. * DumpRenderTree/TestOptions.cpp: (WTR::TestOptions::defaults): LayoutTests: Test overscrollBehavior's validation when enable or disable OverscrollBehaviorEnabled. * fast/css/overscroll-behavior-invalidate-if-disabled-expected.txt: Added. * fast/css/overscroll-behavior-invalidate-if-disabled.html: Added. * fast/css/overscroll-behavior-validate-if-enable-expected.txt: Added. * fast/css/overscroll-behavior-validate-if-enable.html: Added. * platform/ios-13/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: * platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Canonical link: https://commits.webkit.org/232280@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-12-10 06:39:21 +00:00
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS 'overscrollBehavior' in document.documentElement.style is false
PASS 'overscroll-behavior' in getComputedStyle(document.documentElement) is false
Use Element for checking Settings in CSSComputedStyleDeclaration https://bugs.webkit.org/show_bug.cgi?id=223598 Patch by Rob Buis <rbuis@igalia.com> on 2021-04-01 Reviewed by Darin Adler. Source/WebCore: Use Element for checking Settings in CSSComputedStyleDeclaration. Right now renderer is used but this will not work for non-rendered elements. Tests: fast/css/rotate-invalidate-if-disabled.html fast/css/scale-invalidate-if-disabled.html fast/css/translate-invalidate-if-disabled.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): LayoutTests: Adapt tests to verify that non-rendered elements do not expose contain/aspect-ratio when these features are disabled. Add tests for rotate, scale and translate as well. * fast/css/aspect-ratio-invalidate-if-disabled-expected.txt: * fast/css/aspect-ratio-invalidate-if-disabled.html: * fast/css/contain-invalidate-if-disabled-expected.txt: * fast/css/contain-invalidate-if-disabled.html: * fast/css/overscroll-behavior-invalidate-if-disabled-expected.txt: * fast/css/overscroll-behavior-invalidate-if-disabled.html: * fast/css/rotate-invalidate-if-disabled-expected.txt: Added. * fast/css/rotate-invalidate-if-disabled.html: Added. * fast/css/scale-invalidate-if-disabled-expected.txt: Added. * fast/css/scale-invalidate-if-disabled.html: Added. * fast/css/translate-invalidate-if-disabled-expected.txt: Added. * fast/css/translate-invalidate-if-disabled.html: Added. * platform/win/TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275351 268f45cc-cd09-0410-ab3c-d52691b4dbfc Canonical link: https://commits.webkit.org/236022@main
2021-04-01 10:26:37 +00:00
PASS getComputedStyle(document.getElementById('target')).getPropertyValue('overscroll-behavior') == '' is true
Runtime-disabled CSS features still appear enabled via CSS.supports() https://bugs.webkit.org/show_bug.cgi?id=222280 rdar://74595641 Reviewed by Sam Weinig. Source/WebCore: When parsing CSS.supports() for a runtime-disabled property, we'd successfully parse a CSS-wide keyword like "inherit" and report that the property is supported. We need to explicitly check for runtime-disabled properties. Tests: css3/color-filters/color-filter-exposed-if-disabled.html fast/css/scroll-behavior-exposed-if-disabled.html * css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::isPropertyRuntimeDisabled const): (WebCore::CSSParserImpl::consumeDeclaration): * css/parser/CSSParserImpl.h: LayoutTests: * css3/color-filters/color-filter-exposed-if-disabled-expected.txt: Added. Fails tracked in webkit.org/b/217626 * css3/color-filters/color-filter-exposed-if-disabled.html: Added. * fast/css/overscroll-behavior-invalidate-if-disabled-expected.txt: * fast/css/overscroll-behavior-invalidate-if-disabled.html: * fast/css/scroll-behavior-exposed-if-disabled-expected.txt: Added. * fast/css/scroll-behavior-exposed-if-disabled.html: Added. Canonical link: https://commits.webkit.org/234512@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2021-02-24 16:45:08 +00:00
PASS CSS.supports('overscroll-behavior: contain') is false
PASS CSS.supports('overscroll-behavior: inherit') is false
Runtime-disabled CSS features still still appear enabled via two-arg CSS.supports() https://bugs.webkit.org/show_bug.cgi?id=223141 Reviewed by Antti Koivisto. Source/WebCore: Fix the CSS.supports(property, value) entrypoint to check for runtime-disabled CSS properties. Move isPropertyRuntimeDisabled() to CSSParserContext, and call it from the appropriate DOMCSSNamespace::supports() entrypoint. Tested by fast/css/overscroll-behavior-invalidate-if-disabled.html * css/DOMCSSNamespace.cpp: (WebCore::DOMCSSNamespace::supports): * css/parser/CSSParserContext.cpp: (WebCore::CSSParserContext::isPropertyRuntimeDisabled const): * css/parser/CSSParserContext.h: * css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumeDeclaration): (WebCore::CSSParserImpl::isPropertyRuntimeDisabled const): Deleted. * css/parser/CSSParserImpl.h: LayoutTests: * fast/css/overscroll-behavior-invalidate-if-disabled-expected.txt: * fast/css/overscroll-behavior-invalidate-if-disabled.html: Canonical link: https://commits.webkit.org/235371@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@274520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2021-03-16 21:40:24 +00:00
PASS CSS.supports('overscroll-behavior', 'inherit') is false
Runtime-disabled CSS features still appear enabled via CSS.supports() https://bugs.webkit.org/show_bug.cgi?id=222280 rdar://74595641 Reviewed by Sam Weinig. Source/WebCore: When parsing CSS.supports() for a runtime-disabled property, we'd successfully parse a CSS-wide keyword like "inherit" and report that the property is supported. We need to explicitly check for runtime-disabled properties. Tests: css3/color-filters/color-filter-exposed-if-disabled.html fast/css/scroll-behavior-exposed-if-disabled.html * css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::isPropertyRuntimeDisabled const): (WebCore::CSSParserImpl::consumeDeclaration): * css/parser/CSSParserImpl.h: LayoutTests: * css3/color-filters/color-filter-exposed-if-disabled-expected.txt: Added. Fails tracked in webkit.org/b/217626 * css3/color-filters/color-filter-exposed-if-disabled.html: Added. * fast/css/overscroll-behavior-invalidate-if-disabled-expected.txt: * fast/css/overscroll-behavior-invalidate-if-disabled.html: * fast/css/scroll-behavior-exposed-if-disabled-expected.txt: Added. * fast/css/scroll-behavior-exposed-if-disabled.html: Added. Canonical link: https://commits.webkit.org/234512@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2021-02-24 16:45:08 +00:00
PASS CSS.supports('overscroll-behavior-x: inherit') is false
PASS CSS.supports('overscroll-behavior-y: inherit') is false
Support overscroll-behavior parsing https://bugs.webkit.org/show_bug.cgi?id=219305 Reviewed by Simon Fraser. Based on Frédéric Wang's patch. LayoutTests/imported/w3c: Update expectations for overscroll-behavior parsing tests. * web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * web-platform-tests/css/css-overscroll-behavior/inheritance-expected.txt: * web-platform-tests/css/css-overscroll-behavior/overscroll-behavior-logical-expected.txt: * web-platform-tests/css/css-overscroll-behavior/parsing/overscroll-behavior-computed-expected.txt: * web-platform-tests/css/css-overscroll-behavior/parsing/overscroll-behavior-valid-expected.txt: * web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Source/WebCore: Support parsing CSS properties: overscroll-behavior, overscroll-behavior-x and overscroll-behavior-y. Tests: fast/css/overscroll-behavior-invalidate-if-disabled.html fast/css/overscroll-behavior-validate-if-enable.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::settings const): (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/CSSComputedStyleDeclaration.h: * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator OverscrollBehavior const): * css/CSSProperties.json: * css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::settings const): (WebCore::CSSStyleDeclaration::namedItem): (WebCore::CSSStyleDeclaration::setNamedItem): (WebCore::CSSStyleDeclaration::supportedPropertyNames const): * css/CSSStyleDeclaration.h: * css/CSSValueKeywords.in: * css/StyleProperties.cpp: (WebCore::StyleProperties::getPropertyValue const): (WebCore::StyleProperties::asText const): * css/parser/CSSParserContext.cpp: (WebCore::CSSParserContext::CSSParserContext): (WebCore::operator==): * css/parser/CSSParserContext.h: (WebCore::CSSParserContextHash::hash): * css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): (WebCore::CSSParserFastPaths::isKeywordPropertyID): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeOverscrollBehavior): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::CSSPropertyParser::consumeOverscrollBehaviorShorthand): (WebCore::CSSPropertyParser::parseShorthand): * css/parser/CSSPropertyParser.h: * platform/ScrollTypes.h: * rendering/style/RenderStyle.h: (WebCore::RenderStyle::overscrollBehaviorX const): (WebCore::RenderStyle::overscrollBehaviorY const): (WebCore::RenderStyle::setOverscrollBehaviorX): (WebCore::RenderStyle::setOverscrollBehaviorY): (WebCore::RenderStyle::initialOverscrollBehaviorX): (WebCore::RenderStyle::initialOverscrollBehaviorY): * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator== const): * rendering/style/StyleRareNonInheritedData.h: Source/WebKitLegacy/win: Add an experimental feature flag for overscroll-behavior. * Interfaces/IWebPreferencesPrivate.idl: * WebPreferenceKeysPrivate.h: * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::overscrollBehaviorEnabled): (WebPreferences::setOverscrollBehaviorEnabled): * WebPreferences.h: * WebView.cpp: (WebView::notifyPreferencesChanged): Source/WTF: Add an experimental feature flag for overscroll-behavior. * Scripts/Preferences/WebPreferencesExperimental.yaml: Tools: Add support for testing overscroll-behavior parsing. * DumpRenderTree/TestOptions.cpp: (WTR::TestOptions::defaults): LayoutTests: Test overscrollBehavior's validation when enable or disable OverscrollBehaviorEnabled. * fast/css/overscroll-behavior-invalidate-if-disabled-expected.txt: Added. * fast/css/overscroll-behavior-invalidate-if-disabled.html: Added. * fast/css/overscroll-behavior-validate-if-enable-expected.txt: Added. * fast/css/overscroll-behavior-validate-if-enable.html: Added. * platform/ios-13/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: * platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Canonical link: https://commits.webkit.org/232280@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-12-10 06:39:21 +00:00
PASS successfullyParsed is true
TEST COMPLETE