nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/css/contain-invalidate-if-disab...

21 lines
679 B
HTML
Raw Permalink Normal View History

[css-contain] Parse CSS contain property https://bugs.webkit.org/show_bug.cgi?id=223252 Patch by Rob Buis <rbuis@igalia.com> on 2021-03-22 Reviewed by Darin Adler. LayoutTests/imported/w3c: Adjust test expectations. * web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * web-platform-tests/css/css-contain/content-visibility/content-visibility-026-expected.txt: * web-platform-tests/css/css-contain/inheritance-expected.txt: * web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt: * web-platform-tests/css/css-contain/parsing/contain-valid-expected.txt: * web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Source/WebCore: Parse CSS contain property according to the specification [1]. This patch also adds the experimental feature CSSContainment and makes contain invisible from style when disabled. [1] https://drafts.csswg.org/css-contain-1/#contain-property Test: fast/css/contain-invalidate-if-disabled.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/parser/CSSParserContext.cpp: (WebCore::operator==): (WebCore::CSSParserContext::isPropertyRuntimeDisabled const): * css/parser/CSSParserContext.h: (WebCore::CSSParserContextHash::hash): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeContain): (WebCore::CSSPropertyParser::parseSingleValue): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::contain const): (WebCore::RenderStyle::setContain): (WebCore::RenderStyle::initialContainment): (WebCore::RenderStyle::strictContainment): (WebCore::RenderStyle::contentContainment): * rendering/style/RenderStyleConstants.h: * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator== const): * rendering/style/StyleRareNonInheritedData.h: * style/StyleBuilderCustom.h: (WebCore::Style::BuilderCustom::applyInitialContain): (WebCore::Style::BuilderCustom::applyInheritContain): (WebCore::Style::BuilderCustom::applyValueContain): Source/WTF: Add experimental feature flag. * Scripts/Preferences/WebPreferencesExperimental.yaml: Tools: Add support for disabling aspect-ratio in win wk1. * DumpRenderTree/TestOptions.cpp: (WTR::TestOptions::defaults): LayoutTests: Add test to verify that contain is invisible from style when disabled. * fast/css/contain-invalidate-if-disabled-expected.txt: Added. * fast/css/contain-invalidate-if-disabled.html: Added. * platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Canonical link: https://commits.webkit.org/235596@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@274793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2021-03-22 20:51:10 +00:00
<!DOCTYPE html><!-- webkit-test-runner [ CSSContainmentEnabled=false ] -->
<html>
<head>
<meta charset="utf-8">
<script src="../../resources/js-test.js"></script>
</head>
<body>
Use Element for checking Settings in CSSComputedStyleDeclaration https://bugs.webkit.org/show_bug.cgi?id=223598 Patch by Rob Buis <rbuis@igalia.com> on 2021-04-01 Reviewed by Darin Adler. Source/WebCore: Use Element for checking Settings in CSSComputedStyleDeclaration. Right now renderer is used but this will not work for non-rendered elements. Tests: fast/css/rotate-invalidate-if-disabled.html fast/css/scale-invalidate-if-disabled.html fast/css/translate-invalidate-if-disabled.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): LayoutTests: Adapt tests to verify that non-rendered elements do not expose contain/aspect-ratio when these features are disabled. Add tests for rotate, scale and translate as well. * fast/css/aspect-ratio-invalidate-if-disabled-expected.txt: * fast/css/aspect-ratio-invalidate-if-disabled.html: * fast/css/contain-invalidate-if-disabled-expected.txt: * fast/css/contain-invalidate-if-disabled.html: * fast/css/overscroll-behavior-invalidate-if-disabled-expected.txt: * fast/css/overscroll-behavior-invalidate-if-disabled.html: * fast/css/rotate-invalidate-if-disabled-expected.txt: Added. * fast/css/rotate-invalidate-if-disabled.html: Added. * fast/css/scale-invalidate-if-disabled-expected.txt: Added. * fast/css/scale-invalidate-if-disabled.html: Added. * fast/css/translate-invalidate-if-disabled-expected.txt: Added. * fast/css/translate-invalidate-if-disabled.html: Added. * platform/win/TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275351 268f45cc-cd09-0410-ab3c-d52691b4dbfc Canonical link: https://commits.webkit.org/236022@main
2021-04-01 10:26:37 +00:00
<div id="target" style="display: none"></div>
[css-contain] Parse CSS contain property https://bugs.webkit.org/show_bug.cgi?id=223252 Patch by Rob Buis <rbuis@igalia.com> on 2021-03-22 Reviewed by Darin Adler. LayoutTests/imported/w3c: Adjust test expectations. * web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * web-platform-tests/css/css-contain/content-visibility/content-visibility-026-expected.txt: * web-platform-tests/css/css-contain/inheritance-expected.txt: * web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt: * web-platform-tests/css/css-contain/parsing/contain-valid-expected.txt: * web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Source/WebCore: Parse CSS contain property according to the specification [1]. This patch also adds the experimental feature CSSContainment and makes contain invisible from style when disabled. [1] https://drafts.csswg.org/css-contain-1/#contain-property Test: fast/css/contain-invalidate-if-disabled.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/parser/CSSParserContext.cpp: (WebCore::operator==): (WebCore::CSSParserContext::isPropertyRuntimeDisabled const): * css/parser/CSSParserContext.h: (WebCore::CSSParserContextHash::hash): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeContain): (WebCore::CSSPropertyParser::parseSingleValue): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::contain const): (WebCore::RenderStyle::setContain): (WebCore::RenderStyle::initialContainment): (WebCore::RenderStyle::strictContainment): (WebCore::RenderStyle::contentContainment): * rendering/style/RenderStyleConstants.h: * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator== const): * rendering/style/StyleRareNonInheritedData.h: * style/StyleBuilderCustom.h: (WebCore::Style::BuilderCustom::applyInitialContain): (WebCore::Style::BuilderCustom::applyInheritContain): (WebCore::Style::BuilderCustom::applyValueContain): Source/WTF: Add experimental feature flag. * Scripts/Preferences/WebPreferencesExperimental.yaml: Tools: Add support for disabling aspect-ratio in win wk1. * DumpRenderTree/TestOptions.cpp: (WTR::TestOptions::defaults): LayoutTests: Add test to verify that contain is invisible from style when disabled. * fast/css/contain-invalidate-if-disabled-expected.txt: Added. * fast/css/contain-invalidate-if-disabled.html: Added. * platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Canonical link: https://commits.webkit.org/235596@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@274793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2021-03-22 20:51:10 +00:00
<script>
description("Tests that contain is not exposed when the feature is disabled");
shouldBeFalse("'contain' in document.documentElement.style");
shouldBeFalse("'contain' in getComputedStyle(document.documentElement)");
Use Element for checking Settings in CSSComputedStyleDeclaration https://bugs.webkit.org/show_bug.cgi?id=223598 Patch by Rob Buis <rbuis@igalia.com> on 2021-04-01 Reviewed by Darin Adler. Source/WebCore: Use Element for checking Settings in CSSComputedStyleDeclaration. Right now renderer is used but this will not work for non-rendered elements. Tests: fast/css/rotate-invalidate-if-disabled.html fast/css/scale-invalidate-if-disabled.html fast/css/translate-invalidate-if-disabled.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): LayoutTests: Adapt tests to verify that non-rendered elements do not expose contain/aspect-ratio when these features are disabled. Add tests for rotate, scale and translate as well. * fast/css/aspect-ratio-invalidate-if-disabled-expected.txt: * fast/css/aspect-ratio-invalidate-if-disabled.html: * fast/css/contain-invalidate-if-disabled-expected.txt: * fast/css/contain-invalidate-if-disabled.html: * fast/css/overscroll-behavior-invalidate-if-disabled-expected.txt: * fast/css/overscroll-behavior-invalidate-if-disabled.html: * fast/css/rotate-invalidate-if-disabled-expected.txt: Added. * fast/css/rotate-invalidate-if-disabled.html: Added. * fast/css/scale-invalidate-if-disabled-expected.txt: Added. * fast/css/scale-invalidate-if-disabled.html: Added. * fast/css/translate-invalidate-if-disabled-expected.txt: Added. * fast/css/translate-invalidate-if-disabled.html: Added. * platform/win/TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275351 268f45cc-cd09-0410-ab3c-d52691b4dbfc Canonical link: https://commits.webkit.org/236022@main
2021-04-01 10:26:37 +00:00
shouldBeTrue("getComputedStyle(document.getElementById('target')).getPropertyValue('contain') == ''");
[css-contain] Parse CSS contain property https://bugs.webkit.org/show_bug.cgi?id=223252 Patch by Rob Buis <rbuis@igalia.com> on 2021-03-22 Reviewed by Darin Adler. LayoutTests/imported/w3c: Adjust test expectations. * web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * web-platform-tests/css/css-contain/content-visibility/content-visibility-026-expected.txt: * web-platform-tests/css/css-contain/inheritance-expected.txt: * web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt: * web-platform-tests/css/css-contain/parsing/contain-valid-expected.txt: * web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Source/WebCore: Parse CSS contain property according to the specification [1]. This patch also adds the experimental feature CSSContainment and makes contain invisible from style when disabled. [1] https://drafts.csswg.org/css-contain-1/#contain-property Test: fast/css/contain-invalidate-if-disabled.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/parser/CSSParserContext.cpp: (WebCore::operator==): (WebCore::CSSParserContext::isPropertyRuntimeDisabled const): * css/parser/CSSParserContext.h: (WebCore::CSSParserContextHash::hash): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeContain): (WebCore::CSSPropertyParser::parseSingleValue): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::contain const): (WebCore::RenderStyle::setContain): (WebCore::RenderStyle::initialContainment): (WebCore::RenderStyle::strictContainment): (WebCore::RenderStyle::contentContainment): * rendering/style/RenderStyleConstants.h: * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator== const): * rendering/style/StyleRareNonInheritedData.h: * style/StyleBuilderCustom.h: (WebCore::Style::BuilderCustom::applyInitialContain): (WebCore::Style::BuilderCustom::applyInheritContain): (WebCore::Style::BuilderCustom::applyValueContain): Source/WTF: Add experimental feature flag. * Scripts/Preferences/WebPreferencesExperimental.yaml: Tools: Add support for disabling aspect-ratio in win wk1. * DumpRenderTree/TestOptions.cpp: (WTR::TestOptions::defaults): LayoutTests: Add test to verify that contain is invisible from style when disabled. * fast/css/contain-invalidate-if-disabled-expected.txt: Added. * fast/css/contain-invalidate-if-disabled.html: Added. * platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Canonical link: https://commits.webkit.org/235596@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@274793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2021-03-22 20:51:10 +00:00
shouldBeFalse("CSS.supports('contain: paint')");
shouldBeFalse("CSS.supports('contain: inherit')");
</script>
</body>
</html>