nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/css/appearance-apple-pay-button...

53 lines
1.5 KiB
HTML
Raw Permalink Normal View History

[Apple Pay] Buttons render with a corner radius of PKApplePayButtonDefaultCornerRadius even when explicitly specifying "border-radius: 0px" https://bugs.webkit.org/show_bug.cgi?id=212476 <rdar://problem/63401433> Reviewed by Antti Koivisto. Source/WebCore: r256648 added support for customizing the corner radius of Apple Pay buttons using the border-radius CSS property. PassKit buttons have a default corner radius of 4, but border-radius has an initial value of 0, so to maintain web compatibility with existing buttons we only want to customize the corner radius when a border-radius value has been explicitly specified (otherwise, previously rounded buttons would all become squared off due to border-radius's initial value). r256648 checked for a non-initial border-radius by calling RenderStyle::hasBorderRadius, but this check does not distinguish between an initial value and an explicit declaration of "border-radius: 0px". As a result, authors are unable to create Apple Pay buttons with square corners. This patch adds a flag to RenderStyle::NonInheritedFlags that tracks whether any border-radius longhand has been explicitly set (or has explicitly inherited an explicitly set value), and uses that flag to adjust the computed border radius for Apple Pay buttons. The addition of RenderStyle::NonInheritedFlags::hasExplicitlySetBorderRadius did not change the size of RenderStyle. Tests: fast/css/appearance-apple-pay-button-border-radius.html fast/css/getComputedStyle/computed-style-apple-pay-button.html * css/CSSProperties.json: * rendering/RenderThemeCocoa.mm: (WebCore::RenderThemeCocoa::adjustApplePayButtonStyle const): (WebCore::RenderThemeCocoa::paintApplePayButton): (WebCore::largestCornerRadius): Deleted. * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::hasExplicitlySetBorderRadius const): (WebCore::RenderStyle::setHasExplicitlySetBorderRadius): (WebCore::RenderStyle::NonInheritedFlags::operator== const): (WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom): * style/StyleBuilderCustom.h: (WebCore::Style::BuilderCustom::applyInheritBorderBottomLeftRadius): (WebCore::Style::BuilderCustom::applyValueBorderBottomLeftRadius): (WebCore::Style::BuilderCustom::applyInheritBorderBottomRightRadius): (WebCore::Style::BuilderCustom::applyValueBorderBottomRightRadius): (WebCore::Style::BuilderCustom::applyInheritBorderTopLeftRadius): (WebCore::Style::BuilderCustom::applyValueBorderTopLeftRadius): (WebCore::Style::BuilderCustom::applyInheritBorderTopRightRadius): (WebCore::Style::BuilderCustom::applyValueBorderTopRightRadius): LayoutTests: * TestExpectations: * fast/css/appearance-apple-pay-button-border-radius-expected.html: Added. * fast/css/appearance-apple-pay-button-border-radius.html: Added. * fast/css/appearance-apple-pay-button-expected.html: * fast/css/appearance-apple-pay-button.html: * fast/css/getComputedStyle/computed-style-apple-pay-button-expected.txt: Added. * fast/css/getComputedStyle/computed-style-apple-pay-button.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/225331@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-29 04:08:16 +00:00
<!DOCTYPE html>
<html>
<head>
<style>
.container {
padding: 25px;
width: 500px;
}
.apple-pay-button {
-webkit-appearance: -apple-pay-button;
}
.square-corners {
border-radius: 0px;
}
</style>
</head>
<body>
<div class='container'>
<button class='apple-pay-button'></button>
<button class='apple-pay-button'></button>
<button class='apple-pay-button'></button>
<button class='apple-pay-button'></button>
</div>
<div class='container'>
<button class='apple-pay-button square-corners'></button>
<button class='apple-pay-button'></button>
<button class='apple-pay-button'></button>
<button class='apple-pay-button'></button>
</div>
<div class='container'>
<button class='apple-pay-button square-corners'></button>
<div>
<button class='apple-pay-button square-corners'></button>
<button class='apple-pay-button square-corners'></button>
<div class='square-corners'></div>
</div>
</div>
<div class='container'>
<button class='apple-pay-button'></button>
<button></button>
<span></span>
<span></span>
</div>
[Apple Pay] Support percentage border-radius values in -apple-pay-button https://bugs.webkit.org/show_bug.cgi?id=212559 <rdar://problem/63781881> Reviewed by Antti Koivisto. Source/WebCore: Added test cases to fast/css/appearance-apple-pay-button-border-radius.html. * rendering/RenderThemeCocoa.mm: (WebCore::RenderThemeCocoa::paintApplePayButton): Used floatValueForLength() to ensure percentage lengths are resolved before passing a corner radius to PassKit. LayoutTests: * fast/css/appearance-apple-pay-button-border-radius-expected.html: * fast/css/appearance-apple-pay-button-border-radius.html: Canonical link: https://commits.webkit.org/225396@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-30 17:42:43 +00:00
<div class='container'>
<button class='apple-pay-button' style='border-radius: 0'></button>
<button class='apple-pay-button'></button>
<button class='apple-pay-button' style='-apple-pay-button-type: buy; border-radius: 7px'></button>
</div>
[Apple Pay] Buttons render with a corner radius of PKApplePayButtonDefaultCornerRadius even when explicitly specifying "border-radius: 0px" https://bugs.webkit.org/show_bug.cgi?id=212476 <rdar://problem/63401433> Reviewed by Antti Koivisto. Source/WebCore: r256648 added support for customizing the corner radius of Apple Pay buttons using the border-radius CSS property. PassKit buttons have a default corner radius of 4, but border-radius has an initial value of 0, so to maintain web compatibility with existing buttons we only want to customize the corner radius when a border-radius value has been explicitly specified (otherwise, previously rounded buttons would all become squared off due to border-radius's initial value). r256648 checked for a non-initial border-radius by calling RenderStyle::hasBorderRadius, but this check does not distinguish between an initial value and an explicit declaration of "border-radius: 0px". As a result, authors are unable to create Apple Pay buttons with square corners. This patch adds a flag to RenderStyle::NonInheritedFlags that tracks whether any border-radius longhand has been explicitly set (or has explicitly inherited an explicitly set value), and uses that flag to adjust the computed border radius for Apple Pay buttons. The addition of RenderStyle::NonInheritedFlags::hasExplicitlySetBorderRadius did not change the size of RenderStyle. Tests: fast/css/appearance-apple-pay-button-border-radius.html fast/css/getComputedStyle/computed-style-apple-pay-button.html * css/CSSProperties.json: * rendering/RenderThemeCocoa.mm: (WebCore::RenderThemeCocoa::adjustApplePayButtonStyle const): (WebCore::RenderThemeCocoa::paintApplePayButton): (WebCore::largestCornerRadius): Deleted. * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::hasExplicitlySetBorderRadius const): (WebCore::RenderStyle::setHasExplicitlySetBorderRadius): (WebCore::RenderStyle::NonInheritedFlags::operator== const): (WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom): * style/StyleBuilderCustom.h: (WebCore::Style::BuilderCustom::applyInheritBorderBottomLeftRadius): (WebCore::Style::BuilderCustom::applyValueBorderBottomLeftRadius): (WebCore::Style::BuilderCustom::applyInheritBorderBottomRightRadius): (WebCore::Style::BuilderCustom::applyValueBorderBottomRightRadius): (WebCore::Style::BuilderCustom::applyInheritBorderTopLeftRadius): (WebCore::Style::BuilderCustom::applyValueBorderTopLeftRadius): (WebCore::Style::BuilderCustom::applyInheritBorderTopRightRadius): (WebCore::Style::BuilderCustom::applyValueBorderTopRightRadius): LayoutTests: * TestExpectations: * fast/css/appearance-apple-pay-button-border-radius-expected.html: Added. * fast/css/appearance-apple-pay-button-border-radius.html: Added. * fast/css/appearance-apple-pay-button-expected.html: * fast/css/appearance-apple-pay-button.html: * fast/css/getComputedStyle/computed-style-apple-pay-button-expected.txt: Added. * fast/css/getComputedStyle/computed-style-apple-pay-button.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/225331@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-05-29 04:08:16 +00:00
</body>
</html>