nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/fast/css-grid-layout/grid-indefinite-calculated-...

4 lines
207 B
Plaintext
Raw Permalink Normal View History

Unprefix -webkit-min-content, -webkit-max-content and -webkit-fit-content https://bugs.webkit.org/show_bug.cgi?id=169195 Reviewed by Sergio Villar Senin. Based on Blink r200846 by <cbiesinger@chromium.org>. https://src.chromium.org/viewvc/blink?revision=200846&view=revision Source/WebCore: This patch adds support for the unprefixed version of these properties, while it keeps the prefixed ones working too. -webkit-fill-available is left out of this change, as the CSS WG is still defining the final keyword and behavior. With this patch WebKit will be in the same situation than Blink regarding these intrinsic sizing keywords (see http://crbug.com/245157). Test: fast/css-intrinsic-dimensions/height-property-value.html fast/css-intrinsic-dimensions/width-property-value.html * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::init): * css/CSSValueKeywords.in: * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::convertLengthSizing): (WebCore::StyleBuilderConverter::createGridTrackBreadth): * css/html.css: (fieldset): * css/parser/CSSPropertyParser.cpp: (WebCore::validWidthOrHeightKeyword): (WebCore::isGridTrackFixedSized): (WebCore::consumeGridBreadth): * html/track/TextTrackCueGeneric.cpp: (WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): * html/track/VTTCue.cpp: (WebCore::VTTCueBox::applyCSSProperties): LayoutTests: For most of the tests the only change is that we remove the prefix in these properties. Additionally we're checking the behavior of both the prefixed and unprefixed versions in: - fast/css-intrinsic-dimensions/height-property-value.html - fast/css-intrinsic-dimensions/width-property-value.html On top of that, a few tests from the CSS Grid Layout W3C test suite are now passing. * TestExpectations: * css3/flexbox/flexitem.html: * css3/flexbox/orthogonal-writing-modes-and-intrinsic-sizing-expected.txt: Update results as tests is now passing (it was using "min-content" already and thus failing on WebKit). * css3/flexbox/overflow-auto-resizes-correctly.html: * fast/css-grid-layout/fit-content-columns-expected.html: * fast/css-grid-layout/fit-content-columns.html: * fast/css-grid-layout/fit-content-rows-expected.html: * fast/css-grid-layout/fit-content-rows.html: * fast/css-grid-layout/flex-and-content-sized-resolution-columns.html: * fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html: * fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html: * fast/css-grid-layout/float-not-protruding-into-next-grid-item.html: * fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html: * fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt: * fast/css-grid-layout/grid-auto-columns-rows-get-set.html: * fast/css-grid-layout/grid-auto-columns-rows-resolution.html: * fast/css-grid-layout/grid-auto-columns-rows-update.html: * fast/css-grid-layout/grid-auto-fill-columns.html: * fast/css-grid-layout/grid-auto-fill-rows.html: * fast/css-grid-layout/grid-auto-fit-columns.html: * fast/css-grid-layout/grid-auto-fit-rows.html: * fast/css-grid-layout/grid-auto-repeat-intrinsic.html: * fast/css-grid-layout/grid-automatic-minimum-for-auto-columns.html: * fast/css-grid-layout/grid-automatic-minimum-for-auto-rows.html: * fast/css-grid-layout/grid-change-intrinsic-size-with-auto-repeat-tracks.html: * fast/css-grid-layout/grid-columns-rows-get-set-expected.txt: * fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt: * fast/css-grid-layout/grid-columns-rows-get-set-multiple.html: * fast/css-grid-layout/grid-columns-rows-get-set.html: * fast/css-grid-layout/grid-content-alignment-overflow.html: * fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks.html: * fast/css-grid-layout/grid-content-sized-columns-resolution.html: * fast/css-grid-layout/grid-dynamic-updates-relayout.html: * fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt: * fast/css-grid-layout/grid-element-auto-repeat-get-set.html: * fast/css-grid-layout/grid-element-repeat-get-set.html: * fast/css-grid-layout/grid-grow-tracks-to-their-max.html: * fast/css-grid-layout/grid-gutters-and-flex-content.html: * fast/css-grid-layout/grid-gutters-and-tracks.html: * fast/css-grid-layout/grid-gutters-get-set.html: * fast/css-grid-layout/grid-indefinite-calculated-height-crash-expected.txt: * fast/css-grid-layout/grid-indefinite-calculated-height-crash.html: * fast/css-grid-layout/grid-initialize-span-one-items.html: * fast/css-grid-layout/grid-intrinsic-maximums.html: * fast/css-grid-layout/grid-item-addition-track-breadth-update.html: * fast/css-grid-layout/grid-item-auto-margins-must-respect-specified-margins.html: * fast/css-grid-layout/grid-item-order-in-content-sized-columns-resolution.html: * fast/css-grid-layout/grid-item-removal-track-breadth-update.html: * fast/css-grid-layout/grid-item-sizing-with-orthogonal-flows.html: * fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows.html: * fast/css-grid-layout/grid-item-with-border-in-intrinsic.html: * fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html: * fast/css-grid-layout/grid-preferred-logical-widths.html: * fast/css-grid-layout/grid-template-shorthand-get-set.html: * fast/css-grid-layout/grid-update-sizes-after-distributing-all.html: * fast/css-grid-layout/implicit-position-dynamic-change.html: * fast/css-grid-layout/mark-as-infinitely-growable.html: * fast/css-grid-layout/min-content-row-must-shrink-when-column-grows.html: * fast/css-grid-layout/minmax-max-content-resolution-columns.html: * fast/css-grid-layout/minmax-max-content-resolution-rows.html: * fast/css-grid-layout/minmax-min-content-column-resolution-columns.html: * fast/css-grid-layout/minmax-min-content-column-resolution-rows.html: * fast/css-grid-layout/minmax-spanning-resolution-columns.html: * fast/css-grid-layout/minmax-spanning-resolution-rows.html: * fast/css-grid-layout/named-grid-line-get-set-expected.txt: * fast/css-grid-layout/named-grid-line-get-set.html: * fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt: * fast/css-grid-layout/non-grid-columns-rows-get-set-multiple-expected.txt: * fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html: * fast/css-grid-layout/non-grid-columns-rows-get-set.html: * fast/css-grid-layout/non-named-grid-line-get-set-expected.txt: * fast/css-grid-layout/non-named-grid-line-get-set.html: * fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js: * fast/css-grid-layout/resources/grid-columns-rows-get-set.js: * fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js: * fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js: * fast/css-intrinsic-dimensions/css-tables.html: * fast/css-intrinsic-dimensions/height-property-value-expected.txt: * fast/css-intrinsic-dimensions/height-property-value.html: * fast/css-intrinsic-dimensions/intrinsic-sized-absolutes.html: * fast/css-intrinsic-dimensions/intrinsic-sized-blocks.html: * fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes.html: * fast/css-intrinsic-dimensions/tables.html: * fast/css-intrinsic-dimensions/width-property-value-expected.txt: * fast/css-intrinsic-dimensions/width-property-value.html: * fast/events/key-events-in-editable-gridbox.html: * fast/regions/intrinsic-sized-regions.html: * fast/regions/overflow/overflow-scrollable-fit-complex-expected.html: * fast/replaced/before-content-intrinsic-crash.html: * fast/table/assert-on-min-max-content-values.html: * imported/blink/svg/css/replaced-intrinsic-ratio-min-width-min-content.html: Canonical link: https://commits.webkit.org/186540@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-03-13 11:44:45 +00:00
* { display: inline-grid; height: calc(100% - 10px); grid-template-rows: minmax(100%, max-content); }
[CSS Grid Layout] ASSERTION FAILED !track.growthLimitIsInfinite() in RenderGrid::computeUsedBreadthOfGridTracks https://bugs.webkit.org/show_bug.cgi?id=142265 Reviewed by Darin Adler. Source/WebCore: The problem is that computeUsedBreadthOfGridTracks() could return -1 for rows because we're calling computeContentLogicalHeight() which can indeed return -1. In those cases we should clamp the value to 0 the same as Flexbox does otherwise we could end up with a negative value in the min track sizing function. Test: fast/css-grid-layout/grid-indefinite-calculated-height-crash.html * rendering/RenderGrid.cpp: (WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength): LayoutTests: New test that crashes on Debug builds if we don't handle the case of computeUsedBreadthOfGridTracks() returning -1. * fast/css-grid-layout/grid-indefinite-calculated-height-crash-expected.txt: Added. * fast/css-grid-layout/grid-indefinite-calculated-height-crash.html: Added. Canonical link: https://commits.webkit.org/160425@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-03-06 08:55:53 +00:00
if (window.testRunner) testRunner.dumpAsText();
This test has PASSED if it didn't CRASH on Debug builds.