nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/css3/scroll-snap/scroll-snap-elements-contai...

6 lines
114 B
Plaintext
Raw Permalink Normal View History

Scroll snap: don't create implicit snap points at scrollmin/scrollmax https://bugs.webkit.org/show_bug.cgi?id=216882 <rdar://problem/69443288> Patch by Martin Robinson <mrobinson@igalia.com> on 2020-10-22 Reviewed by Simon Fraser. LayoutTests/imported/w3c: Update expectations for these tests. * web-platform-tests/css/css-scroll-snap/nested-scrollIntoView-snaps-expected.txt: * web-platform-tests/css/css-scroll-snap/snap-after-relayout/adding-only-snap-area-expected.txt: * web-platform-tests/css/css-scroll-snap/snap-after-relayout/changing-scroll-snap-align-expected.txt: * web-platform-tests/css/css-scroll-snap/snap-after-relayout/snap-to-different-targets-expected.txt: * web-platform-tests/css/css-scroll-snap/snap-area-capturing-remove-scroll-container-expected.txt: Source/WebCore: * page/scrolling/AxisScrollSnapOffsets.cpp: (WebCore::updateSnapOffsetsForScrollableArea): No longer call adjustmentForTextAutosizing and only conditionally adjust the scroll area by the scroll offset, becauase mapping to container coordinates only applies container scroll offsets in the case that the container is not a ScrollView. (WebCore::adjustAxisSnapOffsetsForScrollExtent): Deleted. LayoutTests: * TestExpectations: Mark some tests as passing. * css3/scroll-snap/nested-elements-expected.txt: Update results to eliminate implicit stops. * css3/scroll-snap/scroll-snap-children-with-padding-expected.txt: Ditto. * css3/scroll-snap/scroll-snap-children-with-scroll-snap-margin-expected.txt: Ditto. * css3/scroll-snap/scroll-snap-children-with-transforms-expected.txt: Ditto. * css3/scroll-snap/scroll-snap-elements-container-larger-than-children-expected.txt: Ditto. * css3/scroll-snap/scroll-snap-elements-container-larger-than-children-rtl-expected.txt: Ditto. * css3/scroll-snap/scroll-snap-offsets-expected.txt: Ditto. * css3/scroll-snap/scroll-snap-offsets-rtl-expected.txt: Ditto. * css3/scroll-snap/scroll-snap-positions-expected.txt: Ditto. * css3/scroll-snap/scroll-snap-with-scroll-padding-expected.txt: Ditto. Canonical link: https://commits.webkit.org/230784@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-10-22 07:32:40 +00:00
Scroll-snap offsets: horizontal = { 0, 200, 400, 600, 800, 1000 }
The web process hangs when computing elements-based snap points for a container with large max scroll offset https://bugs.webkit.org/show_bug.cgi?id=152605 <rdar://problem/25353661> Reviewed by Simon Fraser. Source/WebCore: Fixes a bug in the computation of axis snap points. The ScrollSnapPoints object, which tracks snap points along a particular axis, has two flags, hasRepeat and usesElements. For elements- based snapping, both flags would be turned on, since StyleBuilderConverter::convertScrollSnapPoints short-circuits for elements-based snapping and does not default usesRepeat to false. To address this, we make ScrollSnapPoints not repeat(100%) by default. Test: css3/scroll-snap/scroll-snap-elements-container-larger-than-children.html * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::convertScrollSnapPoints): Deleted. * rendering/style/StyleScrollSnapPoints.cpp: (WebCore::ScrollSnapPoints::ScrollSnapPoints): LayoutTests: Adds a scroll snap offset computation test case that would have previously caused the web process to hang before this patch. * css3/scroll-snap/scroll-snap-elements-container-larger-than-children-expected.txt: Added. * css3/scroll-snap/scroll-snap-elements-container-larger-than-children.html: Added. Canonical link: https://commits.webkit.org/178314@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@203684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-07-25 16:03:31 +00:00
PASS successfullyParsed is true
TEST COMPLETE