nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/css3/parsing-css3-nthchild-expec...

20 lines
502 B
Plaintext
Raw Permalink Normal View History

CSS3 Selectors failures on css3test.com https://bugs.webkit.org/show_bug.cgi?id=83885 Patch by Uday Kiran <udaykiran@motorola.com> on 2012-04-16 Reviewed by Zoltan Herczeg. Source/WebCore: Parsing fix for CSS3 selectors :nth-child(), :nth-last-child() :nth-of-type() :nth-last-of-type() with values -n-b and n-b as they are of valid form an+b where a and b are integers. http://www.w3.org/TR/selectors/#structural-pseudos Descriptors of form n-b or -n-b, where b is number, are valid CSS identifiers. However, in NthChildMode we need to check whether this identifier is a valid nth child descriptor. The original code only checked this if the string was n- or -n- but this is not enough. We need to check everything which starts with an n- or -n- prefix. Test: css3/parsing-css3-nthchild.html * css/CSSParser.cpp: (WebCore::CSSParser::lex): LayoutTests: * css3/parsing-css3-nthchild-expected.txt: Added. * css3/parsing-css3-nthchild.html: Added. Canonical link: https://commits.webkit.org/101536@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-04-16 15:36:24 +00:00
SUCCESS
Rules from the stylesheet:
#a:nth-child(n-1) { color: green; }
LayoutTests/imported/w3c: Fix nth-child An+B serialization to match the spc https://bugs.webkit.org/show_bug.cgi?id=203464 Reviewed by Antti Koivisto. New passing results. * web-platform-tests/css/css-syntax/anb-parsing-expected.txt: * web-platform-tests/css/css-syntax/anb-serialization-expected.txt: * web-platform-tests/css/cssom/selectorSerialize-expected.txt: * web-platform-tests/css/selectors/anplusb-selector-parsing-expected.txt: Source/WebCore: Fix nth-child An+B serialization to match the spec https://bugs.webkit.org/show_bug.cgi?id=203464 Reviewed by Antti Koivisto. The spec says to expand "odd" and "even" to "2n+1" and "2n", and to simplify things like "1n+1" and "0n" Tested by existing tests. * css/CSSSelector.cpp: (WebCore::outputNthChildAnPlusB): (WebCore::CSSSelector::selectorText const): LayoutTests: Fix nth-child An+B serialization to match the spc https://bugs.webkit.org/show_bug.cgi?id=203464 Reviewed by Antti Koivisto. New results. Some tests that assumed that the selectors simply round-trip had to be fixed to supply test and expected selectors. * css3/parsing-css3-nthchild-expected.txt: * css3/parsing-css3-nthchild.html: * fast/css/css-selector-text-expected.txt: * fast/css/css-selector-text.html: * fast/css/css-set-selector-text-expected.txt: * fast/css/css-set-selector-text.html: * fast/css/parsing-css-matches-1-expected.txt: * fast/css/parsing-css-matches-1.html: * fast/css/parsing-css-matches-2-expected.txt: * fast/css/parsing-css-matches-2.html: * fast/css/parsing-css-matches-4-expected.txt: * fast/css/parsing-css-matches-4.html: * fast/css/parsing-css-not-1-expected.txt: * fast/css/parsing-css-not-1.html: * fast/css/parsing-css-not-2-expected.txt: * fast/css/parsing-css-not-2.html: * fast/css/parsing-css-not-4-expected.txt: * fast/css/parsing-css-not-4.html: * fast/css/parsing-css-nth-child-expected.txt: * fast/css/parsing-css-nth-child-of-1-expected.txt: * fast/css/parsing-css-nth-child-of-1.html: * fast/css/parsing-css-nth-child-of-2-expected.txt: * fast/css/parsing-css-nth-child-of-2.html: * fast/css/parsing-css-nth-child.html: * fast/css/parsing-css-nth-last-child-of-1-expected.txt: * fast/css/parsing-css-nth-last-child-of-1.html: * fast/css/parsing-css-nth-last-child-of-2-expected.txt: * fast/css/parsing-css-nth-last-child-of-2.html: * fast/dom/css-selectorText-expected.txt: Canonical link: https://commits.webkit.org/216874@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-10-28 04:49:52 +00:00
#b:nth-child(n-10) { color: green; }
CSS3 Selectors failures on css3test.com https://bugs.webkit.org/show_bug.cgi?id=83885 Patch by Uday Kiran <udaykiran@motorola.com> on 2012-04-16 Reviewed by Zoltan Herczeg. Source/WebCore: Parsing fix for CSS3 selectors :nth-child(), :nth-last-child() :nth-of-type() :nth-last-of-type() with values -n-b and n-b as they are of valid form an+b where a and b are integers. http://www.w3.org/TR/selectors/#structural-pseudos Descriptors of form n-b or -n-b, where b is number, are valid CSS identifiers. However, in NthChildMode we need to check whether this identifier is a valid nth child descriptor. The original code only checked this if the string was n- or -n- but this is not enough. We need to check everything which starts with an n- or -n- prefix. Test: css3/parsing-css3-nthchild.html * css/CSSParser.cpp: (WebCore::CSSParser::lex): LayoutTests: * css3/parsing-css3-nthchild-expected.txt: Added. * css3/parsing-css3-nthchild.html: Added. Canonical link: https://commits.webkit.org/101536@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-04-16 15:36:24 +00:00
#g:nth-child(-n-1) { color: green; }
LayoutTests/imported/w3c: Fix nth-child An+B serialization to match the spc https://bugs.webkit.org/show_bug.cgi?id=203464 Reviewed by Antti Koivisto. New passing results. * web-platform-tests/css/css-syntax/anb-parsing-expected.txt: * web-platform-tests/css/css-syntax/anb-serialization-expected.txt: * web-platform-tests/css/cssom/selectorSerialize-expected.txt: * web-platform-tests/css/selectors/anplusb-selector-parsing-expected.txt: Source/WebCore: Fix nth-child An+B serialization to match the spec https://bugs.webkit.org/show_bug.cgi?id=203464 Reviewed by Antti Koivisto. The spec says to expand "odd" and "even" to "2n+1" and "2n", and to simplify things like "1n+1" and "0n" Tested by existing tests. * css/CSSSelector.cpp: (WebCore::outputNthChildAnPlusB): (WebCore::CSSSelector::selectorText const): LayoutTests: Fix nth-child An+B serialization to match the spc https://bugs.webkit.org/show_bug.cgi?id=203464 Reviewed by Antti Koivisto. New results. Some tests that assumed that the selectors simply round-trip had to be fixed to supply test and expected selectors. * css3/parsing-css3-nthchild-expected.txt: * css3/parsing-css3-nthchild.html: * fast/css/css-selector-text-expected.txt: * fast/css/css-selector-text.html: * fast/css/css-set-selector-text-expected.txt: * fast/css/css-set-selector-text.html: * fast/css/parsing-css-matches-1-expected.txt: * fast/css/parsing-css-matches-1.html: * fast/css/parsing-css-matches-2-expected.txt: * fast/css/parsing-css-matches-2.html: * fast/css/parsing-css-matches-4-expected.txt: * fast/css/parsing-css-matches-4.html: * fast/css/parsing-css-not-1-expected.txt: * fast/css/parsing-css-not-1.html: * fast/css/parsing-css-not-2-expected.txt: * fast/css/parsing-css-not-2.html: * fast/css/parsing-css-not-4-expected.txt: * fast/css/parsing-css-not-4.html: * fast/css/parsing-css-nth-child-expected.txt: * fast/css/parsing-css-nth-child-of-1-expected.txt: * fast/css/parsing-css-nth-child-of-1.html: * fast/css/parsing-css-nth-child-of-2-expected.txt: * fast/css/parsing-css-nth-child-of-2.html: * fast/css/parsing-css-nth-child.html: * fast/css/parsing-css-nth-last-child-of-1-expected.txt: * fast/css/parsing-css-nth-last-child-of-1.html: * fast/css/parsing-css-nth-last-child-of-2-expected.txt: * fast/css/parsing-css-nth-last-child-of-2.html: * fast/dom/css-selectorText-expected.txt: Canonical link: https://commits.webkit.org/216874@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-10-28 04:49:52 +00:00
#h:nth-child(-n-10) { color: green; }
#n:nth-child(-n-1) { color: green; }
#o:nth-child(-n+13) { color: green; }
CSS3 Selectors failures on css3test.com https://bugs.webkit.org/show_bug.cgi?id=83885 Patch by Uday Kiran <udaykiran@motorola.com> on 2012-04-16 Reviewed by Zoltan Herczeg. Source/WebCore: Parsing fix for CSS3 selectors :nth-child(), :nth-last-child() :nth-of-type() :nth-last-of-type() with values -n-b and n-b as they are of valid form an+b where a and b are integers. http://www.w3.org/TR/selectors/#structural-pseudos Descriptors of form n-b or -n-b, where b is number, are valid CSS identifiers. However, in NthChildMode we need to check whether this identifier is a valid nth child descriptor. The original code only checked this if the string was n- or -n- but this is not enough. We need to check everything which starts with an n- or -n- prefix. Test: css3/parsing-css3-nthchild.html * css/CSSParser.cpp: (WebCore::CSSParser::lex): LayoutTests: * css3/parsing-css3-nthchild-expected.txt: Added. * css3/parsing-css3-nthchild.html: Added. Canonical link: https://commits.webkit.org/101536@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-04-16 15:36:24 +00:00
Expected result:
#a:nth-child(n-1) { color: green; }
LayoutTests/imported/w3c: Fix nth-child An+B serialization to match the spc https://bugs.webkit.org/show_bug.cgi?id=203464 Reviewed by Antti Koivisto. New passing results. * web-platform-tests/css/css-syntax/anb-parsing-expected.txt: * web-platform-tests/css/css-syntax/anb-serialization-expected.txt: * web-platform-tests/css/cssom/selectorSerialize-expected.txt: * web-platform-tests/css/selectors/anplusb-selector-parsing-expected.txt: Source/WebCore: Fix nth-child An+B serialization to match the spec https://bugs.webkit.org/show_bug.cgi?id=203464 Reviewed by Antti Koivisto. The spec says to expand "odd" and "even" to "2n+1" and "2n", and to simplify things like "1n+1" and "0n" Tested by existing tests. * css/CSSSelector.cpp: (WebCore::outputNthChildAnPlusB): (WebCore::CSSSelector::selectorText const): LayoutTests: Fix nth-child An+B serialization to match the spc https://bugs.webkit.org/show_bug.cgi?id=203464 Reviewed by Antti Koivisto. New results. Some tests that assumed that the selectors simply round-trip had to be fixed to supply test and expected selectors. * css3/parsing-css3-nthchild-expected.txt: * css3/parsing-css3-nthchild.html: * fast/css/css-selector-text-expected.txt: * fast/css/css-selector-text.html: * fast/css/css-set-selector-text-expected.txt: * fast/css/css-set-selector-text.html: * fast/css/parsing-css-matches-1-expected.txt: * fast/css/parsing-css-matches-1.html: * fast/css/parsing-css-matches-2-expected.txt: * fast/css/parsing-css-matches-2.html: * fast/css/parsing-css-matches-4-expected.txt: * fast/css/parsing-css-matches-4.html: * fast/css/parsing-css-not-1-expected.txt: * fast/css/parsing-css-not-1.html: * fast/css/parsing-css-not-2-expected.txt: * fast/css/parsing-css-not-2.html: * fast/css/parsing-css-not-4-expected.txt: * fast/css/parsing-css-not-4.html: * fast/css/parsing-css-nth-child-expected.txt: * fast/css/parsing-css-nth-child-of-1-expected.txt: * fast/css/parsing-css-nth-child-of-1.html: * fast/css/parsing-css-nth-child-of-2-expected.txt: * fast/css/parsing-css-nth-child-of-2.html: * fast/css/parsing-css-nth-child.html: * fast/css/parsing-css-nth-last-child-of-1-expected.txt: * fast/css/parsing-css-nth-last-child-of-1.html: * fast/css/parsing-css-nth-last-child-of-2-expected.txt: * fast/css/parsing-css-nth-last-child-of-2.html: * fast/dom/css-selectorText-expected.txt: Canonical link: https://commits.webkit.org/216874@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-10-28 04:49:52 +00:00
#b:nth-child(n-10) { color: green; }
CSS3 Selectors failures on css3test.com https://bugs.webkit.org/show_bug.cgi?id=83885 Patch by Uday Kiran <udaykiran@motorola.com> on 2012-04-16 Reviewed by Zoltan Herczeg. Source/WebCore: Parsing fix for CSS3 selectors :nth-child(), :nth-last-child() :nth-of-type() :nth-last-of-type() with values -n-b and n-b as they are of valid form an+b where a and b are integers. http://www.w3.org/TR/selectors/#structural-pseudos Descriptors of form n-b or -n-b, where b is number, are valid CSS identifiers. However, in NthChildMode we need to check whether this identifier is a valid nth child descriptor. The original code only checked this if the string was n- or -n- but this is not enough. We need to check everything which starts with an n- or -n- prefix. Test: css3/parsing-css3-nthchild.html * css/CSSParser.cpp: (WebCore::CSSParser::lex): LayoutTests: * css3/parsing-css3-nthchild-expected.txt: Added. * css3/parsing-css3-nthchild.html: Added. Canonical link: https://commits.webkit.org/101536@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-04-16 15:36:24 +00:00
#g:nth-child(-n-1) { color: green; }
LayoutTests/imported/w3c: Fix nth-child An+B serialization to match the spc https://bugs.webkit.org/show_bug.cgi?id=203464 Reviewed by Antti Koivisto. New passing results. * web-platform-tests/css/css-syntax/anb-parsing-expected.txt: * web-platform-tests/css/css-syntax/anb-serialization-expected.txt: * web-platform-tests/css/cssom/selectorSerialize-expected.txt: * web-platform-tests/css/selectors/anplusb-selector-parsing-expected.txt: Source/WebCore: Fix nth-child An+B serialization to match the spec https://bugs.webkit.org/show_bug.cgi?id=203464 Reviewed by Antti Koivisto. The spec says to expand "odd" and "even" to "2n+1" and "2n", and to simplify things like "1n+1" and "0n" Tested by existing tests. * css/CSSSelector.cpp: (WebCore::outputNthChildAnPlusB): (WebCore::CSSSelector::selectorText const): LayoutTests: Fix nth-child An+B serialization to match the spc https://bugs.webkit.org/show_bug.cgi?id=203464 Reviewed by Antti Koivisto. New results. Some tests that assumed that the selectors simply round-trip had to be fixed to supply test and expected selectors. * css3/parsing-css3-nthchild-expected.txt: * css3/parsing-css3-nthchild.html: * fast/css/css-selector-text-expected.txt: * fast/css/css-selector-text.html: * fast/css/css-set-selector-text-expected.txt: * fast/css/css-set-selector-text.html: * fast/css/parsing-css-matches-1-expected.txt: * fast/css/parsing-css-matches-1.html: * fast/css/parsing-css-matches-2-expected.txt: * fast/css/parsing-css-matches-2.html: * fast/css/parsing-css-matches-4-expected.txt: * fast/css/parsing-css-matches-4.html: * fast/css/parsing-css-not-1-expected.txt: * fast/css/parsing-css-not-1.html: * fast/css/parsing-css-not-2-expected.txt: * fast/css/parsing-css-not-2.html: * fast/css/parsing-css-not-4-expected.txt: * fast/css/parsing-css-not-4.html: * fast/css/parsing-css-nth-child-expected.txt: * fast/css/parsing-css-nth-child-of-1-expected.txt: * fast/css/parsing-css-nth-child-of-1.html: * fast/css/parsing-css-nth-child-of-2-expected.txt: * fast/css/parsing-css-nth-child-of-2.html: * fast/css/parsing-css-nth-child.html: * fast/css/parsing-css-nth-last-child-of-1-expected.txt: * fast/css/parsing-css-nth-last-child-of-1.html: * fast/css/parsing-css-nth-last-child-of-2-expected.txt: * fast/css/parsing-css-nth-last-child-of-2.html: * fast/dom/css-selectorText-expected.txt: Canonical link: https://commits.webkit.org/216874@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-10-28 04:49:52 +00:00
#h:nth-child(-n-10) { color: green; }
#n:nth-child(-n-1) { color: green; }
#o:nth-child(-n+13) { color: green; }
CSS3 Selectors failures on css3test.com https://bugs.webkit.org/show_bug.cgi?id=83885 Patch by Uday Kiran <udaykiran@motorola.com> on 2012-04-16 Reviewed by Zoltan Herczeg. Source/WebCore: Parsing fix for CSS3 selectors :nth-child(), :nth-last-child() :nth-of-type() :nth-last-of-type() with values -n-b and n-b as they are of valid form an+b where a and b are integers. http://www.w3.org/TR/selectors/#structural-pseudos Descriptors of form n-b or -n-b, where b is number, are valid CSS identifiers. However, in NthChildMode we need to check whether this identifier is a valid nth child descriptor. The original code only checked this if the string was n- or -n- but this is not enough. We need to check everything which starts with an n- or -n- prefix. Test: css3/parsing-css3-nthchild.html * css/CSSParser.cpp: (WebCore::CSSParser::lex): LayoutTests: * css3/parsing-css3-nthchild-expected.txt: Added. * css3/parsing-css3-nthchild.html: Added. Canonical link: https://commits.webkit.org/101536@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-04-16 15:36:24 +00:00