nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/css3/parse-align-items-expected.txt

13 lines
415 B
Plaintext
Raw Permalink Normal View History

[CSS Grid Layout] Upgrade align-self and align-items parsing to CSS 3 https://bugs.webkit.org/show_bug.cgi?id=133359 Reviewed by David Hyatt. From Blink r164817 and r165264 by <jchaffraix@chromium.org> Source/WebCore: Broaden justify-self's parsing name This is in preparation of migrating align-self, align-items and justify-items to the CSS 3 Alignment syntax. The current naming was too tied to justify-self and needs to be broadened. This will reduce the follow-up implementations' patches. Upgrade align-self and align-items parsing to CSS 3 This change migrates the 2 properties to the CSS 3 Alignment parsing. The new parsing is identical to how we parse 'justify-self'. The 2 properties need to be migrated together as they are used in tandem in CSSComputedStyleDeclaration. This change also removes EAlignItems as it is now unused. Tests: css3/parse-align-items.html css3/parse-align-self.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::resolveAlignmentAuto): Added. Resolves the "auto" value for the alignment properties. (WebCore::valueForItemPositionWithOverflowAlignment): Added. Builds the CSSValue for the for the alignment properties. (WebCore::ComputedStyleExtractor::propertyValue): * css/CSSParser.cpp: (WebCore::isValidKeywordPropertyAndValue): Removed align-self, align-items and justify-items. (WebCore::isKeywordPropertyID): Removed align-self, align-items and justify-items. (WebCore::isBaselinePositionKeyword): Added. Set of keywords related to baseline value. (WebCore::CSSParser::parseItemPositionOverflowPosition): Generic parsing fuction for the alignment properties. (WebCore::CSSParser::parseJustifySelf): Deleted. (WebCore::CSSParser::parseValue): Added align-items and align-self to the list and call to the generic parsing fuction for the alignment properties. * css/CSSParser.h: * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added. (WebCore::CSSPrimitiveValue::operator ItemPosition): Added. Replace the old EAlignItems enumeration. (WebCore::CSSPrimitiveValue::operator OverflowAlignment): Added. (WebCore::CSSPrimitiveValue::operator EAlignItems): Deleted. (WebCore::CSSPrimitiveValue::operator EJustifySelf): Deleted. (WebCore::CSSPrimitiveValue::operator EJustifySelfOverflowAlignment): Deleted. * css/CSSPropertyNames.in: * css/CSSValueKeywords.in: * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyInheritAlignSelf): Added. (WebCore::StyleBuilderCustom::applyInitialAlignSelf): Added. (WebCore::StyleBuilderCustom::applyValueAlignSelf): Added. (WebCore::StyleBuilderCustom::applyInheritAlignItems): Added. (WebCore::StyleBuilderCustom::applyInitialAlignItems): Added. (WebCore::StyleBuilderCustom::applyValueAlignItems): Added. (WebCore::StyleBuilderCustom::applyInheritJustifySelf): Added. (WebCore::StyleBuilderCustom::applyInitialJustifySelf): Added. (WebCore::StyleBuilderCustom::applyValueJustifySelf): Added. (WebCore::StyleBuilderCustom::applyValueWebkitJustifySelf): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::adjustRenderStyle): isDisplayFlexibleOrGridBox now a RenderStyle function. (WebCore::isDisplayFlexibleBox): Deleted. Moved to RenderStyle. (WebCore::isDisplayGridBox): Deleted. Moved to RenderStyle. (WebCore::isDisplayFlexibleOrGridBox): Deleted. Moved to RenderStyle. * rendering/RenderBox.cpp: (WebCore::flexItemHasStretchAlignment): Adapted to the new ItemPostition enum. * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::firstLineBaseline): Adapted to the new ItemPostition enum. (WebCore::RenderFlexibleBox::styleDidChange): Adapted to the new ItemPostition enum. (WebCore::RenderFlexibleBox::alignmentForChild): Adapted to the new ItemPostition enum. (WebCore::RenderFlexibleBox::needToStretchChild): Adapted to the new ItemPostition enum. (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Adapted to the new ItemPostition enum. (WebCore::RenderFlexibleBox::alignChildren): Adapted to the new ItemPostition enum. (WebCore::resolveAlignment): Deleted. Moved to RenderStyle. * rendering/RenderFlexibleBox.h: * rendering/RenderFullScreen.cpp: (WebCore::createFullScreenStyle): Adapted to the new ItemPostition enum. * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Adapted to the new ItemPostition enum. * rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::updateStyle): Adapted to the new ItemPostition enum. * rendering/mathml/RenderMathMLScripts.cpp: (WebCore::RenderMathMLScripts::fixAnonymousStyleForSubSupPair): Adapted to the new ItemPostition enum. (WebCore::RenderMathMLScripts::fixAnonymousStyles): Adapted to the new ItemPostition enum. * rendering/style/ContentData.h: * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::resolveAlignment): Added. * rendering/style/RenderStyle.h: Adapted to the new ItemPostition enum. * rendering/style/RenderStyleConstants.h: Adapted to the new ItemPostition enum. * rendering/style/StyleRareNonInheritedData.cpp: Adapted to the new ItemPostition enum. (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Adapted to the new ItemPostition enum. (WebCore::StyleRareNonInheritedData::operator==): Adapted to the new ItemPostition enum. * rendering/style/StyleRareNonInheritedData.h: Adapted to the new ItemPostition enum. * style/StyleResolveTree.cpp: (WebCore::Style::determineChange): Changes in the alignItems property cause a Detach. LayoutTests: Broaden justify-self's parsing name and upgrade align-self and align-items parsing to CSS 3. * TestExpectations: * css3/flexbox/css-properties-expected.txt: * css3/flexbox/css-properties.html: * css3/parse-align-items-expected.txt: Added. * css3/parse-align-items.html: Added. * css3/parse-align-self-expected.txt: Added. * css3/parse-align-self.html: Added. * css3/resources/alignment-parsing-utils.js: Added. (checkValues): (checkBadValues): (checkInitialValues): (checkInheritValues): (checkLegacyValues): * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * fast/css/getComputedStyle/resources/property-names.js: * fast/css/parse-justify-self-expected.txt: * fast/css/parse-justify-self.html: * svg/css/getComputedStyle-basic-expected.txt: Canonical link: https://commits.webkit.org/161247@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@182147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-03-30 18:33:39 +00:00
Test that setting and getting align-items works as expected
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS Test getting align-items set through CSS.
PASS Test initial value of align-items through JS
PASS Test getting and setting align-items through JS
PASS Test bad combinations of align-items
PASS Test the value 'initial'
PASS Test the value 'initial' for grid containers
PASS Test the value 'initial' for flex containers
PASS Test the value 'inherit'
[CSS Grid Layout] Upgrade align-self and align-items parsing to CSS 3 https://bugs.webkit.org/show_bug.cgi?id=133359 Reviewed by David Hyatt. From Blink r164817 and r165264 by <jchaffraix@chromium.org> Source/WebCore: Broaden justify-self's parsing name This is in preparation of migrating align-self, align-items and justify-items to the CSS 3 Alignment syntax. The current naming was too tied to justify-self and needs to be broadened. This will reduce the follow-up implementations' patches. Upgrade align-self and align-items parsing to CSS 3 This change migrates the 2 properties to the CSS 3 Alignment parsing. The new parsing is identical to how we parse 'justify-self'. The 2 properties need to be migrated together as they are used in tandem in CSSComputedStyleDeclaration. This change also removes EAlignItems as it is now unused. Tests: css3/parse-align-items.html css3/parse-align-self.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::resolveAlignmentAuto): Added. Resolves the "auto" value for the alignment properties. (WebCore::valueForItemPositionWithOverflowAlignment): Added. Builds the CSSValue for the for the alignment properties. (WebCore::ComputedStyleExtractor::propertyValue): * css/CSSParser.cpp: (WebCore::isValidKeywordPropertyAndValue): Removed align-self, align-items and justify-items. (WebCore::isKeywordPropertyID): Removed align-self, align-items and justify-items. (WebCore::isBaselinePositionKeyword): Added. Set of keywords related to baseline value. (WebCore::CSSParser::parseItemPositionOverflowPosition): Generic parsing fuction for the alignment properties. (WebCore::CSSParser::parseJustifySelf): Deleted. (WebCore::CSSParser::parseValue): Added align-items and align-self to the list and call to the generic parsing fuction for the alignment properties. * css/CSSParser.h: * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added. (WebCore::CSSPrimitiveValue::operator ItemPosition): Added. Replace the old EAlignItems enumeration. (WebCore::CSSPrimitiveValue::operator OverflowAlignment): Added. (WebCore::CSSPrimitiveValue::operator EAlignItems): Deleted. (WebCore::CSSPrimitiveValue::operator EJustifySelf): Deleted. (WebCore::CSSPrimitiveValue::operator EJustifySelfOverflowAlignment): Deleted. * css/CSSPropertyNames.in: * css/CSSValueKeywords.in: * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyInheritAlignSelf): Added. (WebCore::StyleBuilderCustom::applyInitialAlignSelf): Added. (WebCore::StyleBuilderCustom::applyValueAlignSelf): Added. (WebCore::StyleBuilderCustom::applyInheritAlignItems): Added. (WebCore::StyleBuilderCustom::applyInitialAlignItems): Added. (WebCore::StyleBuilderCustom::applyValueAlignItems): Added. (WebCore::StyleBuilderCustom::applyInheritJustifySelf): Added. (WebCore::StyleBuilderCustom::applyInitialJustifySelf): Added. (WebCore::StyleBuilderCustom::applyValueJustifySelf): Added. (WebCore::StyleBuilderCustom::applyValueWebkitJustifySelf): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::adjustRenderStyle): isDisplayFlexibleOrGridBox now a RenderStyle function. (WebCore::isDisplayFlexibleBox): Deleted. Moved to RenderStyle. (WebCore::isDisplayGridBox): Deleted. Moved to RenderStyle. (WebCore::isDisplayFlexibleOrGridBox): Deleted. Moved to RenderStyle. * rendering/RenderBox.cpp: (WebCore::flexItemHasStretchAlignment): Adapted to the new ItemPostition enum. * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::firstLineBaseline): Adapted to the new ItemPostition enum. (WebCore::RenderFlexibleBox::styleDidChange): Adapted to the new ItemPostition enum. (WebCore::RenderFlexibleBox::alignmentForChild): Adapted to the new ItemPostition enum. (WebCore::RenderFlexibleBox::needToStretchChild): Adapted to the new ItemPostition enum. (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Adapted to the new ItemPostition enum. (WebCore::RenderFlexibleBox::alignChildren): Adapted to the new ItemPostition enum. (WebCore::resolveAlignment): Deleted. Moved to RenderStyle. * rendering/RenderFlexibleBox.h: * rendering/RenderFullScreen.cpp: (WebCore::createFullScreenStyle): Adapted to the new ItemPostition enum. * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Adapted to the new ItemPostition enum. * rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::updateStyle): Adapted to the new ItemPostition enum. * rendering/mathml/RenderMathMLScripts.cpp: (WebCore::RenderMathMLScripts::fixAnonymousStyleForSubSupPair): Adapted to the new ItemPostition enum. (WebCore::RenderMathMLScripts::fixAnonymousStyles): Adapted to the new ItemPostition enum. * rendering/style/ContentData.h: * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::resolveAlignment): Added. * rendering/style/RenderStyle.h: Adapted to the new ItemPostition enum. * rendering/style/RenderStyleConstants.h: Adapted to the new ItemPostition enum. * rendering/style/StyleRareNonInheritedData.cpp: Adapted to the new ItemPostition enum. (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Adapted to the new ItemPostition enum. (WebCore::StyleRareNonInheritedData::operator==): Adapted to the new ItemPostition enum. * rendering/style/StyleRareNonInheritedData.h: Adapted to the new ItemPostition enum. * style/StyleResolveTree.cpp: (WebCore::Style::determineChange): Changes in the alignItems property cause a Detach. LayoutTests: Broaden justify-self's parsing name and upgrade align-self and align-items parsing to CSS 3. * TestExpectations: * css3/flexbox/css-properties-expected.txt: * css3/flexbox/css-properties.html: * css3/parse-align-items-expected.txt: Added. * css3/parse-align-items.html: Added. * css3/parse-align-self-expected.txt: Added. * css3/parse-align-self.html: Added. * css3/resources/alignment-parsing-utils.js: Added. (checkValues): (checkBadValues): (checkInitialValues): (checkInheritValues): (checkLegacyValues): * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * fast/css/getComputedStyle/resources/property-names.js: * fast/css/parse-justify-self-expected.txt: * fast/css/parse-justify-self.html: * svg/css/getComputedStyle-basic-expected.txt: Canonical link: https://commits.webkit.org/161247@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@182147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-03-30 18:33:39 +00:00