nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/css3/parse-align-content-expecte...

14 lines
506 B
Plaintext
Raw Permalink Normal View History

[CSS Box Alignment] Upgrade align-content parsing to CSS3 Box Alignment spec https://bugs.webkit.org/show_bug.cgi?id=144443 Reviewed by Darin Adler. Source/WebCore: Upgrade the align-content property to the last CSS3 Box Alignment specification. As it uses a different enumeration for Positional and Distribution alignment, it implies some changes in the FlexibleBox implementation. Test: css3/parse-align-content.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::resolveContentAlignmentAuto): (WebCore::ComputedStyleExtractor::propertyValue): * css/CSSParser.cpp: (WebCore::isValidKeywordPropertyAndValue): (WebCore::isKeywordPropertyID): (WebCore::CSSParser::parseValue): * css/CSSPropertyNames.in: * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): (WebCore::RenderFlexibleBox::layoutColumnReverse): (WebCore::initialAlignContentOffset): (WebCore::alignContentSpaceBetweenChildren): (WebCore::RenderFlexibleBox::alignFlexLines): * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::resolveContentAlignment): (WebCore::RenderStyle::resolveContentJustification): * rendering/style/RenderStyle.h: * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): * rendering/style/StyleRareNonInheritedData.h: LayoutTests: Tests to verify the align-content parsing logic. The new Box Alignment spec requires some changes in the flexbox tests. * css3/flexbox/css-properties-expected.txt: * css3/flexbox/css-properties.html: * css3/parse-align-content-expected.txt: Added. * css3/parse-align-content.html: Added. Canonical link: https://commits.webkit.org/162640@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@183805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-05-05 15:15:38 +00:00
Test that setting and getting align-content works as expected
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS Test getting align-content values previously set through CSS.
PASS Test setting invalid values to align-content through CSS.
PASS Test initial value of align-content through JS
PASS Test getting and setting align-content through JS
PASS Test bad combinations of align-content
PASS Test the value 'initial'
PASS Test the value 'initial' for grid containers
PASS Test the value 'initial' for flex containers
PASS Test the value 'inherit'
[CSS Box Alignment] Upgrade align-content parsing to CSS3 Box Alignment spec https://bugs.webkit.org/show_bug.cgi?id=144443 Reviewed by Darin Adler. Source/WebCore: Upgrade the align-content property to the last CSS3 Box Alignment specification. As it uses a different enumeration for Positional and Distribution alignment, it implies some changes in the FlexibleBox implementation. Test: css3/parse-align-content.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::resolveContentAlignmentAuto): (WebCore::ComputedStyleExtractor::propertyValue): * css/CSSParser.cpp: (WebCore::isValidKeywordPropertyAndValue): (WebCore::isKeywordPropertyID): (WebCore::CSSParser::parseValue): * css/CSSPropertyNames.in: * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): (WebCore::RenderFlexibleBox::layoutColumnReverse): (WebCore::initialAlignContentOffset): (WebCore::alignContentSpaceBetweenChildren): (WebCore::RenderFlexibleBox::alignFlexLines): * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::resolveContentAlignment): (WebCore::RenderStyle::resolveContentJustification): * rendering/style/RenderStyle.h: * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): * rendering/style/StyleRareNonInheritedData.h: LayoutTests: Tests to verify the align-content parsing logic. The new Box Alignment spec requires some changes in the flexbox tests. * css3/flexbox/css-properties-expected.txt: * css3/flexbox/css-properties.html: * css3/parse-align-content-expected.txt: Added. * css3/parse-align-content.html: Added. Canonical link: https://commits.webkit.org/162640@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@183805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-05-05 15:15:38 +00:00