nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/css3/flexbox/flex-align-baseline-expecte...

57 lines
1.9 KiB
Plaintext
Raw Permalink Normal View History

Source/JavaScriptCore: Replace old strtod with new strtod https://bugs.webkit.org/show_bug.cgi?id=68044 Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2012-02-12 Reviewed by Geoffrey Garen. * parser/Lexer.cpp: Added template argument. This version allows junk after numbers. (JSC::::lex): * runtime/JSGlobalObjectFunctions.cpp: Ditto. (JSC::parseInt): (JSC::jsStrDecimalLiteral): * runtime/LiteralParser.cpp: Ditto. (JSC::::Lexer::lexNumber): * wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter. It takes a template argument to allow clients to determine statically whether it should allow junk after the numbers or not. (WTF): (WTF::strtod): * wtf/dtoa.h: (WTF): * wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers. (WTF::toDoubleType): Source/WebCore: rtl + flex-direction:column is positioning elements incorrectly https://bugs.webkit.org/show_bug.cgi?id=78555 Reviewed by Tony Chang. Do the y-axis flipping after we have adjusted the y-position for flex-align instead of before. Tests: css3/flexbox/flex-align-baseline.html css3/flexbox/flex-align-end.html * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::alignChildren): The amount we adjust by also needs to be flipped for rtl+column, so the flipping needs to be done after we align the flex items. LayoutTests: rtl + flex-direction:column is positioning elements incorrectly https://bugs.webkit.org/show_bug.cgi?id=78555 Reviewed by Tony Chang. * css3/flexbox/flex-align-baseline-expected.txt: Added. * css3/flexbox/flex-align-baseline.html: Added. * css3/flexbox/flex-align-end-expected.txt: Added. * css3/flexbox/flex-align-end.html: Added. * css3/flexbox/true-centering-expected.txt: Canonical link: https://commits.webkit.org/95506@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-02-14 02:40:45 +00:00
PASS firstChild.offsetTop is lastChild.offsetTop
PASS firstChild.offsetTop is lastChild.offsetTop
PASS firstChild.offsetLeft is lastChild.offsetLeft
PASS firstChild.offsetLeft is lastChild.offsetLeft
PASS firstChild.offsetTop is lastChild.offsetTop
PASS firstChild.offsetTop is lastChild.offsetTop
PASS firstChild.offsetLeft is lastChild.offsetLeft
PASS firstChild.offsetLeft is lastChild.offsetLeft
PASS firstChild.offsetLeft is lastChild.offsetLeft
PASS firstChild.offsetLeft is lastChild.offsetLeft
flexbox does wrong baseline item alignment in columns https://bugs.webkit.org/show_bug.cgi?id=97948 Reviewed by Ojan Vafai. Source/WebCore: For columns, baseline alignment should just be flex-start. We were previously moving the logical left edge by the ascent. Test: css3/flexbox/align-baseline.html * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::alignmentForChild): Map baseline to flex-start for orthogonal children. (WebCore::RenderFlexibleBox::alignChildren): Add FIXME for bug in baseline alignment. * rendering/RenderFlexibleBox.h: LayoutTests: Update test cases with new baseline alignment for column. * css3/flexbox/align-baseline-expected.html: Added. * css3/flexbox/align-baseline.html: Added. * css3/flexbox/flex-align-baseline-expected.txt: * css3/flexbox/flex-align-baseline.html: * css3/flexbox/multiline-align-self.html: Canonical link: https://commits.webkit.org/116111@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-10-02 01:51:22 +00:00
PASS firstChild.offsetTop is 0
PASS lastChild.offsetTop is 20
Source/JavaScriptCore: Replace old strtod with new strtod https://bugs.webkit.org/show_bug.cgi?id=68044 Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2012-02-12 Reviewed by Geoffrey Garen. * parser/Lexer.cpp: Added template argument. This version allows junk after numbers. (JSC::::lex): * runtime/JSGlobalObjectFunctions.cpp: Ditto. (JSC::parseInt): (JSC::jsStrDecimalLiteral): * runtime/LiteralParser.cpp: Ditto. (JSC::::Lexer::lexNumber): * wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter. It takes a template argument to allow clients to determine statically whether it should allow junk after the numbers or not. (WTF): (WTF::strtod): * wtf/dtoa.h: (WTF): * wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers. (WTF::toDoubleType): Source/WebCore: rtl + flex-direction:column is positioning elements incorrectly https://bugs.webkit.org/show_bug.cgi?id=78555 Reviewed by Tony Chang. Do the y-axis flipping after we have adjusted the y-position for flex-align instead of before. Tests: css3/flexbox/flex-align-baseline.html css3/flexbox/flex-align-end.html * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::alignChildren): The amount we adjust by also needs to be flipped for rtl+column, so the flipping needs to be done after we align the flex items. LayoutTests: rtl + flex-direction:column is positioning elements incorrectly https://bugs.webkit.org/show_bug.cgi?id=78555 Reviewed by Tony Chang. * css3/flexbox/flex-align-baseline-expected.txt: Added. * css3/flexbox/flex-align-baseline.html: Added. * css3/flexbox/flex-align-end-expected.txt: Added. * css3/flexbox/flex-align-end.html: Added. * css3/flexbox/true-centering-expected.txt: Canonical link: https://commits.webkit.org/95506@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-02-14 02:40:45 +00:00
PASS firstChild.offsetTop is lastChild.offsetTop
PASS firstChild.offsetLeft is lastChild.offsetLeft
PASS firstChild.offsetLeft is lastChild.offsetLeft
flexbox does wrong baseline item alignment in columns https://bugs.webkit.org/show_bug.cgi?id=97948 Reviewed by Ojan Vafai. Source/WebCore: For columns, baseline alignment should just be flex-start. We were previously moving the logical left edge by the ascent. Test: css3/flexbox/align-baseline.html * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::alignmentForChild): Map baseline to flex-start for orthogonal children. (WebCore::RenderFlexibleBox::alignChildren): Add FIXME for bug in baseline alignment. * rendering/RenderFlexibleBox.h: LayoutTests: Update test cases with new baseline alignment for column. * css3/flexbox/align-baseline-expected.html: Added. * css3/flexbox/align-baseline.html: Added. * css3/flexbox/flex-align-baseline-expected.txt: * css3/flexbox/flex-align-baseline.html: * css3/flexbox/multiline-align-self.html: Canonical link: https://commits.webkit.org/116111@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-10-02 01:51:22 +00:00
PASS firstChild.offsetTop is 0
PASS lastChild.offsetTop is 20
Source/JavaScriptCore: Replace old strtod with new strtod https://bugs.webkit.org/show_bug.cgi?id=68044 Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2012-02-12 Reviewed by Geoffrey Garen. * parser/Lexer.cpp: Added template argument. This version allows junk after numbers. (JSC::::lex): * runtime/JSGlobalObjectFunctions.cpp: Ditto. (JSC::parseInt): (JSC::jsStrDecimalLiteral): * runtime/LiteralParser.cpp: Ditto. (JSC::::Lexer::lexNumber): * wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter. It takes a template argument to allow clients to determine statically whether it should allow junk after the numbers or not. (WTF): (WTF::strtod): * wtf/dtoa.h: (WTF): * wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers. (WTF::toDoubleType): Source/WebCore: rtl + flex-direction:column is positioning elements incorrectly https://bugs.webkit.org/show_bug.cgi?id=78555 Reviewed by Tony Chang. Do the y-axis flipping after we have adjusted the y-position for flex-align instead of before. Tests: css3/flexbox/flex-align-baseline.html css3/flexbox/flex-align-end.html * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::alignChildren): The amount we adjust by also needs to be flipped for rtl+column, so the flipping needs to be done after we align the flex items. LayoutTests: rtl + flex-direction:column is positioning elements incorrectly https://bugs.webkit.org/show_bug.cgi?id=78555 Reviewed by Tony Chang. * css3/flexbox/flex-align-baseline-expected.txt: Added. * css3/flexbox/flex-align-baseline.html: Added. * css3/flexbox/flex-align-end-expected.txt: Added. * css3/flexbox/flex-align-end.html: Added. * css3/flexbox/true-centering-expected.txt: Canonical link: https://commits.webkit.org/95506@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-02-14 02:40:45 +00:00
PASS firstChild.offsetTop is lastChild.offsetTop
PASS firstChild.offsetLeft is lastChild.offsetLeft
PASS firstChild.offsetLeft is lastChild.offsetLeft
flexbox does wrong baseline item alignment in columns https://bugs.webkit.org/show_bug.cgi?id=97948 Reviewed by Ojan Vafai. Source/WebCore: For columns, baseline alignment should just be flex-start. We were previously moving the logical left edge by the ascent. Test: css3/flexbox/align-baseline.html * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::alignmentForChild): Map baseline to flex-start for orthogonal children. (WebCore::RenderFlexibleBox::alignChildren): Add FIXME for bug in baseline alignment. * rendering/RenderFlexibleBox.h: LayoutTests: Update test cases with new baseline alignment for column. * css3/flexbox/align-baseline-expected.html: Added. * css3/flexbox/align-baseline.html: Added. * css3/flexbox/flex-align-baseline-expected.txt: * css3/flexbox/flex-align-baseline.html: * css3/flexbox/multiline-align-self.html: Canonical link: https://commits.webkit.org/116111@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-10-02 01:51:22 +00:00
PASS firstChild.offsetTop is 0
PASS lastChild.offsetTop is 20
Source/JavaScriptCore: Replace old strtod with new strtod https://bugs.webkit.org/show_bug.cgi?id=68044 Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2012-02-12 Reviewed by Geoffrey Garen. * parser/Lexer.cpp: Added template argument. This version allows junk after numbers. (JSC::::lex): * runtime/JSGlobalObjectFunctions.cpp: Ditto. (JSC::parseInt): (JSC::jsStrDecimalLiteral): * runtime/LiteralParser.cpp: Ditto. (JSC::::Lexer::lexNumber): * wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter. It takes a template argument to allow clients to determine statically whether it should allow junk after the numbers or not. (WTF): (WTF::strtod): * wtf/dtoa.h: (WTF): * wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers. (WTF::toDoubleType): Source/WebCore: rtl + flex-direction:column is positioning elements incorrectly https://bugs.webkit.org/show_bug.cgi?id=78555 Reviewed by Tony Chang. Do the y-axis flipping after we have adjusted the y-position for flex-align instead of before. Tests: css3/flexbox/flex-align-baseline.html css3/flexbox/flex-align-end.html * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::alignChildren): The amount we adjust by also needs to be flipped for rtl+column, so the flipping needs to be done after we align the flex items. LayoutTests: rtl + flex-direction:column is positioning elements incorrectly https://bugs.webkit.org/show_bug.cgi?id=78555 Reviewed by Tony Chang. * css3/flexbox/flex-align-baseline-expected.txt: Added. * css3/flexbox/flex-align-baseline.html: Added. * css3/flexbox/flex-align-end-expected.txt: Added. * css3/flexbox/flex-align-end.html: Added. * css3/flexbox/true-centering-expected.txt: Canonical link: https://commits.webkit.org/95506@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-02-14 02:40:45 +00:00
PASS firstChild.offsetTop is lastChild.offsetTop
PASS firstChild.offsetLeft is lastChild.offsetLeft
PASS firstChild.offsetLeft is lastChild.offsetLeft
flexbox does wrong baseline item alignment in columns https://bugs.webkit.org/show_bug.cgi?id=97948 Reviewed by Ojan Vafai. Source/WebCore: For columns, baseline alignment should just be flex-start. We were previously moving the logical left edge by the ascent. Test: css3/flexbox/align-baseline.html * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::alignmentForChild): Map baseline to flex-start for orthogonal children. (WebCore::RenderFlexibleBox::alignChildren): Add FIXME for bug in baseline alignment. * rendering/RenderFlexibleBox.h: LayoutTests: Update test cases with new baseline alignment for column. * css3/flexbox/align-baseline-expected.html: Added. * css3/flexbox/align-baseline.html: Added. * css3/flexbox/flex-align-baseline-expected.txt: * css3/flexbox/flex-align-baseline.html: * css3/flexbox/multiline-align-self.html: Canonical link: https://commits.webkit.org/116111@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-10-02 01:51:22 +00:00
PASS firstChild.offsetTop is 0
PASS lastChild.offsetTop is 20
Source/JavaScriptCore: Replace old strtod with new strtod https://bugs.webkit.org/show_bug.cgi?id=68044 Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2012-02-12 Reviewed by Geoffrey Garen. * parser/Lexer.cpp: Added template argument. This version allows junk after numbers. (JSC::::lex): * runtime/JSGlobalObjectFunctions.cpp: Ditto. (JSC::parseInt): (JSC::jsStrDecimalLiteral): * runtime/LiteralParser.cpp: Ditto. (JSC::::Lexer::lexNumber): * wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter. It takes a template argument to allow clients to determine statically whether it should allow junk after the numbers or not. (WTF): (WTF::strtod): * wtf/dtoa.h: (WTF): * wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers. (WTF::toDoubleType): Source/WebCore: rtl + flex-direction:column is positioning elements incorrectly https://bugs.webkit.org/show_bug.cgi?id=78555 Reviewed by Tony Chang. Do the y-axis flipping after we have adjusted the y-position for flex-align instead of before. Tests: css3/flexbox/flex-align-baseline.html css3/flexbox/flex-align-end.html * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::alignChildren): The amount we adjust by also needs to be flipped for rtl+column, so the flipping needs to be done after we align the flex items. LayoutTests: rtl + flex-direction:column is positioning elements incorrectly https://bugs.webkit.org/show_bug.cgi?id=78555 Reviewed by Tony Chang. * css3/flexbox/flex-align-baseline-expected.txt: Added. * css3/flexbox/flex-align-baseline.html: Added. * css3/flexbox/flex-align-end-expected.txt: Added. * css3/flexbox/flex-align-end.html: Added. * css3/flexbox/true-centering-expected.txt: Canonical link: https://commits.webkit.org/95506@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-02-14 02:40:45 +00:00
PASS firstChild.offsetTop is lastChild.offsetTop
PASS successfullyParsed is true
TEST COMPLETE
horizontal-tb ltr row
horizontal-tb rtl row
horizontal-tb ltr column
horizontal-tb rtl column
horizontal-tb ltr row-reverse
horizontal-tb rtl row-reverse
horizontal-tb ltr column-reverse
horizontal-tb rtl column-reverse
vertical-lr ltr row
vertical-lr rtl row
vertical-lr ltr column
vertical-lr rtl column
vertical-lr ltr row-reverse
vertical-lr rtl row-reverse
vertical-lr ltr column-reverse
vertical-lr rtl column-reverse
vertical-rl ltr row
vertical-rl rtl row
vertical-rl ltr column
vertical-rl rtl column
vertical-rl ltr row-reverse
vertical-rl rtl row-reverse
vertical-rl ltr column-reverse
vertical-rl rtl column-reverse