nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/css3/filters/effect-contrast-expected.txt

28 lines
1.0 KiB
Plaintext
Raw Permalink Normal View History

Filters need to affect visual overflow https://bugs.webkit.org/show_bug.cgi?id=71930 Source/WebCore: Reviewed by Simon Fraser. Make sure filters are included in visual overflow. Add a new method to calculate the expansion of overflow region given a list of FilterOperations. This is a slight duplication of code from the rendering path, but is needed because overflow is calculated before the FilterEffect chain is built. Also, filters were always rendered into their input rectangle which was wrong for any effect that produced a different sized result - drop-shadow and blur. This required two changes. First, FilterEffect needed a flag to decide whether or not to clip output to primitive regions (as required by SVG but not what we want here). Second, the rendering operation draws into the rectangle the filter claims is its painting rectangle. Test: css3/filters/regions-expanding.html * platform/graphics/filters/FEDropShadow.cpp: (WebCore::FEDropShadow::determineAbsolutePaintRect): Only clipToBounds if necessary. * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::calculateUnscaledKernelSize): CSS filters ask for the kernel size before the Filter object is created, so add a new method to return an unscaled kernel. (WebCore::FEGaussianBlur::calculateKernelSize): (WebCore::FEGaussianBlur::determineAbsolutePaintRect): Only clipToBounds if necessary. * platform/graphics/filters/FEGaussianBlur.h: * platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::determineAbsolutePaintRect): Only clipToBounds if necessary. * platform/graphics/filters/FEOffset.cpp: (WebCore::FEOffset::determineAbsolutePaintRect): Only clipToBounds if necessary. * platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect): Initialize clipToBounds as false so SVG remains unchanged. (WebCore::FilterEffect::determineAbsolutePaintRect): Only clipToBounds if necessary. * platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::clipsToBounds): (WebCore::FilterEffect::setClipsToBounds): * rendering/FilterEffectRenderer.cpp: (WebCore::FilterEffectRenderer::build): Make sure we set our filters here to NOT clip to bounds. * rendering/FilterEffectRenderer.h: (WebCore::FilterEffectRenderer::outputRect): Asks the filter operation for the size of the result image. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::computeOverflow): * rendering/RenderBox.cpp: (WebCore::RenderBox::addVisualEffectOverflow): Change the name from addBoxShadowAndBorderOverflow(). * rendering/RenderBox.h: * rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::layout): * rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::layout): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): * rendering/RenderLayerBacking.cpp: (WebCore::hasBoxDecorations): Change name from hasBorderOutlineOrShadow(). (WebCore::hasBoxDecorationsOrBackground): (WebCore::hasBoxDecorationsOrBackgroundImage): * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout): * rendering/style/FilterOperations.cpp: (WebCore::outsetSizeForBlur): Return an IntSize that is the amount of offset. (WebCore::FilterOperations::hasOutsets): (WebCore::FilterOperations::getOutsets): * rendering/style/FilterOperations.h: * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::getFilterOutsets): (WebCore::InheritedFlags::hasFilterOutsets): * svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::determineAbsolutePaintRect): Only clipToBounds if necessary. LayoutTests: Previously, filters that expanded their input region (drop-shadow and blur) were being squished when rendered back into the document. This is now fixed, so the expected.png images from tests including such filters needed updating. I also turned off dumpAsText() in order to enable pixel tests, and added some margin between the elements in effects which have overflow (so that blurs don't overlap, for example). There is one new test which exercises the case of expanding filters at various stages in a list of operations. Reviewed by Simon Fraser. * css3/filters/crash-filter-change-expected.png: * css3/filters/effect-blur-expected.png: * css3/filters/effect-blur-expected.txt: * css3/filters/effect-blur.html: * css3/filters/effect-combined-expected.png: * css3/filters/effect-combined-expected.txt: * css3/filters/effect-combined.html: * css3/filters/effect-drop-shadow-expected.png: * css3/filters/effect-drop-shadow-expected.txt: * css3/filters/effect-drop-shadow.html: * css3/filters/effect-gamma-expected.txt: * css3/filters/effect-gamma.html: * css3/filters/effect-grayscale-expected.txt: * css3/filters/effect-grayscale.html: * css3/filters/effect-hue-rotate-expected.txt: * css3/filters/effect-hue-rotate.html: * css3/filters/effect-invert-expected.png: * css3/filters/effect-invert-expected.txt: * css3/filters/effect-invert.html: * css3/filters/effect-opacity-expected.txt: * css3/filters/effect-opacity.html: * css3/filters/effect-saturate-expected.txt: * css3/filters/effect-saturate.html: * css3/filters/effect-sepia-expected.txt: * css3/filters/effect-sepia.html: * css3/filters/regions-expanding-expected.png: Added. * css3/filters/regions-expanding-expected.txt: Added. * css3/filters/regions-expanding.html: Added. Canonical link: https://commits.webkit.org/91440@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-12-16 18:01:09 +00:00
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderText {#text} at (160,76) size 4x18
text run at (160,76) width 4: " "
RenderText {#text} at (324,76) size 4x18
text run at (324,76) width 4: " "
RenderText {#text} at (488,76) size 4x18
text run at (488,76) width 4: " "
[LFC][Integration] Enable inline image support https://bugs.webkit.org/show_bug.cgi?id=217874 Source/WebCore: Reviewed by Antti Koivisto. * layout/integration/LayoutIntegrationCoverage.cpp: LayoutTests: Combination of different issues: 1. Do not retain the whitespace (new line) after the replaced content. 2. Do not treat images+text as unbreakable content (neither FF nor Chrome does) 3. Rounding differences. Reviewed by Antti Koivisto. Canonical link: https://commits.webkit.org/231391@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-11-09 21:41:43 +00:00
RenderText {#text} at (0,0) size 0x0
Filters need to affect visual overflow https://bugs.webkit.org/show_bug.cgi?id=71930 Source/WebCore: Reviewed by Simon Fraser. Make sure filters are included in visual overflow. Add a new method to calculate the expansion of overflow region given a list of FilterOperations. This is a slight duplication of code from the rendering path, but is needed because overflow is calculated before the FilterEffect chain is built. Also, filters were always rendered into their input rectangle which was wrong for any effect that produced a different sized result - drop-shadow and blur. This required two changes. First, FilterEffect needed a flag to decide whether or not to clip output to primitive regions (as required by SVG but not what we want here). Second, the rendering operation draws into the rectangle the filter claims is its painting rectangle. Test: css3/filters/regions-expanding.html * platform/graphics/filters/FEDropShadow.cpp: (WebCore::FEDropShadow::determineAbsolutePaintRect): Only clipToBounds if necessary. * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::calculateUnscaledKernelSize): CSS filters ask for the kernel size before the Filter object is created, so add a new method to return an unscaled kernel. (WebCore::FEGaussianBlur::calculateKernelSize): (WebCore::FEGaussianBlur::determineAbsolutePaintRect): Only clipToBounds if necessary. * platform/graphics/filters/FEGaussianBlur.h: * platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::determineAbsolutePaintRect): Only clipToBounds if necessary. * platform/graphics/filters/FEOffset.cpp: (WebCore::FEOffset::determineAbsolutePaintRect): Only clipToBounds if necessary. * platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect): Initialize clipToBounds as false so SVG remains unchanged. (WebCore::FilterEffect::determineAbsolutePaintRect): Only clipToBounds if necessary. * platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::clipsToBounds): (WebCore::FilterEffect::setClipsToBounds): * rendering/FilterEffectRenderer.cpp: (WebCore::FilterEffectRenderer::build): Make sure we set our filters here to NOT clip to bounds. * rendering/FilterEffectRenderer.h: (WebCore::FilterEffectRenderer::outputRect): Asks the filter operation for the size of the result image. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::computeOverflow): * rendering/RenderBox.cpp: (WebCore::RenderBox::addVisualEffectOverflow): Change the name from addBoxShadowAndBorderOverflow(). * rendering/RenderBox.h: * rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::layout): * rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::layout): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): * rendering/RenderLayerBacking.cpp: (WebCore::hasBoxDecorations): Change name from hasBorderOutlineOrShadow(). (WebCore::hasBoxDecorationsOrBackground): (WebCore::hasBoxDecorationsOrBackgroundImage): * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout): * rendering/style/FilterOperations.cpp: (WebCore::outsetSizeForBlur): Return an IntSize that is the amount of offset. (WebCore::FilterOperations::hasOutsets): (WebCore::FilterOperations::getOutsets): * rendering/style/FilterOperations.h: * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::getFilterOutsets): (WebCore::InheritedFlags::hasFilterOutsets): * svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::determineAbsolutePaintRect): Only clipToBounds if necessary. LayoutTests: Previously, filters that expanded their input region (drop-shadow and blur) were being squished when rendered back into the document. This is now fixed, so the expected.png images from tests including such filters needed updating. I also turned off dumpAsText() in order to enable pixel tests, and added some margin between the elements in effects which have overflow (so that blurs don't overlap, for example). There is one new test which exercises the case of expanding filters at various stages in a list of operations. Reviewed by Simon Fraser. * css3/filters/crash-filter-change-expected.png: * css3/filters/effect-blur-expected.png: * css3/filters/effect-blur-expected.txt: * css3/filters/effect-blur.html: * css3/filters/effect-combined-expected.png: * css3/filters/effect-combined-expected.txt: * css3/filters/effect-combined.html: * css3/filters/effect-drop-shadow-expected.png: * css3/filters/effect-drop-shadow-expected.txt: * css3/filters/effect-drop-shadow.html: * css3/filters/effect-gamma-expected.txt: * css3/filters/effect-gamma.html: * css3/filters/effect-grayscale-expected.txt: * css3/filters/effect-grayscale.html: * css3/filters/effect-hue-rotate-expected.txt: * css3/filters/effect-hue-rotate.html: * css3/filters/effect-invert-expected.png: * css3/filters/effect-invert-expected.txt: * css3/filters/effect-invert.html: * css3/filters/effect-opacity-expected.txt: * css3/filters/effect-opacity.html: * css3/filters/effect-saturate-expected.txt: * css3/filters/effect-saturate.html: * css3/filters/effect-sepia-expected.txt: * css3/filters/effect-sepia.html: * css3/filters/regions-expanding-expected.png: Added. * css3/filters/regions-expanding-expected.txt: Added. * css3/filters/regions-expanding.html: Added. Canonical link: https://commits.webkit.org/91440@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-12-16 18:01:09 +00:00
RenderText {#text} at (160,170) size 4x18
text run at (160,170) width 4: " "
RenderText {#text} at (0,0) size 0x0
layer at (8,8) size 160x90
RenderImage {IMG} at (0,0) size 160x90
layer at (172,8) size 160x90
RenderImage {IMG} at (164,0) size 160x90
layer at (336,8) size 160x90
RenderImage {IMG} at (328,0) size 160x90
layer at (500,8) size 160x90
RenderImage {IMG} at (492,0) size 160x90
layer at (8,102) size 160x90
RenderImage {IMG} at (0,94) size 160x90
layer at (172,102) size 160x90
RenderImage {IMG} at (164,94) size 160x90