nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/css3/filters/composited-reflected-expect...

2 lines
1 B
Raw Permalink Normal View History

Fix issues with filters and reflections https://bugs.webkit.org/show_bug.cgi?id=100308 Reviewed by Dirk Schulze. Source/WebCore: Composited filters were being applied to the wrong CALayer. The code used primaryLayer(), which may be a CATransformLayer (which filters cannot apply to; doing so causes console spew), or a CALayer that is used for reflection flattening, which again is the wrong layer. Test: css3/filters/composited-reflected.html * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateContentsVisibility): Replace .get()-> with -> (WebCore::GraphicsLayerCA::updateContentsOpaque): Ditto. (WebCore::GraphicsLayerCA::updateFilters): Apply filters to m_layer, not primaryLayer(), and use m_layerClones, not primaryLayerClones(). (WebCore::GraphicsLayerCA::cloneLayer): When cloning a layer for reflections, copy filters from the source layer. * platform/graphics/ca/PlatformCALayer.h: (PlatformCALayer): Add a member function to copy filters from a supplied layer. * platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::setFilters): Remove blank line. (PlatformCALayer::copyFiltersFrom): Copy CAFIlters from the given layer. * platform/graphics/ca/win/PlatformCALayerWin.cpp: (PlatformCALayer::copyFiltersFrom): Stub; no filters on Windows. LayoutTests: Test composited filters inside a nested reflection. * css3/filters/composited-reflected-expected.png: Added. * css3/filters/composited-reflected-expected.txt: Added. * css3/filters/composited-reflected.html: Added. * platform/mac/css3/filters/composited-reflected-expected.png: Added. Canonical link: https://commits.webkit.org/118861@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-10-31 05:03:52 +00:00