haikuwebkit/LayoutTests/css-dark-mode/older-systems/color-scheme-meta.html

77 lines
2.2 KiB
HTML
Raw Permalink Normal View History

Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
<!DOCTYPE html>
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<style>
#test1 {
color: text;
}
</style>
Rename `supported-color-schemes` to `color-scheme`. https://bugs.webkit.org/show_bug.cgi?id=197016 rdar://problem/49980259 Reviewed by Simon Fraser. Source/WebCore: Changed `supported-color-schemes` to `color-scheme` to follow the spec changes being tracked by: https://github.com/w3c/csswg-drafts/issues/3807 The old `supported-color-schemes` is now an alias of `color-scheme` for compatibility. Tests: css-dark-mode/color-scheme-css-parse.html css-dark-mode/color-scheme-css.html css-dark-mode/color-scheme-meta.html css-dark-mode/color-scheme-priority.html css-dark-mode/color-scheme-scrollbar.html css-dark-mode/older-syntax/supported-color-schemes-css.html css-dark-mode/older-syntax/supported-color-schemes-meta.html css-dark-mode/older-systems/color-scheme-css.html css-dark-mode/older-systems/color-scheme-meta.html * WebCore.xcodeproj/project.pbxproj: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::updateColorScheme): (WebCore::StyleBuilderConverter::convertColorScheme): (WebCore::StyleBuilderConverter::updateSupportedColorSchemes): Deleted. (WebCore::StyleBuilderConverter::convertSupportedColorSchemes): Deleted. * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueColorScheme): (WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::applyMatchedProperties): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeColorScheme): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::consumeSupportedColorSchemes): Deleted. * dom/Document.cpp: (WebCore::processColorSchemeString): (WebCore::Document::processColorScheme): (WebCore::Document::useDarkAppearance const): (WebCore::processColorSchemes): Deleted. (WebCore::Document::processSupportedColorSchemes): Deleted. * dom/Document.h: * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): * page/FrameView.cpp: (WebCore::FrameView::rendererForColorScheme const): (WebCore::FrameView::useDarkAppearance const): (WebCore::FrameView::styleColorOptions const): (WebCore::FrameView::rendererForSupportedColorSchemes const): Deleted. * page/FrameView.h: * rendering/style/RenderStyle.cpp: (WebCore::rareInheritedDataChangeRequiresRepaint): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::colorScheme const): (WebCore::RenderStyle::setHasExplicitlySetColorScheme): (WebCore::RenderStyle::hasExplicitlySetColorScheme const): (WebCore::RenderStyle::setColorScheme): (WebCore::RenderStyle::initialColorScheme): (WebCore::RenderStyle::NonInheritedFlags::operator== const): (WebCore::RenderStyle::supportedColorSchemes const): Deleted. (WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Deleted. (WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Deleted. (WebCore::RenderStyle::setSupportedColorSchemes): Deleted. (WebCore::RenderStyle::initialSupportedColorSchemes): Deleted. * rendering/style/RenderStyleConstants.h: * rendering/style/StyleColorScheme.h: Renamed from Source/WebCore/rendering/style/StyleSupportedColorSchemes.h. (WebCore::StyleColorScheme::StyleColorScheme): (WebCore::StyleColorScheme::operator== const): (WebCore::StyleColorScheme::operator!= const): (WebCore::StyleColorScheme::isAuto const): (WebCore::StyleColorScheme::isOnly const): (WebCore::StyleColorScheme::colorScheme const): (WebCore::StyleColorScheme::add): (WebCore::StyleColorScheme::contains const): (WebCore::StyleColorScheme::setAllowsTransformations): (WebCore::StyleColorScheme::allowsTransformations const): * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * rendering/style/StyleRareInheritedData.h: Source/WebInspectorUI: * UserInterface/Views/Main.css: (:root): LayoutTests: * css-dark-mode/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/color-scheme-parse-expected.txt: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-parse.html: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes.html. * css-dark-mode/color-scheme-priority-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority-expected.txt. * css-dark-mode/color-scheme-priority.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority.html. * css-dark-mode/color-scheme-scrollbar-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar-expected.txt. * css-dark-mode/color-scheme-scrollbar.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar.html. * css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-css.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-meta.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/older-systems/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css-expected.txt * css-dark-mode/older-systems/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css.html. * css-dark-mode/older-systems/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-expected.txt. * css-dark-mode/older-systems/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes.html. * fast/css/style-enumerate-properties.html: Updated property count. Canonical link: https://commits.webkit.org/211294@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-04-17 23:15:01 +00:00
<meta id="meta" name="color-scheme" content="light">
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
<div id="test1"></div>
<script>
function test_prop(id, prop, expected) {
assert_equals(window.getComputedStyle(document.getElementById(id)).getPropertyValue(prop).trim(), expected);
}
function test_color_is_black(id) {
test_prop("test1", "color", "rgb(0, 0, 0)");
}
test(function() {
test_color_is_black("test1");
Rename `supported-color-schemes` to `color-scheme`. https://bugs.webkit.org/show_bug.cgi?id=197016 rdar://problem/49980259 Reviewed by Simon Fraser. Source/WebCore: Changed `supported-color-schemes` to `color-scheme` to follow the spec changes being tracked by: https://github.com/w3c/csswg-drafts/issues/3807 The old `supported-color-schemes` is now an alias of `color-scheme` for compatibility. Tests: css-dark-mode/color-scheme-css-parse.html css-dark-mode/color-scheme-css.html css-dark-mode/color-scheme-meta.html css-dark-mode/color-scheme-priority.html css-dark-mode/color-scheme-scrollbar.html css-dark-mode/older-syntax/supported-color-schemes-css.html css-dark-mode/older-syntax/supported-color-schemes-meta.html css-dark-mode/older-systems/color-scheme-css.html css-dark-mode/older-systems/color-scheme-meta.html * WebCore.xcodeproj/project.pbxproj: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::updateColorScheme): (WebCore::StyleBuilderConverter::convertColorScheme): (WebCore::StyleBuilderConverter::updateSupportedColorSchemes): Deleted. (WebCore::StyleBuilderConverter::convertSupportedColorSchemes): Deleted. * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueColorScheme): (WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::applyMatchedProperties): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeColorScheme): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::consumeSupportedColorSchemes): Deleted. * dom/Document.cpp: (WebCore::processColorSchemeString): (WebCore::Document::processColorScheme): (WebCore::Document::useDarkAppearance const): (WebCore::processColorSchemes): Deleted. (WebCore::Document::processSupportedColorSchemes): Deleted. * dom/Document.h: * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): * page/FrameView.cpp: (WebCore::FrameView::rendererForColorScheme const): (WebCore::FrameView::useDarkAppearance const): (WebCore::FrameView::styleColorOptions const): (WebCore::FrameView::rendererForSupportedColorSchemes const): Deleted. * page/FrameView.h: * rendering/style/RenderStyle.cpp: (WebCore::rareInheritedDataChangeRequiresRepaint): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::colorScheme const): (WebCore::RenderStyle::setHasExplicitlySetColorScheme): (WebCore::RenderStyle::hasExplicitlySetColorScheme const): (WebCore::RenderStyle::setColorScheme): (WebCore::RenderStyle::initialColorScheme): (WebCore::RenderStyle::NonInheritedFlags::operator== const): (WebCore::RenderStyle::supportedColorSchemes const): Deleted. (WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Deleted. (WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Deleted. (WebCore::RenderStyle::setSupportedColorSchemes): Deleted. (WebCore::RenderStyle::initialSupportedColorSchemes): Deleted. * rendering/style/RenderStyleConstants.h: * rendering/style/StyleColorScheme.h: Renamed from Source/WebCore/rendering/style/StyleSupportedColorSchemes.h. (WebCore::StyleColorScheme::StyleColorScheme): (WebCore::StyleColorScheme::operator== const): (WebCore::StyleColorScheme::operator!= const): (WebCore::StyleColorScheme::isAuto const): (WebCore::StyleColorScheme::isOnly const): (WebCore::StyleColorScheme::colorScheme const): (WebCore::StyleColorScheme::add): (WebCore::StyleColorScheme::contains const): (WebCore::StyleColorScheme::setAllowsTransformations): (WebCore::StyleColorScheme::allowsTransformations const): * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * rendering/style/StyleRareInheritedData.h: Source/WebInspectorUI: * UserInterface/Views/Main.css: (:root): LayoutTests: * css-dark-mode/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/color-scheme-parse-expected.txt: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-parse.html: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes.html. * css-dark-mode/color-scheme-priority-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority-expected.txt. * css-dark-mode/color-scheme-priority.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority.html. * css-dark-mode/color-scheme-scrollbar-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar-expected.txt. * css-dark-mode/color-scheme-scrollbar.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar.html. * css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-css.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-meta.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/older-systems/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css-expected.txt * css-dark-mode/older-systems/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css.html. * css-dark-mode/older-systems/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-expected.txt. * css-dark-mode/older-systems/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes.html. * fast/css/style-enumerate-properties.html: Updated property count. Canonical link: https://commits.webkit.org/211294@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-04-17 23:15:01 +00:00
}, "Element colors are correct in light color scheme with only light color scheme");
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
test(function() {
document.getElementById("meta").content = "light dark";
Rename `supported-color-schemes` to `color-scheme`. https://bugs.webkit.org/show_bug.cgi?id=197016 rdar://problem/49980259 Reviewed by Simon Fraser. Source/WebCore: Changed `supported-color-schemes` to `color-scheme` to follow the spec changes being tracked by: https://github.com/w3c/csswg-drafts/issues/3807 The old `supported-color-schemes` is now an alias of `color-scheme` for compatibility. Tests: css-dark-mode/color-scheme-css-parse.html css-dark-mode/color-scheme-css.html css-dark-mode/color-scheme-meta.html css-dark-mode/color-scheme-priority.html css-dark-mode/color-scheme-scrollbar.html css-dark-mode/older-syntax/supported-color-schemes-css.html css-dark-mode/older-syntax/supported-color-schemes-meta.html css-dark-mode/older-systems/color-scheme-css.html css-dark-mode/older-systems/color-scheme-meta.html * WebCore.xcodeproj/project.pbxproj: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::updateColorScheme): (WebCore::StyleBuilderConverter::convertColorScheme): (WebCore::StyleBuilderConverter::updateSupportedColorSchemes): Deleted. (WebCore::StyleBuilderConverter::convertSupportedColorSchemes): Deleted. * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueColorScheme): (WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::applyMatchedProperties): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeColorScheme): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::consumeSupportedColorSchemes): Deleted. * dom/Document.cpp: (WebCore::processColorSchemeString): (WebCore::Document::processColorScheme): (WebCore::Document::useDarkAppearance const): (WebCore::processColorSchemes): Deleted. (WebCore::Document::processSupportedColorSchemes): Deleted. * dom/Document.h: * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): * page/FrameView.cpp: (WebCore::FrameView::rendererForColorScheme const): (WebCore::FrameView::useDarkAppearance const): (WebCore::FrameView::styleColorOptions const): (WebCore::FrameView::rendererForSupportedColorSchemes const): Deleted. * page/FrameView.h: * rendering/style/RenderStyle.cpp: (WebCore::rareInheritedDataChangeRequiresRepaint): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::colorScheme const): (WebCore::RenderStyle::setHasExplicitlySetColorScheme): (WebCore::RenderStyle::hasExplicitlySetColorScheme const): (WebCore::RenderStyle::setColorScheme): (WebCore::RenderStyle::initialColorScheme): (WebCore::RenderStyle::NonInheritedFlags::operator== const): (WebCore::RenderStyle::supportedColorSchemes const): Deleted. (WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Deleted. (WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Deleted. (WebCore::RenderStyle::setSupportedColorSchemes): Deleted. (WebCore::RenderStyle::initialSupportedColorSchemes): Deleted. * rendering/style/RenderStyleConstants.h: * rendering/style/StyleColorScheme.h: Renamed from Source/WebCore/rendering/style/StyleSupportedColorSchemes.h. (WebCore::StyleColorScheme::StyleColorScheme): (WebCore::StyleColorScheme::operator== const): (WebCore::StyleColorScheme::operator!= const): (WebCore::StyleColorScheme::isAuto const): (WebCore::StyleColorScheme::isOnly const): (WebCore::StyleColorScheme::colorScheme const): (WebCore::StyleColorScheme::add): (WebCore::StyleColorScheme::contains const): (WebCore::StyleColorScheme::setAllowsTransformations): (WebCore::StyleColorScheme::allowsTransformations const): * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * rendering/style/StyleRareInheritedData.h: Source/WebInspectorUI: * UserInterface/Views/Main.css: (:root): LayoutTests: * css-dark-mode/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/color-scheme-parse-expected.txt: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-parse.html: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes.html. * css-dark-mode/color-scheme-priority-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority-expected.txt. * css-dark-mode/color-scheme-priority.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority.html. * css-dark-mode/color-scheme-scrollbar-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar-expected.txt. * css-dark-mode/color-scheme-scrollbar.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar.html. * css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-css.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-meta.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/older-systems/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css-expected.txt * css-dark-mode/older-systems/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css.html. * css-dark-mode/older-systems/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-expected.txt. * css-dark-mode/older-systems/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes.html. * fast/css/style-enumerate-properties.html: Updated property count. Canonical link: https://commits.webkit.org/211294@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-04-17 23:15:01 +00:00
}, "Color schemes changed to light and dark");
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
test(function() {
test_color_is_black("test1");
Rename `supported-color-schemes` to `color-scheme`. https://bugs.webkit.org/show_bug.cgi?id=197016 rdar://problem/49980259 Reviewed by Simon Fraser. Source/WebCore: Changed `supported-color-schemes` to `color-scheme` to follow the spec changes being tracked by: https://github.com/w3c/csswg-drafts/issues/3807 The old `supported-color-schemes` is now an alias of `color-scheme` for compatibility. Tests: css-dark-mode/color-scheme-css-parse.html css-dark-mode/color-scheme-css.html css-dark-mode/color-scheme-meta.html css-dark-mode/color-scheme-priority.html css-dark-mode/color-scheme-scrollbar.html css-dark-mode/older-syntax/supported-color-schemes-css.html css-dark-mode/older-syntax/supported-color-schemes-meta.html css-dark-mode/older-systems/color-scheme-css.html css-dark-mode/older-systems/color-scheme-meta.html * WebCore.xcodeproj/project.pbxproj: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::updateColorScheme): (WebCore::StyleBuilderConverter::convertColorScheme): (WebCore::StyleBuilderConverter::updateSupportedColorSchemes): Deleted. (WebCore::StyleBuilderConverter::convertSupportedColorSchemes): Deleted. * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueColorScheme): (WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::applyMatchedProperties): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeColorScheme): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::consumeSupportedColorSchemes): Deleted. * dom/Document.cpp: (WebCore::processColorSchemeString): (WebCore::Document::processColorScheme): (WebCore::Document::useDarkAppearance const): (WebCore::processColorSchemes): Deleted. (WebCore::Document::processSupportedColorSchemes): Deleted. * dom/Document.h: * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): * page/FrameView.cpp: (WebCore::FrameView::rendererForColorScheme const): (WebCore::FrameView::useDarkAppearance const): (WebCore::FrameView::styleColorOptions const): (WebCore::FrameView::rendererForSupportedColorSchemes const): Deleted. * page/FrameView.h: * rendering/style/RenderStyle.cpp: (WebCore::rareInheritedDataChangeRequiresRepaint): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::colorScheme const): (WebCore::RenderStyle::setHasExplicitlySetColorScheme): (WebCore::RenderStyle::hasExplicitlySetColorScheme const): (WebCore::RenderStyle::setColorScheme): (WebCore::RenderStyle::initialColorScheme): (WebCore::RenderStyle::NonInheritedFlags::operator== const): (WebCore::RenderStyle::supportedColorSchemes const): Deleted. (WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Deleted. (WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Deleted. (WebCore::RenderStyle::setSupportedColorSchemes): Deleted. (WebCore::RenderStyle::initialSupportedColorSchemes): Deleted. * rendering/style/RenderStyleConstants.h: * rendering/style/StyleColorScheme.h: Renamed from Source/WebCore/rendering/style/StyleSupportedColorSchemes.h. (WebCore::StyleColorScheme::StyleColorScheme): (WebCore::StyleColorScheme::operator== const): (WebCore::StyleColorScheme::operator!= const): (WebCore::StyleColorScheme::isAuto const): (WebCore::StyleColorScheme::isOnly const): (WebCore::StyleColorScheme::colorScheme const): (WebCore::StyleColorScheme::add): (WebCore::StyleColorScheme::contains const): (WebCore::StyleColorScheme::setAllowsTransformations): (WebCore::StyleColorScheme::allowsTransformations const): * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * rendering/style/StyleRareInheritedData.h: Source/WebInspectorUI: * UserInterface/Views/Main.css: (:root): LayoutTests: * css-dark-mode/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/color-scheme-parse-expected.txt: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-parse.html: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes.html. * css-dark-mode/color-scheme-priority-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority-expected.txt. * css-dark-mode/color-scheme-priority.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority.html. * css-dark-mode/color-scheme-scrollbar-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar-expected.txt. * css-dark-mode/color-scheme-scrollbar.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar.html. * css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-css.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-meta.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/older-systems/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css-expected.txt * css-dark-mode/older-systems/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css.html. * css-dark-mode/older-systems/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-expected.txt. * css-dark-mode/older-systems/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes.html. * fast/css/style-enumerate-properties.html: Updated property count. Canonical link: https://commits.webkit.org/211294@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-04-17 23:15:01 +00:00
}, "Element colors are correct in light color scheme with light and dark color scheme");
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
test(function() {
document.getElementById("meta").content = "dark";
Rename `supported-color-schemes` to `color-scheme`. https://bugs.webkit.org/show_bug.cgi?id=197016 rdar://problem/49980259 Reviewed by Simon Fraser. Source/WebCore: Changed `supported-color-schemes` to `color-scheme` to follow the spec changes being tracked by: https://github.com/w3c/csswg-drafts/issues/3807 The old `supported-color-schemes` is now an alias of `color-scheme` for compatibility. Tests: css-dark-mode/color-scheme-css-parse.html css-dark-mode/color-scheme-css.html css-dark-mode/color-scheme-meta.html css-dark-mode/color-scheme-priority.html css-dark-mode/color-scheme-scrollbar.html css-dark-mode/older-syntax/supported-color-schemes-css.html css-dark-mode/older-syntax/supported-color-schemes-meta.html css-dark-mode/older-systems/color-scheme-css.html css-dark-mode/older-systems/color-scheme-meta.html * WebCore.xcodeproj/project.pbxproj: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::updateColorScheme): (WebCore::StyleBuilderConverter::convertColorScheme): (WebCore::StyleBuilderConverter::updateSupportedColorSchemes): Deleted. (WebCore::StyleBuilderConverter::convertSupportedColorSchemes): Deleted. * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueColorScheme): (WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::applyMatchedProperties): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeColorScheme): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::consumeSupportedColorSchemes): Deleted. * dom/Document.cpp: (WebCore::processColorSchemeString): (WebCore::Document::processColorScheme): (WebCore::Document::useDarkAppearance const): (WebCore::processColorSchemes): Deleted. (WebCore::Document::processSupportedColorSchemes): Deleted. * dom/Document.h: * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): * page/FrameView.cpp: (WebCore::FrameView::rendererForColorScheme const): (WebCore::FrameView::useDarkAppearance const): (WebCore::FrameView::styleColorOptions const): (WebCore::FrameView::rendererForSupportedColorSchemes const): Deleted. * page/FrameView.h: * rendering/style/RenderStyle.cpp: (WebCore::rareInheritedDataChangeRequiresRepaint): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::colorScheme const): (WebCore::RenderStyle::setHasExplicitlySetColorScheme): (WebCore::RenderStyle::hasExplicitlySetColorScheme const): (WebCore::RenderStyle::setColorScheme): (WebCore::RenderStyle::initialColorScheme): (WebCore::RenderStyle::NonInheritedFlags::operator== const): (WebCore::RenderStyle::supportedColorSchemes const): Deleted. (WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Deleted. (WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Deleted. (WebCore::RenderStyle::setSupportedColorSchemes): Deleted. (WebCore::RenderStyle::initialSupportedColorSchemes): Deleted. * rendering/style/RenderStyleConstants.h: * rendering/style/StyleColorScheme.h: Renamed from Source/WebCore/rendering/style/StyleSupportedColorSchemes.h. (WebCore::StyleColorScheme::StyleColorScheme): (WebCore::StyleColorScheme::operator== const): (WebCore::StyleColorScheme::operator!= const): (WebCore::StyleColorScheme::isAuto const): (WebCore::StyleColorScheme::isOnly const): (WebCore::StyleColorScheme::colorScheme const): (WebCore::StyleColorScheme::add): (WebCore::StyleColorScheme::contains const): (WebCore::StyleColorScheme::setAllowsTransformations): (WebCore::StyleColorScheme::allowsTransformations const): * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * rendering/style/StyleRareInheritedData.h: Source/WebInspectorUI: * UserInterface/Views/Main.css: (:root): LayoutTests: * css-dark-mode/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/color-scheme-parse-expected.txt: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-parse.html: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes.html. * css-dark-mode/color-scheme-priority-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority-expected.txt. * css-dark-mode/color-scheme-priority.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority.html. * css-dark-mode/color-scheme-scrollbar-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar-expected.txt. * css-dark-mode/color-scheme-scrollbar.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar.html. * css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-css.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-meta.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/older-systems/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css-expected.txt * css-dark-mode/older-systems/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css.html. * css-dark-mode/older-systems/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-expected.txt. * css-dark-mode/older-systems/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes.html. * fast/css/style-enumerate-properties.html: Updated property count. Canonical link: https://commits.webkit.org/211294@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-04-17 23:15:01 +00:00
}, "Color schemes changed to dark");
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
test(function() {
test_color_is_black("test1");
Rename `supported-color-schemes` to `color-scheme`. https://bugs.webkit.org/show_bug.cgi?id=197016 rdar://problem/49980259 Reviewed by Simon Fraser. Source/WebCore: Changed `supported-color-schemes` to `color-scheme` to follow the spec changes being tracked by: https://github.com/w3c/csswg-drafts/issues/3807 The old `supported-color-schemes` is now an alias of `color-scheme` for compatibility. Tests: css-dark-mode/color-scheme-css-parse.html css-dark-mode/color-scheme-css.html css-dark-mode/color-scheme-meta.html css-dark-mode/color-scheme-priority.html css-dark-mode/color-scheme-scrollbar.html css-dark-mode/older-syntax/supported-color-schemes-css.html css-dark-mode/older-syntax/supported-color-schemes-meta.html css-dark-mode/older-systems/color-scheme-css.html css-dark-mode/older-systems/color-scheme-meta.html * WebCore.xcodeproj/project.pbxproj: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::updateColorScheme): (WebCore::StyleBuilderConverter::convertColorScheme): (WebCore::StyleBuilderConverter::updateSupportedColorSchemes): Deleted. (WebCore::StyleBuilderConverter::convertSupportedColorSchemes): Deleted. * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueColorScheme): (WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::applyMatchedProperties): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeColorScheme): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::consumeSupportedColorSchemes): Deleted. * dom/Document.cpp: (WebCore::processColorSchemeString): (WebCore::Document::processColorScheme): (WebCore::Document::useDarkAppearance const): (WebCore::processColorSchemes): Deleted. (WebCore::Document::processSupportedColorSchemes): Deleted. * dom/Document.h: * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): * page/FrameView.cpp: (WebCore::FrameView::rendererForColorScheme const): (WebCore::FrameView::useDarkAppearance const): (WebCore::FrameView::styleColorOptions const): (WebCore::FrameView::rendererForSupportedColorSchemes const): Deleted. * page/FrameView.h: * rendering/style/RenderStyle.cpp: (WebCore::rareInheritedDataChangeRequiresRepaint): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::colorScheme const): (WebCore::RenderStyle::setHasExplicitlySetColorScheme): (WebCore::RenderStyle::hasExplicitlySetColorScheme const): (WebCore::RenderStyle::setColorScheme): (WebCore::RenderStyle::initialColorScheme): (WebCore::RenderStyle::NonInheritedFlags::operator== const): (WebCore::RenderStyle::supportedColorSchemes const): Deleted. (WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Deleted. (WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Deleted. (WebCore::RenderStyle::setSupportedColorSchemes): Deleted. (WebCore::RenderStyle::initialSupportedColorSchemes): Deleted. * rendering/style/RenderStyleConstants.h: * rendering/style/StyleColorScheme.h: Renamed from Source/WebCore/rendering/style/StyleSupportedColorSchemes.h. (WebCore::StyleColorScheme::StyleColorScheme): (WebCore::StyleColorScheme::operator== const): (WebCore::StyleColorScheme::operator!= const): (WebCore::StyleColorScheme::isAuto const): (WebCore::StyleColorScheme::isOnly const): (WebCore::StyleColorScheme::colorScheme const): (WebCore::StyleColorScheme::add): (WebCore::StyleColorScheme::contains const): (WebCore::StyleColorScheme::setAllowsTransformations): (WebCore::StyleColorScheme::allowsTransformations const): * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * rendering/style/StyleRareInheritedData.h: Source/WebInspectorUI: * UserInterface/Views/Main.css: (:root): LayoutTests: * css-dark-mode/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/color-scheme-parse-expected.txt: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-parse.html: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes.html. * css-dark-mode/color-scheme-priority-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority-expected.txt. * css-dark-mode/color-scheme-priority.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority.html. * css-dark-mode/color-scheme-scrollbar-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar-expected.txt. * css-dark-mode/color-scheme-scrollbar.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar.html. * css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-css.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-meta.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/older-systems/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css-expected.txt * css-dark-mode/older-systems/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css.html. * css-dark-mode/older-systems/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-expected.txt. * css-dark-mode/older-systems/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes.html. * fast/css/style-enumerate-properties.html: Updated property count. Canonical link: https://commits.webkit.org/211294@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-04-17 23:15:01 +00:00
}, "Element colors are correct in light color scheme with only dark color scheme");
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
test(function() {
document.getElementById("meta").content = "light ,foo ";
Rename `supported-color-schemes` to `color-scheme`. https://bugs.webkit.org/show_bug.cgi?id=197016 rdar://problem/49980259 Reviewed by Simon Fraser. Source/WebCore: Changed `supported-color-schemes` to `color-scheme` to follow the spec changes being tracked by: https://github.com/w3c/csswg-drafts/issues/3807 The old `supported-color-schemes` is now an alias of `color-scheme` for compatibility. Tests: css-dark-mode/color-scheme-css-parse.html css-dark-mode/color-scheme-css.html css-dark-mode/color-scheme-meta.html css-dark-mode/color-scheme-priority.html css-dark-mode/color-scheme-scrollbar.html css-dark-mode/older-syntax/supported-color-schemes-css.html css-dark-mode/older-syntax/supported-color-schemes-meta.html css-dark-mode/older-systems/color-scheme-css.html css-dark-mode/older-systems/color-scheme-meta.html * WebCore.xcodeproj/project.pbxproj: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::updateColorScheme): (WebCore::StyleBuilderConverter::convertColorScheme): (WebCore::StyleBuilderConverter::updateSupportedColorSchemes): Deleted. (WebCore::StyleBuilderConverter::convertSupportedColorSchemes): Deleted. * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueColorScheme): (WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::applyMatchedProperties): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeColorScheme): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::consumeSupportedColorSchemes): Deleted. * dom/Document.cpp: (WebCore::processColorSchemeString): (WebCore::Document::processColorScheme): (WebCore::Document::useDarkAppearance const): (WebCore::processColorSchemes): Deleted. (WebCore::Document::processSupportedColorSchemes): Deleted. * dom/Document.h: * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): * page/FrameView.cpp: (WebCore::FrameView::rendererForColorScheme const): (WebCore::FrameView::useDarkAppearance const): (WebCore::FrameView::styleColorOptions const): (WebCore::FrameView::rendererForSupportedColorSchemes const): Deleted. * page/FrameView.h: * rendering/style/RenderStyle.cpp: (WebCore::rareInheritedDataChangeRequiresRepaint): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::colorScheme const): (WebCore::RenderStyle::setHasExplicitlySetColorScheme): (WebCore::RenderStyle::hasExplicitlySetColorScheme const): (WebCore::RenderStyle::setColorScheme): (WebCore::RenderStyle::initialColorScheme): (WebCore::RenderStyle::NonInheritedFlags::operator== const): (WebCore::RenderStyle::supportedColorSchemes const): Deleted. (WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Deleted. (WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Deleted. (WebCore::RenderStyle::setSupportedColorSchemes): Deleted. (WebCore::RenderStyle::initialSupportedColorSchemes): Deleted. * rendering/style/RenderStyleConstants.h: * rendering/style/StyleColorScheme.h: Renamed from Source/WebCore/rendering/style/StyleSupportedColorSchemes.h. (WebCore::StyleColorScheme::StyleColorScheme): (WebCore::StyleColorScheme::operator== const): (WebCore::StyleColorScheme::operator!= const): (WebCore::StyleColorScheme::isAuto const): (WebCore::StyleColorScheme::isOnly const): (WebCore::StyleColorScheme::colorScheme const): (WebCore::StyleColorScheme::add): (WebCore::StyleColorScheme::contains const): (WebCore::StyleColorScheme::setAllowsTransformations): (WebCore::StyleColorScheme::allowsTransformations const): * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * rendering/style/StyleRareInheritedData.h: Source/WebInspectorUI: * UserInterface/Views/Main.css: (:root): LayoutTests: * css-dark-mode/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/color-scheme-parse-expected.txt: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-parse.html: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes.html. * css-dark-mode/color-scheme-priority-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority-expected.txt. * css-dark-mode/color-scheme-priority.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority.html. * css-dark-mode/color-scheme-scrollbar-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar-expected.txt. * css-dark-mode/color-scheme-scrollbar.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar.html. * css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-css.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-meta.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/older-systems/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css-expected.txt * css-dark-mode/older-systems/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css.html. * css-dark-mode/older-systems/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-expected.txt. * css-dark-mode/older-systems/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes.html. * fast/css/style-enumerate-properties.html: Updated property count. Canonical link: https://commits.webkit.org/211294@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-04-17 23:15:01 +00:00
}, "Color schemes changed to light and a bogus value");
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
test(function() {
test_color_is_black("test1");
Update testharness.js from upstream https://bugs.webkit.org/show_bug.cgi?id=201808 Reviewed by Darin Adler. LayoutTests/imported/w3c: Update existing layout tests so that they are compatible with this new version of testharness.js. * IndexedDB-private-browsing/idbdatabase_createObjectStore9-invalidparameters.html: * IndexedDB-private-browsing/idbobjectstore_deleted.html: * web-platform-tests/custom-elements/resources/custom-elements-helpers.js: (create_window_in_test): LayoutTests: Update testharness.js from upstream 6fd5e1e086ce590a4780a30d12968. Update existing layout tests so that they are compatible with this new version of testharness.js. * TestExpectations: * css-custom-properties-api/length-expected.txt: * css-custom-properties-api/length.html: * css-custom-properties-api/registerProperty.html: * css-dark-mode/older-systems/color-scheme-css-expected.txt: * css-dark-mode/older-systems/color-scheme-css.html: * css-dark-mode/older-systems/color-scheme-meta-expected.txt: * css-dark-mode/older-systems/color-scheme-meta.html: * css3/flexbox/style-change-expected.txt: * fast/css/DOMQuad-serialization.html: * fast/css/Element-style.html: * fast/css/parse-justify-self-expected.txt: * fast/css/parse-justify-self.html: * fast/events/clipboard-event-constructor-expected.txt: * fast/events/clipboard-event-constructor.html: * fast/media/mq-js-update-media-expected.txt: * fast/media/mq-js-update-media.html: * fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas-expected.txt: * fast/mediastream/captureStream/canvas2d-expected.txt: * fast/mediastream/captureStream/canvas2d-heavy-drawing.html: * fast/mediastream/captureStream/canvas2d.html: * fast/shadow-dom/event-path-with-window-expected.txt: * fast/shadow-dom/event-path-with-window.html: * fast/shadow-dom/offsetParent-across-shadow-boundaries-expected.txt: * fast/shadow-dom/offsetParent-across-shadow-boundaries.html: * fast/shadow-dom/slotchange-for-slot-mutation-expected.txt: * fast/shadow-dom/slotchange-for-slot-mutation.html: * fast/shadow-dom/stylesheet-title-in-shadow-tree-expected.txt: * fast/shadow-dom/stylesheet-title-in-shadow-tree.html: * http/tests/fetch/redirectmode-and-preload-expected.txt: * http/tests/fetch/redirectmode-and-preload.html: * imported/blink/editing/selection/selectstart-event-crash-expected.txt: * js/promises-tests/promises-in-workers-expected.txt: * js/promises-tests/promises-in-workers.js: * resources/check-layout-th.js: (window.checkLayout): * resources/testharness.js: (WindowTestEnvironment): (WindowTestEnvironment.prototype._dispatch): (WindowTestEnvironment.prototype._forEach_windows): (WindowTestEnvironment.prototype.next_default_test_name): (WorkerTestEnvironment.prototype.next_default_test_name): (ServiceWorkerTestEnvironment.on_all_loaded): (ServiceWorkerTestEnvironment): (ShellTestEnvironment): (ShellTestEnvironment.prototype.next_default_test_name): (ShellTestEnvironment.prototype.on_new_harness_properties): (ShellTestEnvironment.prototype.on_tests_ready): (ShellTestEnvironment.prototype.add_on_loaded_callback): (ShellTestEnvironment.prototype.test_timeout): (create_test_environment): (is_shared_worker): (is_service_worker): (test): (promise_test): (this.wait_for): (EventWatcher): (done): * streams/readable-byte-stream-controller-expected.txt: * streams/readable-byte-stream-controller-worker-expected.txt: Added. * streams/readable-byte-stream-controller-worker.html: Copied from LayoutTests/streams/readable-byte-stream-controller.html. * streams/readable-byte-stream-controller.html: * streams/readable-stream-byob-reader-expected.txt: * streams/readable-stream-byob-reader-worker-expected.txt: Added. * streams/readable-stream-byob-reader-worker.html: Copied from LayoutTests/streams/readable-stream-byob-reader.html. * streams/readable-stream-byob-reader.html: * streams/readable-stream-byob-request-expected.txt: * streams/readable-stream-byob-request-worker-expected.txt: Copied from LayoutTests/streams/readable-stream-byob-request-expected.txt. * streams/readable-stream-byob-request-worker.html: Copied from LayoutTests/streams/readable-stream-byob-request.html. * streams/readable-stream-byob-request.html: * streams/reference-implementation/readable-stream-templated-expected.txt: * streams/reference-implementation/readable-stream-templated.html: * streams/reference-implementation/writable-stream-abort-expected.txt: * streams/reference-implementation/writable-stream-expected.txt: * webrtc/datachannel/basic-expected.txt: * webrtc/datachannel/basic.html: * webrtc/datachannel/mdns-ice-candidates-expected.txt: * webrtc/datachannel/mdns-ice-candidates.html: * webrtc/pc-detached-document-expected.txt: * webrtc/pc-detached-document.html: * webrtc/video-mute-expected.txt: * webrtc/video-mute-vp8-expected.txt: * webrtc/video-mute-vp8.html: * webrtc/video-mute.html: Canonical link: https://commits.webkit.org/215471@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-09-16 21:04:08 +00:00
}, "Element colors are correct in light color scheme with only light color scheme 2");
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
test(function() {
document.getElementById("meta").content = "";
Rename `supported-color-schemes` to `color-scheme`. https://bugs.webkit.org/show_bug.cgi?id=197016 rdar://problem/49980259 Reviewed by Simon Fraser. Source/WebCore: Changed `supported-color-schemes` to `color-scheme` to follow the spec changes being tracked by: https://github.com/w3c/csswg-drafts/issues/3807 The old `supported-color-schemes` is now an alias of `color-scheme` for compatibility. Tests: css-dark-mode/color-scheme-css-parse.html css-dark-mode/color-scheme-css.html css-dark-mode/color-scheme-meta.html css-dark-mode/color-scheme-priority.html css-dark-mode/color-scheme-scrollbar.html css-dark-mode/older-syntax/supported-color-schemes-css.html css-dark-mode/older-syntax/supported-color-schemes-meta.html css-dark-mode/older-systems/color-scheme-css.html css-dark-mode/older-systems/color-scheme-meta.html * WebCore.xcodeproj/project.pbxproj: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::updateColorScheme): (WebCore::StyleBuilderConverter::convertColorScheme): (WebCore::StyleBuilderConverter::updateSupportedColorSchemes): Deleted. (WebCore::StyleBuilderConverter::convertSupportedColorSchemes): Deleted. * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueColorScheme): (WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::applyMatchedProperties): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeColorScheme): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::consumeSupportedColorSchemes): Deleted. * dom/Document.cpp: (WebCore::processColorSchemeString): (WebCore::Document::processColorScheme): (WebCore::Document::useDarkAppearance const): (WebCore::processColorSchemes): Deleted. (WebCore::Document::processSupportedColorSchemes): Deleted. * dom/Document.h: * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): * page/FrameView.cpp: (WebCore::FrameView::rendererForColorScheme const): (WebCore::FrameView::useDarkAppearance const): (WebCore::FrameView::styleColorOptions const): (WebCore::FrameView::rendererForSupportedColorSchemes const): Deleted. * page/FrameView.h: * rendering/style/RenderStyle.cpp: (WebCore::rareInheritedDataChangeRequiresRepaint): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::colorScheme const): (WebCore::RenderStyle::setHasExplicitlySetColorScheme): (WebCore::RenderStyle::hasExplicitlySetColorScheme const): (WebCore::RenderStyle::setColorScheme): (WebCore::RenderStyle::initialColorScheme): (WebCore::RenderStyle::NonInheritedFlags::operator== const): (WebCore::RenderStyle::supportedColorSchemes const): Deleted. (WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Deleted. (WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Deleted. (WebCore::RenderStyle::setSupportedColorSchemes): Deleted. (WebCore::RenderStyle::initialSupportedColorSchemes): Deleted. * rendering/style/RenderStyleConstants.h: * rendering/style/StyleColorScheme.h: Renamed from Source/WebCore/rendering/style/StyleSupportedColorSchemes.h. (WebCore::StyleColorScheme::StyleColorScheme): (WebCore::StyleColorScheme::operator== const): (WebCore::StyleColorScheme::operator!= const): (WebCore::StyleColorScheme::isAuto const): (WebCore::StyleColorScheme::isOnly const): (WebCore::StyleColorScheme::colorScheme const): (WebCore::StyleColorScheme::add): (WebCore::StyleColorScheme::contains const): (WebCore::StyleColorScheme::setAllowsTransformations): (WebCore::StyleColorScheme::allowsTransformations const): * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * rendering/style/StyleRareInheritedData.h: Source/WebInspectorUI: * UserInterface/Views/Main.css: (:root): LayoutTests: * css-dark-mode/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/color-scheme-parse-expected.txt: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-parse.html: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes.html. * css-dark-mode/color-scheme-priority-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority-expected.txt. * css-dark-mode/color-scheme-priority.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority.html. * css-dark-mode/color-scheme-scrollbar-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar-expected.txt. * css-dark-mode/color-scheme-scrollbar.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar.html. * css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-css.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-meta.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/older-systems/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css-expected.txt * css-dark-mode/older-systems/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css.html. * css-dark-mode/older-systems/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-expected.txt. * css-dark-mode/older-systems/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes.html. * fast/css/style-enumerate-properties.html: Updated property count. Canonical link: https://commits.webkit.org/211294@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-04-17 23:15:01 +00:00
}, "Color schemes changed to empty value");
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
test(function() {
test_color_is_black("test1");
Rename `supported-color-schemes` to `color-scheme`. https://bugs.webkit.org/show_bug.cgi?id=197016 rdar://problem/49980259 Reviewed by Simon Fraser. Source/WebCore: Changed `supported-color-schemes` to `color-scheme` to follow the spec changes being tracked by: https://github.com/w3c/csswg-drafts/issues/3807 The old `supported-color-schemes` is now an alias of `color-scheme` for compatibility. Tests: css-dark-mode/color-scheme-css-parse.html css-dark-mode/color-scheme-css.html css-dark-mode/color-scheme-meta.html css-dark-mode/color-scheme-priority.html css-dark-mode/color-scheme-scrollbar.html css-dark-mode/older-syntax/supported-color-schemes-css.html css-dark-mode/older-syntax/supported-color-schemes-meta.html css-dark-mode/older-systems/color-scheme-css.html css-dark-mode/older-systems/color-scheme-meta.html * WebCore.xcodeproj/project.pbxproj: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::updateColorScheme): (WebCore::StyleBuilderConverter::convertColorScheme): (WebCore::StyleBuilderConverter::updateSupportedColorSchemes): Deleted. (WebCore::StyleBuilderConverter::convertSupportedColorSchemes): Deleted. * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueColorScheme): (WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::applyMatchedProperties): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeColorScheme): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::consumeSupportedColorSchemes): Deleted. * dom/Document.cpp: (WebCore::processColorSchemeString): (WebCore::Document::processColorScheme): (WebCore::Document::useDarkAppearance const): (WebCore::processColorSchemes): Deleted. (WebCore::Document::processSupportedColorSchemes): Deleted. * dom/Document.h: * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): * page/FrameView.cpp: (WebCore::FrameView::rendererForColorScheme const): (WebCore::FrameView::useDarkAppearance const): (WebCore::FrameView::styleColorOptions const): (WebCore::FrameView::rendererForSupportedColorSchemes const): Deleted. * page/FrameView.h: * rendering/style/RenderStyle.cpp: (WebCore::rareInheritedDataChangeRequiresRepaint): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::colorScheme const): (WebCore::RenderStyle::setHasExplicitlySetColorScheme): (WebCore::RenderStyle::hasExplicitlySetColorScheme const): (WebCore::RenderStyle::setColorScheme): (WebCore::RenderStyle::initialColorScheme): (WebCore::RenderStyle::NonInheritedFlags::operator== const): (WebCore::RenderStyle::supportedColorSchemes const): Deleted. (WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Deleted. (WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Deleted. (WebCore::RenderStyle::setSupportedColorSchemes): Deleted. (WebCore::RenderStyle::initialSupportedColorSchemes): Deleted. * rendering/style/RenderStyleConstants.h: * rendering/style/StyleColorScheme.h: Renamed from Source/WebCore/rendering/style/StyleSupportedColorSchemes.h. (WebCore::StyleColorScheme::StyleColorScheme): (WebCore::StyleColorScheme::operator== const): (WebCore::StyleColorScheme::operator!= const): (WebCore::StyleColorScheme::isAuto const): (WebCore::StyleColorScheme::isOnly const): (WebCore::StyleColorScheme::colorScheme const): (WebCore::StyleColorScheme::add): (WebCore::StyleColorScheme::contains const): (WebCore::StyleColorScheme::setAllowsTransformations): (WebCore::StyleColorScheme::allowsTransformations const): * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * rendering/style/StyleRareInheritedData.h: Source/WebInspectorUI: * UserInterface/Views/Main.css: (:root): LayoutTests: * css-dark-mode/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/color-scheme-parse-expected.txt: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-parse.html: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes.html. * css-dark-mode/color-scheme-priority-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority-expected.txt. * css-dark-mode/color-scheme-priority.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority.html. * css-dark-mode/color-scheme-scrollbar-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar-expected.txt. * css-dark-mode/color-scheme-scrollbar.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar.html. * css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-css.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-meta.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/older-systems/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css-expected.txt * css-dark-mode/older-systems/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css.html. * css-dark-mode/older-systems/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-expected.txt. * css-dark-mode/older-systems/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes.html. * fast/css/style-enumerate-properties.html: Updated property count. Canonical link: https://commits.webkit.org/211294@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-04-17 23:15:01 +00:00
}, "Element colors are correct in light color scheme with implicit light color scheme");
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
test(function() {
document.getElementById("meta").content = " light, dark ";
Update testharness.js from upstream https://bugs.webkit.org/show_bug.cgi?id=201808 Reviewed by Darin Adler. LayoutTests/imported/w3c: Update existing layout tests so that they are compatible with this new version of testharness.js. * IndexedDB-private-browsing/idbdatabase_createObjectStore9-invalidparameters.html: * IndexedDB-private-browsing/idbobjectstore_deleted.html: * web-platform-tests/custom-elements/resources/custom-elements-helpers.js: (create_window_in_test): LayoutTests: Update testharness.js from upstream 6fd5e1e086ce590a4780a30d12968. Update existing layout tests so that they are compatible with this new version of testharness.js. * TestExpectations: * css-custom-properties-api/length-expected.txt: * css-custom-properties-api/length.html: * css-custom-properties-api/registerProperty.html: * css-dark-mode/older-systems/color-scheme-css-expected.txt: * css-dark-mode/older-systems/color-scheme-css.html: * css-dark-mode/older-systems/color-scheme-meta-expected.txt: * css-dark-mode/older-systems/color-scheme-meta.html: * css3/flexbox/style-change-expected.txt: * fast/css/DOMQuad-serialization.html: * fast/css/Element-style.html: * fast/css/parse-justify-self-expected.txt: * fast/css/parse-justify-self.html: * fast/events/clipboard-event-constructor-expected.txt: * fast/events/clipboard-event-constructor.html: * fast/media/mq-js-update-media-expected.txt: * fast/media/mq-js-update-media.html: * fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas-expected.txt: * fast/mediastream/captureStream/canvas2d-expected.txt: * fast/mediastream/captureStream/canvas2d-heavy-drawing.html: * fast/mediastream/captureStream/canvas2d.html: * fast/shadow-dom/event-path-with-window-expected.txt: * fast/shadow-dom/event-path-with-window.html: * fast/shadow-dom/offsetParent-across-shadow-boundaries-expected.txt: * fast/shadow-dom/offsetParent-across-shadow-boundaries.html: * fast/shadow-dom/slotchange-for-slot-mutation-expected.txt: * fast/shadow-dom/slotchange-for-slot-mutation.html: * fast/shadow-dom/stylesheet-title-in-shadow-tree-expected.txt: * fast/shadow-dom/stylesheet-title-in-shadow-tree.html: * http/tests/fetch/redirectmode-and-preload-expected.txt: * http/tests/fetch/redirectmode-and-preload.html: * imported/blink/editing/selection/selectstart-event-crash-expected.txt: * js/promises-tests/promises-in-workers-expected.txt: * js/promises-tests/promises-in-workers.js: * resources/check-layout-th.js: (window.checkLayout): * resources/testharness.js: (WindowTestEnvironment): (WindowTestEnvironment.prototype._dispatch): (WindowTestEnvironment.prototype._forEach_windows): (WindowTestEnvironment.prototype.next_default_test_name): (WorkerTestEnvironment.prototype.next_default_test_name): (ServiceWorkerTestEnvironment.on_all_loaded): (ServiceWorkerTestEnvironment): (ShellTestEnvironment): (ShellTestEnvironment.prototype.next_default_test_name): (ShellTestEnvironment.prototype.on_new_harness_properties): (ShellTestEnvironment.prototype.on_tests_ready): (ShellTestEnvironment.prototype.add_on_loaded_callback): (ShellTestEnvironment.prototype.test_timeout): (create_test_environment): (is_shared_worker): (is_service_worker): (test): (promise_test): (this.wait_for): (EventWatcher): (done): * streams/readable-byte-stream-controller-expected.txt: * streams/readable-byte-stream-controller-worker-expected.txt: Added. * streams/readable-byte-stream-controller-worker.html: Copied from LayoutTests/streams/readable-byte-stream-controller.html. * streams/readable-byte-stream-controller.html: * streams/readable-stream-byob-reader-expected.txt: * streams/readable-stream-byob-reader-worker-expected.txt: Added. * streams/readable-stream-byob-reader-worker.html: Copied from LayoutTests/streams/readable-stream-byob-reader.html. * streams/readable-stream-byob-reader.html: * streams/readable-stream-byob-request-expected.txt: * streams/readable-stream-byob-request-worker-expected.txt: Copied from LayoutTests/streams/readable-stream-byob-request-expected.txt. * streams/readable-stream-byob-request-worker.html: Copied from LayoutTests/streams/readable-stream-byob-request.html. * streams/readable-stream-byob-request.html: * streams/reference-implementation/readable-stream-templated-expected.txt: * streams/reference-implementation/readable-stream-templated.html: * streams/reference-implementation/writable-stream-abort-expected.txt: * streams/reference-implementation/writable-stream-expected.txt: * webrtc/datachannel/basic-expected.txt: * webrtc/datachannel/basic.html: * webrtc/datachannel/mdns-ice-candidates-expected.txt: * webrtc/datachannel/mdns-ice-candidates.html: * webrtc/pc-detached-document-expected.txt: * webrtc/pc-detached-document.html: * webrtc/video-mute-expected.txt: * webrtc/video-mute-vp8-expected.txt: * webrtc/video-mute-vp8.html: * webrtc/video-mute.html: Canonical link: https://commits.webkit.org/215471@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-09-16 21:04:08 +00:00
}, "Color schemes changed to light and dark 2");
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
test(function() {
test_color_is_black("test1");
Update testharness.js from upstream https://bugs.webkit.org/show_bug.cgi?id=201808 Reviewed by Darin Adler. LayoutTests/imported/w3c: Update existing layout tests so that they are compatible with this new version of testharness.js. * IndexedDB-private-browsing/idbdatabase_createObjectStore9-invalidparameters.html: * IndexedDB-private-browsing/idbobjectstore_deleted.html: * web-platform-tests/custom-elements/resources/custom-elements-helpers.js: (create_window_in_test): LayoutTests: Update testharness.js from upstream 6fd5e1e086ce590a4780a30d12968. Update existing layout tests so that they are compatible with this new version of testharness.js. * TestExpectations: * css-custom-properties-api/length-expected.txt: * css-custom-properties-api/length.html: * css-custom-properties-api/registerProperty.html: * css-dark-mode/older-systems/color-scheme-css-expected.txt: * css-dark-mode/older-systems/color-scheme-css.html: * css-dark-mode/older-systems/color-scheme-meta-expected.txt: * css-dark-mode/older-systems/color-scheme-meta.html: * css3/flexbox/style-change-expected.txt: * fast/css/DOMQuad-serialization.html: * fast/css/Element-style.html: * fast/css/parse-justify-self-expected.txt: * fast/css/parse-justify-self.html: * fast/events/clipboard-event-constructor-expected.txt: * fast/events/clipboard-event-constructor.html: * fast/media/mq-js-update-media-expected.txt: * fast/media/mq-js-update-media.html: * fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas-expected.txt: * fast/mediastream/captureStream/canvas2d-expected.txt: * fast/mediastream/captureStream/canvas2d-heavy-drawing.html: * fast/mediastream/captureStream/canvas2d.html: * fast/shadow-dom/event-path-with-window-expected.txt: * fast/shadow-dom/event-path-with-window.html: * fast/shadow-dom/offsetParent-across-shadow-boundaries-expected.txt: * fast/shadow-dom/offsetParent-across-shadow-boundaries.html: * fast/shadow-dom/slotchange-for-slot-mutation-expected.txt: * fast/shadow-dom/slotchange-for-slot-mutation.html: * fast/shadow-dom/stylesheet-title-in-shadow-tree-expected.txt: * fast/shadow-dom/stylesheet-title-in-shadow-tree.html: * http/tests/fetch/redirectmode-and-preload-expected.txt: * http/tests/fetch/redirectmode-and-preload.html: * imported/blink/editing/selection/selectstart-event-crash-expected.txt: * js/promises-tests/promises-in-workers-expected.txt: * js/promises-tests/promises-in-workers.js: * resources/check-layout-th.js: (window.checkLayout): * resources/testharness.js: (WindowTestEnvironment): (WindowTestEnvironment.prototype._dispatch): (WindowTestEnvironment.prototype._forEach_windows): (WindowTestEnvironment.prototype.next_default_test_name): (WorkerTestEnvironment.prototype.next_default_test_name): (ServiceWorkerTestEnvironment.on_all_loaded): (ServiceWorkerTestEnvironment): (ShellTestEnvironment): (ShellTestEnvironment.prototype.next_default_test_name): (ShellTestEnvironment.prototype.on_new_harness_properties): (ShellTestEnvironment.prototype.on_tests_ready): (ShellTestEnvironment.prototype.add_on_loaded_callback): (ShellTestEnvironment.prototype.test_timeout): (create_test_environment): (is_shared_worker): (is_service_worker): (test): (promise_test): (this.wait_for): (EventWatcher): (done): * streams/readable-byte-stream-controller-expected.txt: * streams/readable-byte-stream-controller-worker-expected.txt: Added. * streams/readable-byte-stream-controller-worker.html: Copied from LayoutTests/streams/readable-byte-stream-controller.html. * streams/readable-byte-stream-controller.html: * streams/readable-stream-byob-reader-expected.txt: * streams/readable-stream-byob-reader-worker-expected.txt: Added. * streams/readable-stream-byob-reader-worker.html: Copied from LayoutTests/streams/readable-stream-byob-reader.html. * streams/readable-stream-byob-reader.html: * streams/readable-stream-byob-request-expected.txt: * streams/readable-stream-byob-request-worker-expected.txt: Copied from LayoutTests/streams/readable-stream-byob-request-expected.txt. * streams/readable-stream-byob-request-worker.html: Copied from LayoutTests/streams/readable-stream-byob-request.html. * streams/readable-stream-byob-request.html: * streams/reference-implementation/readable-stream-templated-expected.txt: * streams/reference-implementation/readable-stream-templated.html: * streams/reference-implementation/writable-stream-abort-expected.txt: * streams/reference-implementation/writable-stream-expected.txt: * webrtc/datachannel/basic-expected.txt: * webrtc/datachannel/basic.html: * webrtc/datachannel/mdns-ice-candidates-expected.txt: * webrtc/datachannel/mdns-ice-candidates.html: * webrtc/pc-detached-document-expected.txt: * webrtc/pc-detached-document.html: * webrtc/video-mute-expected.txt: * webrtc/video-mute-vp8-expected.txt: * webrtc/video-mute-vp8.html: * webrtc/video-mute.html: Canonical link: https://commits.webkit.org/215471@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-09-16 21:04:08 +00:00
}, "Element colors are correct in light color scheme with light and dark color scheme 2");
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
test(function() {
document.getElementById("meta").content = ", foo dark";
Rename `supported-color-schemes` to `color-scheme`. https://bugs.webkit.org/show_bug.cgi?id=197016 rdar://problem/49980259 Reviewed by Simon Fraser. Source/WebCore: Changed `supported-color-schemes` to `color-scheme` to follow the spec changes being tracked by: https://github.com/w3c/csswg-drafts/issues/3807 The old `supported-color-schemes` is now an alias of `color-scheme` for compatibility. Tests: css-dark-mode/color-scheme-css-parse.html css-dark-mode/color-scheme-css.html css-dark-mode/color-scheme-meta.html css-dark-mode/color-scheme-priority.html css-dark-mode/color-scheme-scrollbar.html css-dark-mode/older-syntax/supported-color-schemes-css.html css-dark-mode/older-syntax/supported-color-schemes-meta.html css-dark-mode/older-systems/color-scheme-css.html css-dark-mode/older-systems/color-scheme-meta.html * WebCore.xcodeproj/project.pbxproj: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::updateColorScheme): (WebCore::StyleBuilderConverter::convertColorScheme): (WebCore::StyleBuilderConverter::updateSupportedColorSchemes): Deleted. (WebCore::StyleBuilderConverter::convertSupportedColorSchemes): Deleted. * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueColorScheme): (WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::applyMatchedProperties): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeColorScheme): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::consumeSupportedColorSchemes): Deleted. * dom/Document.cpp: (WebCore::processColorSchemeString): (WebCore::Document::processColorScheme): (WebCore::Document::useDarkAppearance const): (WebCore::processColorSchemes): Deleted. (WebCore::Document::processSupportedColorSchemes): Deleted. * dom/Document.h: * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): * page/FrameView.cpp: (WebCore::FrameView::rendererForColorScheme const): (WebCore::FrameView::useDarkAppearance const): (WebCore::FrameView::styleColorOptions const): (WebCore::FrameView::rendererForSupportedColorSchemes const): Deleted. * page/FrameView.h: * rendering/style/RenderStyle.cpp: (WebCore::rareInheritedDataChangeRequiresRepaint): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::colorScheme const): (WebCore::RenderStyle::setHasExplicitlySetColorScheme): (WebCore::RenderStyle::hasExplicitlySetColorScheme const): (WebCore::RenderStyle::setColorScheme): (WebCore::RenderStyle::initialColorScheme): (WebCore::RenderStyle::NonInheritedFlags::operator== const): (WebCore::RenderStyle::supportedColorSchemes const): Deleted. (WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Deleted. (WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Deleted. (WebCore::RenderStyle::setSupportedColorSchemes): Deleted. (WebCore::RenderStyle::initialSupportedColorSchemes): Deleted. * rendering/style/RenderStyleConstants.h: * rendering/style/StyleColorScheme.h: Renamed from Source/WebCore/rendering/style/StyleSupportedColorSchemes.h. (WebCore::StyleColorScheme::StyleColorScheme): (WebCore::StyleColorScheme::operator== const): (WebCore::StyleColorScheme::operator!= const): (WebCore::StyleColorScheme::isAuto const): (WebCore::StyleColorScheme::isOnly const): (WebCore::StyleColorScheme::colorScheme const): (WebCore::StyleColorScheme::add): (WebCore::StyleColorScheme::contains const): (WebCore::StyleColorScheme::setAllowsTransformations): (WebCore::StyleColorScheme::allowsTransformations const): * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * rendering/style/StyleRareInheritedData.h: Source/WebInspectorUI: * UserInterface/Views/Main.css: (:root): LayoutTests: * css-dark-mode/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/color-scheme-parse-expected.txt: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-parse.html: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes.html. * css-dark-mode/color-scheme-priority-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority-expected.txt. * css-dark-mode/color-scheme-priority.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority.html. * css-dark-mode/color-scheme-scrollbar-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar-expected.txt. * css-dark-mode/color-scheme-scrollbar.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar.html. * css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-css.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-meta.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/older-systems/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css-expected.txt * css-dark-mode/older-systems/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css.html. * css-dark-mode/older-systems/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-expected.txt. * css-dark-mode/older-systems/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes.html. * fast/css/style-enumerate-properties.html: Updated property count. Canonical link: https://commits.webkit.org/211294@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-04-17 23:15:01 +00:00
}, "Color schemes changed to a bogus value and dark");
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
test(function() {
test_color_is_black("test1");
Rename `supported-color-schemes` to `color-scheme`. https://bugs.webkit.org/show_bug.cgi?id=197016 rdar://problem/49980259 Reviewed by Simon Fraser. Source/WebCore: Changed `supported-color-schemes` to `color-scheme` to follow the spec changes being tracked by: https://github.com/w3c/csswg-drafts/issues/3807 The old `supported-color-schemes` is now an alias of `color-scheme` for compatibility. Tests: css-dark-mode/color-scheme-css-parse.html css-dark-mode/color-scheme-css.html css-dark-mode/color-scheme-meta.html css-dark-mode/color-scheme-priority.html css-dark-mode/color-scheme-scrollbar.html css-dark-mode/older-syntax/supported-color-schemes-css.html css-dark-mode/older-syntax/supported-color-schemes-meta.html css-dark-mode/older-systems/color-scheme-css.html css-dark-mode/older-systems/color-scheme-meta.html * WebCore.xcodeproj/project.pbxproj: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSProperties.json: * css/CSSValueKeywords.in: * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::updateColorScheme): (WebCore::StyleBuilderConverter::convertColorScheme): (WebCore::StyleBuilderConverter::updateSupportedColorSchemes): Deleted. (WebCore::StyleBuilderConverter::convertSupportedColorSchemes): Deleted. * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueColorScheme): (WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes): Deleted. * css/StyleResolver.cpp: (WebCore::StyleResolver::applyMatchedProperties): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeColorScheme): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::consumeSupportedColorSchemes): Deleted. * dom/Document.cpp: (WebCore::processColorSchemeString): (WebCore::Document::processColorScheme): (WebCore::Document::useDarkAppearance const): (WebCore::processColorSchemes): Deleted. (WebCore::Document::processSupportedColorSchemes): Deleted. * dom/Document.h: * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): * page/FrameView.cpp: (WebCore::FrameView::rendererForColorScheme const): (WebCore::FrameView::useDarkAppearance const): (WebCore::FrameView::styleColorOptions const): (WebCore::FrameView::rendererForSupportedColorSchemes const): Deleted. * page/FrameView.h: * rendering/style/RenderStyle.cpp: (WebCore::rareInheritedDataChangeRequiresRepaint): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::colorScheme const): (WebCore::RenderStyle::setHasExplicitlySetColorScheme): (WebCore::RenderStyle::hasExplicitlySetColorScheme const): (WebCore::RenderStyle::setColorScheme): (WebCore::RenderStyle::initialColorScheme): (WebCore::RenderStyle::NonInheritedFlags::operator== const): (WebCore::RenderStyle::supportedColorSchemes const): Deleted. (WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Deleted. (WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Deleted. (WebCore::RenderStyle::setSupportedColorSchemes): Deleted. (WebCore::RenderStyle::initialSupportedColorSchemes): Deleted. * rendering/style/RenderStyleConstants.h: * rendering/style/StyleColorScheme.h: Renamed from Source/WebCore/rendering/style/StyleSupportedColorSchemes.h. (WebCore::StyleColorScheme::StyleColorScheme): (WebCore::StyleColorScheme::operator== const): (WebCore::StyleColorScheme::operator!= const): (WebCore::StyleColorScheme::isAuto const): (WebCore::StyleColorScheme::isOnly const): (WebCore::StyleColorScheme::colorScheme const): (WebCore::StyleColorScheme::add): (WebCore::StyleColorScheme::contains const): (WebCore::StyleColorScheme::setAllowsTransformations): (WebCore::StyleColorScheme::allowsTransformations const): * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * rendering/style/StyleRareInheritedData.h: Source/WebInspectorUI: * UserInterface/Views/Main.css: (:root): LayoutTests: * css-dark-mode/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/color-scheme-parse-expected.txt: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes-expected.txt. * css-dark-mode/color-scheme-parse.html: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes.html. * css-dark-mode/color-scheme-priority-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority-expected.txt. * css-dark-mode/color-scheme-priority.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority.html. * css-dark-mode/color-scheme-scrollbar-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar-expected.txt. * css-dark-mode/color-scheme-scrollbar.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar.html. * css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-css.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css.html. * css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt. * css-dark-mode/older-syntax/supported-color-schemes-meta.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes.html. * css-dark-mode/older-systems/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css-expected.txt * css-dark-mode/older-systems/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css.html. * css-dark-mode/older-systems/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-expected.txt. * css-dark-mode/older-systems/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes.html. * fast/css/style-enumerate-properties.html: Updated property count. Canonical link: https://commits.webkit.org/211294@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-04-17 23:15:01 +00:00
}, "Element colors are correct in light color scheme with dark color scheme");
Have prefers-color-scheme: light always match on macOS versions before Mojave. https://bugs.webkit.org/show_bug.cgi?id=191655 rdar://problem/46074680 Reviewed by Megan Gardner. Source/JavaScriptCore: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebCore: Tests: css-dark-mode/older-systems/prefers-color-scheme.html css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html Use new HAVE(OS_DARK_MODE_SUPPORT) to make it easier to find code. Added HAVE(OS_DARK_MODE_SUPPORT) around more bits to make it work on older systems. * Configurations/FeatureDefines.xcconfig: * dom/Document.cpp: (WebCore::Document::useDarkAppearance const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::enable): * page/Page.cpp: (WebCore::Page::setUseDarkAppearance): (WebCore::Page::useDarkAppearance const): (WebCore::Page::setUseDarkAppearanceOverride): * platform/mac/LocalDefaultSystemAppearance.h: (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): * platform/mac/ScrollAnimatorMac.mm: * rendering/RenderThemeMac.mm: (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]): (-[WebListButtonCell drawWithFrame:inView:]): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): (WebCore::RenderThemeMac::systemColor const): Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. Source/WebKit: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::effectiveAppearanceIsDark): * UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Source/WebKitLegacy/mac: * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * WebView/WebView.mm: (-[WebView _effectiveAppearanceIsDark]): Source/WTF: * wtf/Platform.h: Define HAVE_OS_DARK_MODE_SUPPORT on macOS 10.14. Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions. * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: LayoutTests: * css-dark-mode/older-systems/prefers-color-scheme-expected.txt: Added. * css-dark-mode/older-systems/prefers-color-scheme.html: Added. * css-dark-mode/older-systems/supported-color-schemes-css-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes-css.html: Added. * css-dark-mode/older-systems/supported-color-schemes-expected.txt: Added. * css-dark-mode/older-systems/supported-color-schemes.html: Added. * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/207885@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2019-01-13 05:54:06 +00:00
</script>