nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/css-dark-mode/default-colors-expected.txt

11 lines
475 B
Plaintext
Raw Permalink Normal View History

Default the view background color and text color to different values when in dark mode. https://bugs.webkit.org/show_bug.cgi?id=191607 rdar://problem/46045854 Reviewed by Dean Jackson. Source/WebCore: Test: css-dark-mode/default-colors.html * css/html.css: (html): Set color: text on macOS. * dom/Document.cpp: (WebCore::Document::processSupportedColorSchemes): Call recalculateBaseBackgroundColor(). * editing/EditingStyle.cpp: (WebCore::caretColorFromStyle): Added. (WebCore::EditingStyle::prepareToApplyAt): Use equalIgnoringSemanticColor. Check for caret-color directly since removeEquivalentProperties fails with semantic colors. (WebCore::extractPropertiesNotIn): Use equalIgnoringSemanticColor. Check for caret-color directly since removeEquivalentProperties fails with semantic colors. * page/Frame.cpp: (WebCore::Frame::createView): Drop backgroundColor. * page/Frame.h: * page/FrameView.cpp: (WebCore::FrameView::recalculateBaseBackgroundColor): Added. (WebCore::FrameView::updateBackgroundRecursively): Drop backgroundColor argument. Calculate the backgroundColor based on the transparent argument only. * page/FrameView.h: * platform/graphics/Color.h: (WebCore::equalIgnoringSemanticColor): Added for EditingStyle. * rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): Call recalculateBaseBackgroundColor(). * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::shouldDumpPropertyForLayer const): Use isWhiteColor() since it ignores the semantic color flag. * testing/Internals.cpp: (WebCore::Internals::setViewIsTransparent): Drop backgroundColor. (WebCore::Internals::viewBaseBackgroundColor): Added. * testing/Internals.h: * testing/Internals.idl: Added viewBaseBackgroundColor. Source/WebKit: * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::backgroundColor const): Use controlBackgroundColor. (WebKit::WebViewImpl::updateLayer): Simplified and use backgroundColor() getter. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setDrawsBackground): Drop backgroundColor. Source/WebKitLegacy/win: * WebFrame.cpp: (WebFrame::updateBackground): Drop backgroundColor. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor. LayoutTests: * css-dark-mode/default-colors-expected.txt: Added. * css-dark-mode/default-colors.html: Added. * inspector/css/shadow-scoped-style-expected.txt: Rebaseline. * platform/mac/printing/width-overflow-expected.txt: Rebaseline. Canonical link: https://commits.webkit.org/206414@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-11-15 01:48:20 +00:00
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
PASS Body text color is black, since the page isn't in dark mode
PASS View base background color is white, since the page isn't in dark mode
PASS Set dark appearance
PASS Body text color is black, since the page hasn't set a supported color scheme
PASS View base background color is white, since the page hasn't set a supported color scheme
PASS Set prefers-color-schemes: light dark on the body
PASS Body text color is white
PASS View base background color is a dark grey
Default the view background color and text color to different values when in dark mode. https://bugs.webkit.org/show_bug.cgi?id=191607 rdar://problem/46045854 Reviewed by Dean Jackson. Source/WebCore: Test: css-dark-mode/default-colors.html * css/html.css: (html): Set color: text on macOS. * dom/Document.cpp: (WebCore::Document::processSupportedColorSchemes): Call recalculateBaseBackgroundColor(). * editing/EditingStyle.cpp: (WebCore::caretColorFromStyle): Added. (WebCore::EditingStyle::prepareToApplyAt): Use equalIgnoringSemanticColor. Check for caret-color directly since removeEquivalentProperties fails with semantic colors. (WebCore::extractPropertiesNotIn): Use equalIgnoringSemanticColor. Check for caret-color directly since removeEquivalentProperties fails with semantic colors. * page/Frame.cpp: (WebCore::Frame::createView): Drop backgroundColor. * page/Frame.h: * page/FrameView.cpp: (WebCore::FrameView::recalculateBaseBackgroundColor): Added. (WebCore::FrameView::updateBackgroundRecursively): Drop backgroundColor argument. Calculate the backgroundColor based on the transparent argument only. * page/FrameView.h: * platform/graphics/Color.h: (WebCore::equalIgnoringSemanticColor): Added for EditingStyle. * rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): Call recalculateBaseBackgroundColor(). * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::shouldDumpPropertyForLayer const): Use isWhiteColor() since it ignores the semantic color flag. * testing/Internals.cpp: (WebCore::Internals::setViewIsTransparent): Drop backgroundColor. (WebCore::Internals::viewBaseBackgroundColor): Added. * testing/Internals.h: * testing/Internals.idl: Added viewBaseBackgroundColor. Source/WebKit: * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::backgroundColor const): Use controlBackgroundColor. (WebKit::WebViewImpl::updateLayer): Simplified and use backgroundColor() getter. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setDrawsBackground): Drop backgroundColor. Source/WebKitLegacy/win: * WebFrame.cpp: (WebFrame::updateBackground): Drop backgroundColor. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor. LayoutTests: * css-dark-mode/default-colors-expected.txt: Added. * css-dark-mode/default-colors.html: Added. * inspector/css/shadow-scoped-style-expected.txt: Rebaseline. * platform/mac/printing/width-overflow-expected.txt: Rebaseline. Canonical link: https://commits.webkit.org/206414@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-11-15 01:48:20 +00:00