nephele/haikuwebkit - haikuwebkit - GryphNode

nephele

/

haikuwebkit

2 lines

41 B

Plaintext

Raw Permalink Normal View History

[chromium] webkit-backface-visibility doesn't work with video https://bugs.webkit.org/show_bug.cgi?id=88908 When determining a contents layer's backface culling, use the parent layer's transform and backface-visibility properties. Track which layers need this special treatment with useParentBackfaceVisibility and setUseParentBackfaceVisibility functions in WebCore::LayerChromium, WebKit::WebLayer, and WebCore::CCLayerImpl. Patch by Christopher Cameron <ccameron@chromium.org> on 2012-06-20 Reviewed by Adrienne Walker. Source/Platform: * chromium/public/WebLayer.h: (WebLayer): Add an accessor to specify that a layer should use its parent's backface culling behavior. Source/WebCore: Tests: compositing/backface-visibility/backface-visibility-image.html compositing/backface-visibility/backface-visibility-webgl.html * platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setupContentsLayer): When a contents layer is added, tag it as inheriting its backface culling from its parent. * platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): Initialize new m_useParentBackfaceVisibility member variable. (WebCore::LayerChromium::pushPropertiesTo): Propagate m_useParentBackfaceVisibility to CCLayerImpl. * platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::setUseParentBackfaceVisibility): (WebCore::LayerChromium::useParentBackfaceVisibility): (LayerChromium): Add m_useParentBackfaceVisibility member variable and modify and query accessors. * platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl): Initialize new m_useParentBackfaceVisibility member variable. * platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::setUseParentBackfaceVisibility): (WebCore::CCLayerImpl::useParentBackfaceVisibility): (CCLayerImpl): Add m_useParentBackfaceVisibility member variable and modify and query accessors. * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: (WebCore::layerShouldBeSkipped): When examining a layer, if the layer has useParentBackfaceVisibility set then use the layer's parent layer to determine backface culling. Source/WebKit/chromium: * src/WebLayer.cpp: (WebKit::WebLayer::setUseParentBackfaceVisibility): Add an accessor to specify that a layer should use its parent's backface culling behavior. LayoutTests: * compositing/backface-visibility/backface-visibility-image-expected.png: Added. * compositing/backface-visibility/backface-visibility-image-expected.txt: Added. * compositing/backface-visibility/backface-visibility-image.html: Added. * compositing/backface-visibility/backface-visibility-webgl-expected.png: Added. * compositing/backface-visibility/backface-visibility-webgl-expected.txt: Added. * compositing/backface-visibility/backface-visibility-webgl.html: Added. Canonical link: https://commits.webkit.org/107446@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2012-06-20 19:17:43 +00:00

This test is only useful as a pixel test