haikuwebkit/LayoutTests/animations/unprefixed-properties-expec...

297 lines
11 KiB
Plaintext
Raw Permalink Normal View History

Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
Test the unprefixed animation properties.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Parsing - Basic animation-name : waldo
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-name') is 'waldo'
PASS declaration.getPropertyValue('-webkit-animation-name') is 'waldo'
Parsing - Multiple animation-names : waldo, wally
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-name') is 'waldo, wally'
PASS declaration.getPropertyValue('-webkit-animation-name') is 'waldo, wally'
PASS subRule.cssText is 'waldo'
PASS subRule.cssText is 'wally'
Parsing - Basic animation-duration : 5s
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-duration') is '5s'
PASS declaration.getPropertyValue('-webkit-animation-duration') is '5s'
Parsing - Multiple animation-durations : 10s, 20ms
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-duration') is '10s, 20ms'
PASS declaration.getPropertyValue('-webkit-animation-duration') is '10s, 20ms'
PASS subRule.cssText is '10s'
PASS subRule.cssText is '20ms'
Parsing - Basic animation-delay : 5s
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-delay') is '5s'
PASS declaration.getPropertyValue('-webkit-animation-delay') is '5s'
Parsing - Multiple animation-delays : 10s, 20ms
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-delay') is '10s, 20ms'
PASS declaration.getPropertyValue('-webkit-animation-delay') is '10s, 20ms'
PASS subRule.cssText is '10s'
PASS subRule.cssText is '20ms'
Parsing - Basic animation-timing-function : ease-in-out
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-timing-function') is 'ease-in-out'
PASS declaration.getPropertyValue('-webkit-animation-timing-function') is 'ease-in-out'
Parsing - animation-timing-function with bezier : cubic-bezier(0.2, 0.3, 0.4, 0.5)
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-timing-function') is 'cubic-bezier(0.2, 0.3, 0.4, 0.5)'
PASS declaration.getPropertyValue('-webkit-animation-timing-function') is 'cubic-bezier(0.2, 0.3, 0.4, 0.5)'
Parsing - Multiple animation-timing-functions : ease-in, ease-out
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-timing-function') is 'ease-in, ease-out'
PASS declaration.getPropertyValue('-webkit-animation-timing-function') is 'ease-in, ease-out'
PASS subRule.cssText is 'ease-in'
PASS subRule.cssText is 'ease-out'
Parsing - Basic animation-iteration-count : 4
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-iteration-count') is '4'
PASS declaration.getPropertyValue('-webkit-animation-iteration-count') is '4'
Parsing - animation-iteration-count with keyword : infinite
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-iteration-count') is 'infinite'
PASS declaration.getPropertyValue('-webkit-animation-iteration-count') is 'infinite'
Parsing - Multiple animation-iteration-counts : 2, infinite, 4
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-iteration-count') is '2, infinite, 4'
PASS declaration.getPropertyValue('-webkit-animation-iteration-count') is '2, infinite, 4'
PASS subRule.cssText is '2'
PASS subRule.cssText is 'infinite'
PASS subRule.cssText is '4'
Parsing - Normal animation-direction : normal
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-direction') is 'normal'
PASS declaration.getPropertyValue('-webkit-animation-direction') is 'normal'
Parsing - Alternate animation-direction : alternate
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-direction') is 'alternate'
PASS declaration.getPropertyValue('-webkit-animation-direction') is 'alternate'
Parsing - Reverse animation-direction : reverse
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-direction') is 'reverse'
PASS declaration.getPropertyValue('-webkit-animation-direction') is 'reverse'
Parsing - Alternate Reverse animation-direction : alternate-reverse
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-direction') is 'alternate-reverse'
PASS declaration.getPropertyValue('-webkit-animation-direction') is 'alternate-reverse'
Parsing - Multiple animation-directions : alternate, alternate, normal
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-direction') is 'alternate, alternate, normal'
PASS declaration.getPropertyValue('-webkit-animation-direction') is 'alternate, alternate, normal'
PASS subRule.cssText is 'alternate'
PASS subRule.cssText is 'alternate'
PASS subRule.cssText is 'normal'
Parsing - None animation-fill-mode : none
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-fill-mode') is 'none'
PASS declaration.getPropertyValue('-webkit-animation-fill-mode') is 'none'
Parsing - Forwards animation-fill-mode : forwards
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-fill-mode') is 'forwards'
PASS declaration.getPropertyValue('-webkit-animation-fill-mode') is 'forwards'
Parsing - Backwards animation-fill-mode : backwards
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-fill-mode') is 'backwards'
PASS declaration.getPropertyValue('-webkit-animation-fill-mode') is 'backwards'
Parsing - Both animation-fill-mode : both
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-fill-mode') is 'both'
PASS declaration.getPropertyValue('-webkit-animation-fill-mode') is 'both'
Parsing - Multiple animation-fill-modes : none, forwards, backwards, both
PASS cssRule.type is 1
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569 https://bugs.webkit.org/show_bug.cgi?id=160474 <rdar://problem/27668170> Reviewed by Simon Fraser. The fixes are behaviour we want. They just caused a regression on medium.com (reverted in http://trac.webkit.org/r203380). Now that we've branched, revert the reversion (which itself was a reversion), so we can fix the actual bug: https://bugs.webkit.org/show_bug.cgi?id=160478 Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::addPropertyWithPrefixingVariant): (WebCore::CSSParser::parseTransitionShorthand): * css/CSSPropertyNames.in: * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): (WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal): (WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal): * css/StyleProperties.cpp: (WebCore::MutableStyleProperties::removeShorthandProperty): (WebCore::StyleProperties::asText): (WebCore::MutableStyleProperties::removeProperty): Deleted. (WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted. (WebCore::MutableStyleProperties::setProperty): Deleted. (WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted. (WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted. (WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted. * css/StyleProperties.h: LayoutTests: * animations/fill-mode-forwards-zero-duration.html: * animations/play-state-start-paused.html: * animations/script-tests/spring-parsing.js: (testSpring): * animations/spring-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt: * fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt: Canonical link: https://commits.webkit.org/178614@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2016-08-02 23:43:30 +00:00
PASS declaration.length is 1
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
PASS declaration.getPropertyValue('animation-fill-mode') is 'none, forwards, backwards, both'
PASS declaration.getPropertyValue('-webkit-animation-fill-mode') is 'none, forwards, backwards, both'
PASS subRule.cssText is 'none'
PASS subRule.cssText is 'forwards'
PASS subRule.cssText is 'backwards'
PASS subRule.cssText is 'both'
Invalid - duration - Bad value : 10cm
PASS cssRule.type is 1
PASS declaration.length is 0
Returns inconsistent types for el.style.property and el.style.getPropertyValue('color') https://bugs.webkit.org/show_bug.cgi?id=147549 Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-03 Reviewed by Andreas Kling. Source/WebCore: Kudos to Greg Whitworth for finding this bug. Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html * css/CSSStyleDeclaration.idl: Our definition was wrong. Current spec: http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue Current draft: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue Gecko and EdgeHTML follow the spec. LayoutTests: The bug is very old, there were a lot of tests to update. The tests in css3/shapes are incorrect W3C tests. I only updated the expected results. The test fast/css/getPropertyValue-returns-empty-on-missing-property.html is the new one covering the bug fix. * animations/script-tests/trigger-parsing.js: (testTriggerRule): * animations/trigger-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * css3/blending/blend-mode-property-parsing-invalid-expected.txt: * css3/blending/script-tests/blend-mode-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: * css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/filter-property-parsing-invalid-expected.txt: * css3/filters/script-tests/filter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: * css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: * css3/shapes/shape-outside/values/shape-margin-004-expected.txt: * css3/shapes/shape-outside/values/shape-margin-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: * fast/backgrounds/repeat/parsing-background-repeat-expected.txt: * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: * fast/backgrounds/size/parsing-background-size-values-expected.txt: * fast/backgrounds/size/resources/parsing-background-size-values.js: * fast/box-decoration-break/box-decoration-break-parsing-expected.txt: * fast/box-decoration-break/box-decoration-break-parsing.html: * fast/box-shadow/box-shadow-parsing-invalid-expected.txt: * fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: (testInvalidFilterRule): * fast/css/background-clip-text-expected.txt: * fast/css/border-spacing-without-vertical-value.html: * fast/css/getPropertyValue-border-expected.txt: * fast/css/getPropertyValue-border.html: * fast/css/getPropertyValue-column-rule-expected.txt: * fast/css/getPropertyValue-column-rule.html: * fast/css/getPropertyValue-columns-expected.txt: * fast/css/getPropertyValue-columns.html: * fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added. * fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added. * fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: * fast/css/getPropertyValue-webkit-margin-collapse.html: * fast/css/getPropertyValue-webkit-marquee-expected.txt: * fast/css/getPropertyValue-webkit-marquee.html: * fast/css/getPropertyValue-webkit-text-stroke-expected.txt: * fast/css/getPropertyValue-webkit-text-stroke.html: * fast/css/line-height-text-autosizing.html: * fast/css/outline-offset-parsing-expected.txt: * fast/css/parsing-color-correction-expected.txt: * fast/css/parsing-object-fit-expected.txt: * fast/css/parsing-object-fit.html: * fast/css/parsing-text-rendering-expected.txt: * fast/css/parsing-webkit-font-smoothing-expected.txt: * fast/css/resources/parsing-color-correction.js: * fast/css/resources/parsing-text-rendering.js: * fast/css/resources/parsing-webkit-font-smoothing.js: * fast/css/script-tests/background-clip-text.js: * fast/css/script-tests/outline-offset-parsing.js: * fast/css/script-tests/transform-origin-parsing.js: * fast/css/sticky/parsing-position-sticky-expected.txt: * fast/css/sticky/resources/parsing-position-sticky.js: * fast/css/transform-origin-parsing-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: * fast/css3-text/font-synthesis-parse-expected.txt: * fast/css3-text/font-synthesis-parse.html: * fast/filter-image/parse-filter-image-expected.txt: * fast/filter-image/parse-filter-image.html: * fast/masking/parsing-clip-path-shape-expected.txt: * fast/masking/parsing-clip-path-shape.html: * fast/masking/parsing-mask-expected.txt: * fast/masking/parsing-mask.html: * fast/shapes/css-shapes-disabled-expected.txt: * fast/shapes/css-shapes-disabled.html: * fast/shapes/parsing/parsing-shape-lengths-expected.txt: * fast/shapes/parsing/parsing-shape-lengths.html: * platform/mac/fast/css/dashboard-region-parser-expected.txt: * platform/mac/fast/css/dashboard-region-parser.html: * platform/mac/fast/text/trailing-word-parse-expected.txt: * platform/mac/fast/text/trailing-word-parse.html: * svg/paint-order/parsing-paint-order-expected.txt: * svg/paint-order/parsing-paint-order.html: Canonical link: https://commits.webkit.org/165676@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-08-04 05:14:43 +00:00
PASS declaration.getPropertyValue('animation-duration') is ""
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
Invalid - duration - List with bad value : 10ms, 10cm, 10s
PASS cssRule.type is 1
PASS declaration.length is 0
Returns inconsistent types for el.style.property and el.style.getPropertyValue('color') https://bugs.webkit.org/show_bug.cgi?id=147549 Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-03 Reviewed by Andreas Kling. Source/WebCore: Kudos to Greg Whitworth for finding this bug. Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html * css/CSSStyleDeclaration.idl: Our definition was wrong. Current spec: http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue Current draft: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue Gecko and EdgeHTML follow the spec. LayoutTests: The bug is very old, there were a lot of tests to update. The tests in css3/shapes are incorrect W3C tests. I only updated the expected results. The test fast/css/getPropertyValue-returns-empty-on-missing-property.html is the new one covering the bug fix. * animations/script-tests/trigger-parsing.js: (testTriggerRule): * animations/trigger-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * css3/blending/blend-mode-property-parsing-invalid-expected.txt: * css3/blending/script-tests/blend-mode-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: * css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/filter-property-parsing-invalid-expected.txt: * css3/filters/script-tests/filter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: * css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: * css3/shapes/shape-outside/values/shape-margin-004-expected.txt: * css3/shapes/shape-outside/values/shape-margin-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: * fast/backgrounds/repeat/parsing-background-repeat-expected.txt: * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: * fast/backgrounds/size/parsing-background-size-values-expected.txt: * fast/backgrounds/size/resources/parsing-background-size-values.js: * fast/box-decoration-break/box-decoration-break-parsing-expected.txt: * fast/box-decoration-break/box-decoration-break-parsing.html: * fast/box-shadow/box-shadow-parsing-invalid-expected.txt: * fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: (testInvalidFilterRule): * fast/css/background-clip-text-expected.txt: * fast/css/border-spacing-without-vertical-value.html: * fast/css/getPropertyValue-border-expected.txt: * fast/css/getPropertyValue-border.html: * fast/css/getPropertyValue-column-rule-expected.txt: * fast/css/getPropertyValue-column-rule.html: * fast/css/getPropertyValue-columns-expected.txt: * fast/css/getPropertyValue-columns.html: * fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added. * fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added. * fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: * fast/css/getPropertyValue-webkit-margin-collapse.html: * fast/css/getPropertyValue-webkit-marquee-expected.txt: * fast/css/getPropertyValue-webkit-marquee.html: * fast/css/getPropertyValue-webkit-text-stroke-expected.txt: * fast/css/getPropertyValue-webkit-text-stroke.html: * fast/css/line-height-text-autosizing.html: * fast/css/outline-offset-parsing-expected.txt: * fast/css/parsing-color-correction-expected.txt: * fast/css/parsing-object-fit-expected.txt: * fast/css/parsing-object-fit.html: * fast/css/parsing-text-rendering-expected.txt: * fast/css/parsing-webkit-font-smoothing-expected.txt: * fast/css/resources/parsing-color-correction.js: * fast/css/resources/parsing-text-rendering.js: * fast/css/resources/parsing-webkit-font-smoothing.js: * fast/css/script-tests/background-clip-text.js: * fast/css/script-tests/outline-offset-parsing.js: * fast/css/script-tests/transform-origin-parsing.js: * fast/css/sticky/parsing-position-sticky-expected.txt: * fast/css/sticky/resources/parsing-position-sticky.js: * fast/css/transform-origin-parsing-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: * fast/css3-text/font-synthesis-parse-expected.txt: * fast/css3-text/font-synthesis-parse.html: * fast/filter-image/parse-filter-image-expected.txt: * fast/filter-image/parse-filter-image.html: * fast/masking/parsing-clip-path-shape-expected.txt: * fast/masking/parsing-clip-path-shape.html: * fast/masking/parsing-mask-expected.txt: * fast/masking/parsing-mask.html: * fast/shapes/css-shapes-disabled-expected.txt: * fast/shapes/css-shapes-disabled.html: * fast/shapes/parsing/parsing-shape-lengths-expected.txt: * fast/shapes/parsing/parsing-shape-lengths.html: * platform/mac/fast/css/dashboard-region-parser-expected.txt: * platform/mac/fast/css/dashboard-region-parser.html: * platform/mac/fast/text/trailing-word-parse-expected.txt: * platform/mac/fast/text/trailing-word-parse.html: * svg/paint-order/parsing-paint-order-expected.txt: * svg/paint-order/parsing-paint-order.html: Canonical link: https://commits.webkit.org/165676@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-08-04 05:14:43 +00:00
PASS declaration.getPropertyValue('animation-duration') is ""
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
Invalid - delay - Bad value : 10cm
PASS cssRule.type is 1
PASS declaration.length is 0
Returns inconsistent types for el.style.property and el.style.getPropertyValue('color') https://bugs.webkit.org/show_bug.cgi?id=147549 Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-03 Reviewed by Andreas Kling. Source/WebCore: Kudos to Greg Whitworth for finding this bug. Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html * css/CSSStyleDeclaration.idl: Our definition was wrong. Current spec: http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue Current draft: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue Gecko and EdgeHTML follow the spec. LayoutTests: The bug is very old, there were a lot of tests to update. The tests in css3/shapes are incorrect W3C tests. I only updated the expected results. The test fast/css/getPropertyValue-returns-empty-on-missing-property.html is the new one covering the bug fix. * animations/script-tests/trigger-parsing.js: (testTriggerRule): * animations/trigger-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * css3/blending/blend-mode-property-parsing-invalid-expected.txt: * css3/blending/script-tests/blend-mode-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: * css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/filter-property-parsing-invalid-expected.txt: * css3/filters/script-tests/filter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: * css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: * css3/shapes/shape-outside/values/shape-margin-004-expected.txt: * css3/shapes/shape-outside/values/shape-margin-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: * fast/backgrounds/repeat/parsing-background-repeat-expected.txt: * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: * fast/backgrounds/size/parsing-background-size-values-expected.txt: * fast/backgrounds/size/resources/parsing-background-size-values.js: * fast/box-decoration-break/box-decoration-break-parsing-expected.txt: * fast/box-decoration-break/box-decoration-break-parsing.html: * fast/box-shadow/box-shadow-parsing-invalid-expected.txt: * fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: (testInvalidFilterRule): * fast/css/background-clip-text-expected.txt: * fast/css/border-spacing-without-vertical-value.html: * fast/css/getPropertyValue-border-expected.txt: * fast/css/getPropertyValue-border.html: * fast/css/getPropertyValue-column-rule-expected.txt: * fast/css/getPropertyValue-column-rule.html: * fast/css/getPropertyValue-columns-expected.txt: * fast/css/getPropertyValue-columns.html: * fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added. * fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added. * fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: * fast/css/getPropertyValue-webkit-margin-collapse.html: * fast/css/getPropertyValue-webkit-marquee-expected.txt: * fast/css/getPropertyValue-webkit-marquee.html: * fast/css/getPropertyValue-webkit-text-stroke-expected.txt: * fast/css/getPropertyValue-webkit-text-stroke.html: * fast/css/line-height-text-autosizing.html: * fast/css/outline-offset-parsing-expected.txt: * fast/css/parsing-color-correction-expected.txt: * fast/css/parsing-object-fit-expected.txt: * fast/css/parsing-object-fit.html: * fast/css/parsing-text-rendering-expected.txt: * fast/css/parsing-webkit-font-smoothing-expected.txt: * fast/css/resources/parsing-color-correction.js: * fast/css/resources/parsing-text-rendering.js: * fast/css/resources/parsing-webkit-font-smoothing.js: * fast/css/script-tests/background-clip-text.js: * fast/css/script-tests/outline-offset-parsing.js: * fast/css/script-tests/transform-origin-parsing.js: * fast/css/sticky/parsing-position-sticky-expected.txt: * fast/css/sticky/resources/parsing-position-sticky.js: * fast/css/transform-origin-parsing-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: * fast/css3-text/font-synthesis-parse-expected.txt: * fast/css3-text/font-synthesis-parse.html: * fast/filter-image/parse-filter-image-expected.txt: * fast/filter-image/parse-filter-image.html: * fast/masking/parsing-clip-path-shape-expected.txt: * fast/masking/parsing-clip-path-shape.html: * fast/masking/parsing-mask-expected.txt: * fast/masking/parsing-mask.html: * fast/shapes/css-shapes-disabled-expected.txt: * fast/shapes/css-shapes-disabled.html: * fast/shapes/parsing/parsing-shape-lengths-expected.txt: * fast/shapes/parsing/parsing-shape-lengths.html: * platform/mac/fast/css/dashboard-region-parser-expected.txt: * platform/mac/fast/css/dashboard-region-parser.html: * platform/mac/fast/text/trailing-word-parse-expected.txt: * platform/mac/fast/text/trailing-word-parse.html: * svg/paint-order/parsing-paint-order-expected.txt: * svg/paint-order/parsing-paint-order.html: Canonical link: https://commits.webkit.org/165676@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-08-04 05:14:43 +00:00
PASS declaration.getPropertyValue('animation-delay') is ""
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
Invalid - delay - List with bad value : 10ms, 10cm, 10s
PASS cssRule.type is 1
PASS declaration.length is 0
Returns inconsistent types for el.style.property and el.style.getPropertyValue('color') https://bugs.webkit.org/show_bug.cgi?id=147549 Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-03 Reviewed by Andreas Kling. Source/WebCore: Kudos to Greg Whitworth for finding this bug. Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html * css/CSSStyleDeclaration.idl: Our definition was wrong. Current spec: http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue Current draft: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue Gecko and EdgeHTML follow the spec. LayoutTests: The bug is very old, there were a lot of tests to update. The tests in css3/shapes are incorrect W3C tests. I only updated the expected results. The test fast/css/getPropertyValue-returns-empty-on-missing-property.html is the new one covering the bug fix. * animations/script-tests/trigger-parsing.js: (testTriggerRule): * animations/trigger-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * css3/blending/blend-mode-property-parsing-invalid-expected.txt: * css3/blending/script-tests/blend-mode-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: * css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/filter-property-parsing-invalid-expected.txt: * css3/filters/script-tests/filter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: * css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: * css3/shapes/shape-outside/values/shape-margin-004-expected.txt: * css3/shapes/shape-outside/values/shape-margin-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: * fast/backgrounds/repeat/parsing-background-repeat-expected.txt: * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: * fast/backgrounds/size/parsing-background-size-values-expected.txt: * fast/backgrounds/size/resources/parsing-background-size-values.js: * fast/box-decoration-break/box-decoration-break-parsing-expected.txt: * fast/box-decoration-break/box-decoration-break-parsing.html: * fast/box-shadow/box-shadow-parsing-invalid-expected.txt: * fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: (testInvalidFilterRule): * fast/css/background-clip-text-expected.txt: * fast/css/border-spacing-without-vertical-value.html: * fast/css/getPropertyValue-border-expected.txt: * fast/css/getPropertyValue-border.html: * fast/css/getPropertyValue-column-rule-expected.txt: * fast/css/getPropertyValue-column-rule.html: * fast/css/getPropertyValue-columns-expected.txt: * fast/css/getPropertyValue-columns.html: * fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added. * fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added. * fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: * fast/css/getPropertyValue-webkit-margin-collapse.html: * fast/css/getPropertyValue-webkit-marquee-expected.txt: * fast/css/getPropertyValue-webkit-marquee.html: * fast/css/getPropertyValue-webkit-text-stroke-expected.txt: * fast/css/getPropertyValue-webkit-text-stroke.html: * fast/css/line-height-text-autosizing.html: * fast/css/outline-offset-parsing-expected.txt: * fast/css/parsing-color-correction-expected.txt: * fast/css/parsing-object-fit-expected.txt: * fast/css/parsing-object-fit.html: * fast/css/parsing-text-rendering-expected.txt: * fast/css/parsing-webkit-font-smoothing-expected.txt: * fast/css/resources/parsing-color-correction.js: * fast/css/resources/parsing-text-rendering.js: * fast/css/resources/parsing-webkit-font-smoothing.js: * fast/css/script-tests/background-clip-text.js: * fast/css/script-tests/outline-offset-parsing.js: * fast/css/script-tests/transform-origin-parsing.js: * fast/css/sticky/parsing-position-sticky-expected.txt: * fast/css/sticky/resources/parsing-position-sticky.js: * fast/css/transform-origin-parsing-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: * fast/css3-text/font-synthesis-parse-expected.txt: * fast/css3-text/font-synthesis-parse.html: * fast/filter-image/parse-filter-image-expected.txt: * fast/filter-image/parse-filter-image.html: * fast/masking/parsing-clip-path-shape-expected.txt: * fast/masking/parsing-clip-path-shape.html: * fast/masking/parsing-mask-expected.txt: * fast/masking/parsing-mask.html: * fast/shapes/css-shapes-disabled-expected.txt: * fast/shapes/css-shapes-disabled.html: * fast/shapes/parsing/parsing-shape-lengths-expected.txt: * fast/shapes/parsing/parsing-shape-lengths.html: * platform/mac/fast/css/dashboard-region-parser-expected.txt: * platform/mac/fast/css/dashboard-region-parser.html: * platform/mac/fast/text/trailing-word-parse-expected.txt: * platform/mac/fast/text/trailing-word-parse.html: * svg/paint-order/parsing-paint-order-expected.txt: * svg/paint-order/parsing-paint-order.html: Canonical link: https://commits.webkit.org/165676@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-08-04 05:14:43 +00:00
PASS declaration.getPropertyValue('animation-delay') is ""
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
Invalid - timing-function - Wrong keyword parameter : egg
PASS cssRule.type is 1
PASS declaration.length is 0
Returns inconsistent types for el.style.property and el.style.getPropertyValue('color') https://bugs.webkit.org/show_bug.cgi?id=147549 Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-03 Reviewed by Andreas Kling. Source/WebCore: Kudos to Greg Whitworth for finding this bug. Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html * css/CSSStyleDeclaration.idl: Our definition was wrong. Current spec: http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue Current draft: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue Gecko and EdgeHTML follow the spec. LayoutTests: The bug is very old, there were a lot of tests to update. The tests in css3/shapes are incorrect W3C tests. I only updated the expected results. The test fast/css/getPropertyValue-returns-empty-on-missing-property.html is the new one covering the bug fix. * animations/script-tests/trigger-parsing.js: (testTriggerRule): * animations/trigger-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * css3/blending/blend-mode-property-parsing-invalid-expected.txt: * css3/blending/script-tests/blend-mode-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: * css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/filter-property-parsing-invalid-expected.txt: * css3/filters/script-tests/filter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: * css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: * css3/shapes/shape-outside/values/shape-margin-004-expected.txt: * css3/shapes/shape-outside/values/shape-margin-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: * fast/backgrounds/repeat/parsing-background-repeat-expected.txt: * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: * fast/backgrounds/size/parsing-background-size-values-expected.txt: * fast/backgrounds/size/resources/parsing-background-size-values.js: * fast/box-decoration-break/box-decoration-break-parsing-expected.txt: * fast/box-decoration-break/box-decoration-break-parsing.html: * fast/box-shadow/box-shadow-parsing-invalid-expected.txt: * fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: (testInvalidFilterRule): * fast/css/background-clip-text-expected.txt: * fast/css/border-spacing-without-vertical-value.html: * fast/css/getPropertyValue-border-expected.txt: * fast/css/getPropertyValue-border.html: * fast/css/getPropertyValue-column-rule-expected.txt: * fast/css/getPropertyValue-column-rule.html: * fast/css/getPropertyValue-columns-expected.txt: * fast/css/getPropertyValue-columns.html: * fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added. * fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added. * fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: * fast/css/getPropertyValue-webkit-margin-collapse.html: * fast/css/getPropertyValue-webkit-marquee-expected.txt: * fast/css/getPropertyValue-webkit-marquee.html: * fast/css/getPropertyValue-webkit-text-stroke-expected.txt: * fast/css/getPropertyValue-webkit-text-stroke.html: * fast/css/line-height-text-autosizing.html: * fast/css/outline-offset-parsing-expected.txt: * fast/css/parsing-color-correction-expected.txt: * fast/css/parsing-object-fit-expected.txt: * fast/css/parsing-object-fit.html: * fast/css/parsing-text-rendering-expected.txt: * fast/css/parsing-webkit-font-smoothing-expected.txt: * fast/css/resources/parsing-color-correction.js: * fast/css/resources/parsing-text-rendering.js: * fast/css/resources/parsing-webkit-font-smoothing.js: * fast/css/script-tests/background-clip-text.js: * fast/css/script-tests/outline-offset-parsing.js: * fast/css/script-tests/transform-origin-parsing.js: * fast/css/sticky/parsing-position-sticky-expected.txt: * fast/css/sticky/resources/parsing-position-sticky.js: * fast/css/transform-origin-parsing-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: * fast/css3-text/font-synthesis-parse-expected.txt: * fast/css3-text/font-synthesis-parse.html: * fast/filter-image/parse-filter-image-expected.txt: * fast/filter-image/parse-filter-image.html: * fast/masking/parsing-clip-path-shape-expected.txt: * fast/masking/parsing-clip-path-shape.html: * fast/masking/parsing-mask-expected.txt: * fast/masking/parsing-mask.html: * fast/shapes/css-shapes-disabled-expected.txt: * fast/shapes/css-shapes-disabled.html: * fast/shapes/parsing/parsing-shape-lengths-expected.txt: * fast/shapes/parsing/parsing-shape-lengths.html: * platform/mac/fast/css/dashboard-region-parser-expected.txt: * platform/mac/fast/css/dashboard-region-parser.html: * platform/mac/fast/text/trailing-word-parse-expected.txt: * platform/mac/fast/text/trailing-word-parse.html: * svg/paint-order/parsing-paint-order-expected.txt: * svg/paint-order/parsing-paint-order.html: Canonical link: https://commits.webkit.org/165676@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-08-04 05:14:43 +00:00
PASS declaration.getPropertyValue('animation-timing-function') is ""
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
Invalid - timing-function - List with wrong keyword parameter : ease-in, egg, ease-out
PASS cssRule.type is 1
PASS declaration.length is 0
Returns inconsistent types for el.style.property and el.style.getPropertyValue('color') https://bugs.webkit.org/show_bug.cgi?id=147549 Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-03 Reviewed by Andreas Kling. Source/WebCore: Kudos to Greg Whitworth for finding this bug. Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html * css/CSSStyleDeclaration.idl: Our definition was wrong. Current spec: http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue Current draft: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue Gecko and EdgeHTML follow the spec. LayoutTests: The bug is very old, there were a lot of tests to update. The tests in css3/shapes are incorrect W3C tests. I only updated the expected results. The test fast/css/getPropertyValue-returns-empty-on-missing-property.html is the new one covering the bug fix. * animations/script-tests/trigger-parsing.js: (testTriggerRule): * animations/trigger-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * css3/blending/blend-mode-property-parsing-invalid-expected.txt: * css3/blending/script-tests/blend-mode-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: * css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/filter-property-parsing-invalid-expected.txt: * css3/filters/script-tests/filter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: * css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: * css3/shapes/shape-outside/values/shape-margin-004-expected.txt: * css3/shapes/shape-outside/values/shape-margin-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: * fast/backgrounds/repeat/parsing-background-repeat-expected.txt: * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: * fast/backgrounds/size/parsing-background-size-values-expected.txt: * fast/backgrounds/size/resources/parsing-background-size-values.js: * fast/box-decoration-break/box-decoration-break-parsing-expected.txt: * fast/box-decoration-break/box-decoration-break-parsing.html: * fast/box-shadow/box-shadow-parsing-invalid-expected.txt: * fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: (testInvalidFilterRule): * fast/css/background-clip-text-expected.txt: * fast/css/border-spacing-without-vertical-value.html: * fast/css/getPropertyValue-border-expected.txt: * fast/css/getPropertyValue-border.html: * fast/css/getPropertyValue-column-rule-expected.txt: * fast/css/getPropertyValue-column-rule.html: * fast/css/getPropertyValue-columns-expected.txt: * fast/css/getPropertyValue-columns.html: * fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added. * fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added. * fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: * fast/css/getPropertyValue-webkit-margin-collapse.html: * fast/css/getPropertyValue-webkit-marquee-expected.txt: * fast/css/getPropertyValue-webkit-marquee.html: * fast/css/getPropertyValue-webkit-text-stroke-expected.txt: * fast/css/getPropertyValue-webkit-text-stroke.html: * fast/css/line-height-text-autosizing.html: * fast/css/outline-offset-parsing-expected.txt: * fast/css/parsing-color-correction-expected.txt: * fast/css/parsing-object-fit-expected.txt: * fast/css/parsing-object-fit.html: * fast/css/parsing-text-rendering-expected.txt: * fast/css/parsing-webkit-font-smoothing-expected.txt: * fast/css/resources/parsing-color-correction.js: * fast/css/resources/parsing-text-rendering.js: * fast/css/resources/parsing-webkit-font-smoothing.js: * fast/css/script-tests/background-clip-text.js: * fast/css/script-tests/outline-offset-parsing.js: * fast/css/script-tests/transform-origin-parsing.js: * fast/css/sticky/parsing-position-sticky-expected.txt: * fast/css/sticky/resources/parsing-position-sticky.js: * fast/css/transform-origin-parsing-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: * fast/css3-text/font-synthesis-parse-expected.txt: * fast/css3-text/font-synthesis-parse.html: * fast/filter-image/parse-filter-image-expected.txt: * fast/filter-image/parse-filter-image.html: * fast/masking/parsing-clip-path-shape-expected.txt: * fast/masking/parsing-clip-path-shape.html: * fast/masking/parsing-mask-expected.txt: * fast/masking/parsing-mask.html: * fast/shapes/css-shapes-disabled-expected.txt: * fast/shapes/css-shapes-disabled.html: * fast/shapes/parsing/parsing-shape-lengths-expected.txt: * fast/shapes/parsing/parsing-shape-lengths.html: * platform/mac/fast/css/dashboard-region-parser-expected.txt: * platform/mac/fast/css/dashboard-region-parser.html: * platform/mac/fast/text/trailing-word-parse-expected.txt: * platform/mac/fast/text/trailing-word-parse.html: * svg/paint-order/parsing-paint-order-expected.txt: * svg/paint-order/parsing-paint-order.html: Canonical link: https://commits.webkit.org/165676@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-08-04 05:14:43 +00:00
PASS declaration.getPropertyValue('animation-timing-function') is ""
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
Invalid - iteration-count - Wrong keyword parameter : banana
PASS cssRule.type is 1
PASS declaration.length is 0
Returns inconsistent types for el.style.property and el.style.getPropertyValue('color') https://bugs.webkit.org/show_bug.cgi?id=147549 Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-03 Reviewed by Andreas Kling. Source/WebCore: Kudos to Greg Whitworth for finding this bug. Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html * css/CSSStyleDeclaration.idl: Our definition was wrong. Current spec: http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue Current draft: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue Gecko and EdgeHTML follow the spec. LayoutTests: The bug is very old, there were a lot of tests to update. The tests in css3/shapes are incorrect W3C tests. I only updated the expected results. The test fast/css/getPropertyValue-returns-empty-on-missing-property.html is the new one covering the bug fix. * animations/script-tests/trigger-parsing.js: (testTriggerRule): * animations/trigger-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * css3/blending/blend-mode-property-parsing-invalid-expected.txt: * css3/blending/script-tests/blend-mode-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: * css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/filter-property-parsing-invalid-expected.txt: * css3/filters/script-tests/filter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: * css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: * css3/shapes/shape-outside/values/shape-margin-004-expected.txt: * css3/shapes/shape-outside/values/shape-margin-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: * fast/backgrounds/repeat/parsing-background-repeat-expected.txt: * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: * fast/backgrounds/size/parsing-background-size-values-expected.txt: * fast/backgrounds/size/resources/parsing-background-size-values.js: * fast/box-decoration-break/box-decoration-break-parsing-expected.txt: * fast/box-decoration-break/box-decoration-break-parsing.html: * fast/box-shadow/box-shadow-parsing-invalid-expected.txt: * fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: (testInvalidFilterRule): * fast/css/background-clip-text-expected.txt: * fast/css/border-spacing-without-vertical-value.html: * fast/css/getPropertyValue-border-expected.txt: * fast/css/getPropertyValue-border.html: * fast/css/getPropertyValue-column-rule-expected.txt: * fast/css/getPropertyValue-column-rule.html: * fast/css/getPropertyValue-columns-expected.txt: * fast/css/getPropertyValue-columns.html: * fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added. * fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added. * fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: * fast/css/getPropertyValue-webkit-margin-collapse.html: * fast/css/getPropertyValue-webkit-marquee-expected.txt: * fast/css/getPropertyValue-webkit-marquee.html: * fast/css/getPropertyValue-webkit-text-stroke-expected.txt: * fast/css/getPropertyValue-webkit-text-stroke.html: * fast/css/line-height-text-autosizing.html: * fast/css/outline-offset-parsing-expected.txt: * fast/css/parsing-color-correction-expected.txt: * fast/css/parsing-object-fit-expected.txt: * fast/css/parsing-object-fit.html: * fast/css/parsing-text-rendering-expected.txt: * fast/css/parsing-webkit-font-smoothing-expected.txt: * fast/css/resources/parsing-color-correction.js: * fast/css/resources/parsing-text-rendering.js: * fast/css/resources/parsing-webkit-font-smoothing.js: * fast/css/script-tests/background-clip-text.js: * fast/css/script-tests/outline-offset-parsing.js: * fast/css/script-tests/transform-origin-parsing.js: * fast/css/sticky/parsing-position-sticky-expected.txt: * fast/css/sticky/resources/parsing-position-sticky.js: * fast/css/transform-origin-parsing-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: * fast/css3-text/font-synthesis-parse-expected.txt: * fast/css3-text/font-synthesis-parse.html: * fast/filter-image/parse-filter-image-expected.txt: * fast/filter-image/parse-filter-image.html: * fast/masking/parsing-clip-path-shape-expected.txt: * fast/masking/parsing-clip-path-shape.html: * fast/masking/parsing-mask-expected.txt: * fast/masking/parsing-mask.html: * fast/shapes/css-shapes-disabled-expected.txt: * fast/shapes/css-shapes-disabled.html: * fast/shapes/parsing/parsing-shape-lengths-expected.txt: * fast/shapes/parsing/parsing-shape-lengths.html: * platform/mac/fast/css/dashboard-region-parser-expected.txt: * platform/mac/fast/css/dashboard-region-parser.html: * platform/mac/fast/text/trailing-word-parse-expected.txt: * platform/mac/fast/text/trailing-word-parse.html: * svg/paint-order/parsing-paint-order-expected.txt: * svg/paint-order/parsing-paint-order.html: Canonical link: https://commits.webkit.org/165676@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-08-04 05:14:43 +00:00
PASS declaration.getPropertyValue('animation-iteration-count') is ""
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
Invalid - iteration-count - List with wrong keyword parameter : infinite, 10, banana
PASS cssRule.type is 1
PASS declaration.length is 0
Returns inconsistent types for el.style.property and el.style.getPropertyValue('color') https://bugs.webkit.org/show_bug.cgi?id=147549 Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-03 Reviewed by Andreas Kling. Source/WebCore: Kudos to Greg Whitworth for finding this bug. Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html * css/CSSStyleDeclaration.idl: Our definition was wrong. Current spec: http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue Current draft: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue Gecko and EdgeHTML follow the spec. LayoutTests: The bug is very old, there were a lot of tests to update. The tests in css3/shapes are incorrect W3C tests. I only updated the expected results. The test fast/css/getPropertyValue-returns-empty-on-missing-property.html is the new one covering the bug fix. * animations/script-tests/trigger-parsing.js: (testTriggerRule): * animations/trigger-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * css3/blending/blend-mode-property-parsing-invalid-expected.txt: * css3/blending/script-tests/blend-mode-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: * css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/filter-property-parsing-invalid-expected.txt: * css3/filters/script-tests/filter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: * css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: * css3/shapes/shape-outside/values/shape-margin-004-expected.txt: * css3/shapes/shape-outside/values/shape-margin-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: * fast/backgrounds/repeat/parsing-background-repeat-expected.txt: * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: * fast/backgrounds/size/parsing-background-size-values-expected.txt: * fast/backgrounds/size/resources/parsing-background-size-values.js: * fast/box-decoration-break/box-decoration-break-parsing-expected.txt: * fast/box-decoration-break/box-decoration-break-parsing.html: * fast/box-shadow/box-shadow-parsing-invalid-expected.txt: * fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: (testInvalidFilterRule): * fast/css/background-clip-text-expected.txt: * fast/css/border-spacing-without-vertical-value.html: * fast/css/getPropertyValue-border-expected.txt: * fast/css/getPropertyValue-border.html: * fast/css/getPropertyValue-column-rule-expected.txt: * fast/css/getPropertyValue-column-rule.html: * fast/css/getPropertyValue-columns-expected.txt: * fast/css/getPropertyValue-columns.html: * fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added. * fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added. * fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: * fast/css/getPropertyValue-webkit-margin-collapse.html: * fast/css/getPropertyValue-webkit-marquee-expected.txt: * fast/css/getPropertyValue-webkit-marquee.html: * fast/css/getPropertyValue-webkit-text-stroke-expected.txt: * fast/css/getPropertyValue-webkit-text-stroke.html: * fast/css/line-height-text-autosizing.html: * fast/css/outline-offset-parsing-expected.txt: * fast/css/parsing-color-correction-expected.txt: * fast/css/parsing-object-fit-expected.txt: * fast/css/parsing-object-fit.html: * fast/css/parsing-text-rendering-expected.txt: * fast/css/parsing-webkit-font-smoothing-expected.txt: * fast/css/resources/parsing-color-correction.js: * fast/css/resources/parsing-text-rendering.js: * fast/css/resources/parsing-webkit-font-smoothing.js: * fast/css/script-tests/background-clip-text.js: * fast/css/script-tests/outline-offset-parsing.js: * fast/css/script-tests/transform-origin-parsing.js: * fast/css/sticky/parsing-position-sticky-expected.txt: * fast/css/sticky/resources/parsing-position-sticky.js: * fast/css/transform-origin-parsing-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: * fast/css3-text/font-synthesis-parse-expected.txt: * fast/css3-text/font-synthesis-parse.html: * fast/filter-image/parse-filter-image-expected.txt: * fast/filter-image/parse-filter-image.html: * fast/masking/parsing-clip-path-shape-expected.txt: * fast/masking/parsing-clip-path-shape.html: * fast/masking/parsing-mask-expected.txt: * fast/masking/parsing-mask.html: * fast/shapes/css-shapes-disabled-expected.txt: * fast/shapes/css-shapes-disabled.html: * fast/shapes/parsing/parsing-shape-lengths-expected.txt: * fast/shapes/parsing/parsing-shape-lengths.html: * platform/mac/fast/css/dashboard-region-parser-expected.txt: * platform/mac/fast/css/dashboard-region-parser.html: * platform/mac/fast/text/trailing-word-parse-expected.txt: * platform/mac/fast/text/trailing-word-parse.html: * svg/paint-order/parsing-paint-order-expected.txt: * svg/paint-order/parsing-paint-order.html: Canonical link: https://commits.webkit.org/165676@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-08-04 05:14:43 +00:00
PASS declaration.getPropertyValue('animation-iteration-count') is ""
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
Invalid - direction - Wrong keyword parameter : all
PASS cssRule.type is 1
PASS declaration.length is 0
Returns inconsistent types for el.style.property and el.style.getPropertyValue('color') https://bugs.webkit.org/show_bug.cgi?id=147549 Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-03 Reviewed by Andreas Kling. Source/WebCore: Kudos to Greg Whitworth for finding this bug. Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html * css/CSSStyleDeclaration.idl: Our definition was wrong. Current spec: http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue Current draft: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue Gecko and EdgeHTML follow the spec. LayoutTests: The bug is very old, there were a lot of tests to update. The tests in css3/shapes are incorrect W3C tests. I only updated the expected results. The test fast/css/getPropertyValue-returns-empty-on-missing-property.html is the new one covering the bug fix. * animations/script-tests/trigger-parsing.js: (testTriggerRule): * animations/trigger-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * css3/blending/blend-mode-property-parsing-invalid-expected.txt: * css3/blending/script-tests/blend-mode-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: * css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/filter-property-parsing-invalid-expected.txt: * css3/filters/script-tests/filter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: * css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: * css3/shapes/shape-outside/values/shape-margin-004-expected.txt: * css3/shapes/shape-outside/values/shape-margin-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: * fast/backgrounds/repeat/parsing-background-repeat-expected.txt: * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: * fast/backgrounds/size/parsing-background-size-values-expected.txt: * fast/backgrounds/size/resources/parsing-background-size-values.js: * fast/box-decoration-break/box-decoration-break-parsing-expected.txt: * fast/box-decoration-break/box-decoration-break-parsing.html: * fast/box-shadow/box-shadow-parsing-invalid-expected.txt: * fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: (testInvalidFilterRule): * fast/css/background-clip-text-expected.txt: * fast/css/border-spacing-without-vertical-value.html: * fast/css/getPropertyValue-border-expected.txt: * fast/css/getPropertyValue-border.html: * fast/css/getPropertyValue-column-rule-expected.txt: * fast/css/getPropertyValue-column-rule.html: * fast/css/getPropertyValue-columns-expected.txt: * fast/css/getPropertyValue-columns.html: * fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added. * fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added. * fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: * fast/css/getPropertyValue-webkit-margin-collapse.html: * fast/css/getPropertyValue-webkit-marquee-expected.txt: * fast/css/getPropertyValue-webkit-marquee.html: * fast/css/getPropertyValue-webkit-text-stroke-expected.txt: * fast/css/getPropertyValue-webkit-text-stroke.html: * fast/css/line-height-text-autosizing.html: * fast/css/outline-offset-parsing-expected.txt: * fast/css/parsing-color-correction-expected.txt: * fast/css/parsing-object-fit-expected.txt: * fast/css/parsing-object-fit.html: * fast/css/parsing-text-rendering-expected.txt: * fast/css/parsing-webkit-font-smoothing-expected.txt: * fast/css/resources/parsing-color-correction.js: * fast/css/resources/parsing-text-rendering.js: * fast/css/resources/parsing-webkit-font-smoothing.js: * fast/css/script-tests/background-clip-text.js: * fast/css/script-tests/outline-offset-parsing.js: * fast/css/script-tests/transform-origin-parsing.js: * fast/css/sticky/parsing-position-sticky-expected.txt: * fast/css/sticky/resources/parsing-position-sticky.js: * fast/css/transform-origin-parsing-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: * fast/css3-text/font-synthesis-parse-expected.txt: * fast/css3-text/font-synthesis-parse.html: * fast/filter-image/parse-filter-image-expected.txt: * fast/filter-image/parse-filter-image.html: * fast/masking/parsing-clip-path-shape-expected.txt: * fast/masking/parsing-clip-path-shape.html: * fast/masking/parsing-mask-expected.txt: * fast/masking/parsing-mask.html: * fast/shapes/css-shapes-disabled-expected.txt: * fast/shapes/css-shapes-disabled.html: * fast/shapes/parsing/parsing-shape-lengths-expected.txt: * fast/shapes/parsing/parsing-shape-lengths.html: * platform/mac/fast/css/dashboard-region-parser-expected.txt: * platform/mac/fast/css/dashboard-region-parser.html: * platform/mac/fast/text/trailing-word-parse-expected.txt: * platform/mac/fast/text/trailing-word-parse.html: * svg/paint-order/parsing-paint-order-expected.txt: * svg/paint-order/parsing-paint-order.html: Canonical link: https://commits.webkit.org/165676@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-08-04 05:14:43 +00:00
PASS declaration.getPropertyValue('animation-direction') is ""
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
Invalid - direction - List with wrong keyword parameter : normal, alternate, none
PASS cssRule.type is 1
PASS declaration.length is 0
Returns inconsistent types for el.style.property and el.style.getPropertyValue('color') https://bugs.webkit.org/show_bug.cgi?id=147549 Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-03 Reviewed by Andreas Kling. Source/WebCore: Kudos to Greg Whitworth for finding this bug. Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html * css/CSSStyleDeclaration.idl: Our definition was wrong. Current spec: http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue Current draft: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue Gecko and EdgeHTML follow the spec. LayoutTests: The bug is very old, there were a lot of tests to update. The tests in css3/shapes are incorrect W3C tests. I only updated the expected results. The test fast/css/getPropertyValue-returns-empty-on-missing-property.html is the new one covering the bug fix. * animations/script-tests/trigger-parsing.js: (testTriggerRule): * animations/trigger-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * css3/blending/blend-mode-property-parsing-invalid-expected.txt: * css3/blending/script-tests/blend-mode-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: * css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/filter-property-parsing-invalid-expected.txt: * css3/filters/script-tests/filter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: * css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: * css3/shapes/shape-outside/values/shape-margin-004-expected.txt: * css3/shapes/shape-outside/values/shape-margin-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: * fast/backgrounds/repeat/parsing-background-repeat-expected.txt: * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: * fast/backgrounds/size/parsing-background-size-values-expected.txt: * fast/backgrounds/size/resources/parsing-background-size-values.js: * fast/box-decoration-break/box-decoration-break-parsing-expected.txt: * fast/box-decoration-break/box-decoration-break-parsing.html: * fast/box-shadow/box-shadow-parsing-invalid-expected.txt: * fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: (testInvalidFilterRule): * fast/css/background-clip-text-expected.txt: * fast/css/border-spacing-without-vertical-value.html: * fast/css/getPropertyValue-border-expected.txt: * fast/css/getPropertyValue-border.html: * fast/css/getPropertyValue-column-rule-expected.txt: * fast/css/getPropertyValue-column-rule.html: * fast/css/getPropertyValue-columns-expected.txt: * fast/css/getPropertyValue-columns.html: * fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added. * fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added. * fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: * fast/css/getPropertyValue-webkit-margin-collapse.html: * fast/css/getPropertyValue-webkit-marquee-expected.txt: * fast/css/getPropertyValue-webkit-marquee.html: * fast/css/getPropertyValue-webkit-text-stroke-expected.txt: * fast/css/getPropertyValue-webkit-text-stroke.html: * fast/css/line-height-text-autosizing.html: * fast/css/outline-offset-parsing-expected.txt: * fast/css/parsing-color-correction-expected.txt: * fast/css/parsing-object-fit-expected.txt: * fast/css/parsing-object-fit.html: * fast/css/parsing-text-rendering-expected.txt: * fast/css/parsing-webkit-font-smoothing-expected.txt: * fast/css/resources/parsing-color-correction.js: * fast/css/resources/parsing-text-rendering.js: * fast/css/resources/parsing-webkit-font-smoothing.js: * fast/css/script-tests/background-clip-text.js: * fast/css/script-tests/outline-offset-parsing.js: * fast/css/script-tests/transform-origin-parsing.js: * fast/css/sticky/parsing-position-sticky-expected.txt: * fast/css/sticky/resources/parsing-position-sticky.js: * fast/css/transform-origin-parsing-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: * fast/css3-text/font-synthesis-parse-expected.txt: * fast/css3-text/font-synthesis-parse.html: * fast/filter-image/parse-filter-image-expected.txt: * fast/filter-image/parse-filter-image.html: * fast/masking/parsing-clip-path-shape-expected.txt: * fast/masking/parsing-clip-path-shape.html: * fast/masking/parsing-mask-expected.txt: * fast/masking/parsing-mask.html: * fast/shapes/css-shapes-disabled-expected.txt: * fast/shapes/css-shapes-disabled.html: * fast/shapes/parsing/parsing-shape-lengths-expected.txt: * fast/shapes/parsing/parsing-shape-lengths.html: * platform/mac/fast/css/dashboard-region-parser-expected.txt: * platform/mac/fast/css/dashboard-region-parser.html: * platform/mac/fast/text/trailing-word-parse-expected.txt: * platform/mac/fast/text/trailing-word-parse.html: * svg/paint-order/parsing-paint-order-expected.txt: * svg/paint-order/parsing-paint-order.html: Canonical link: https://commits.webkit.org/165676@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-08-04 05:14:43 +00:00
PASS declaration.getPropertyValue('animation-direction') is ""
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
Invalid - fill-mode - Wrong keyword parameter : all
PASS cssRule.type is 1
PASS declaration.length is 0
Returns inconsistent types for el.style.property and el.style.getPropertyValue('color') https://bugs.webkit.org/show_bug.cgi?id=147549 Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-03 Reviewed by Andreas Kling. Source/WebCore: Kudos to Greg Whitworth for finding this bug. Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html * css/CSSStyleDeclaration.idl: Our definition was wrong. Current spec: http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue Current draft: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue Gecko and EdgeHTML follow the spec. LayoutTests: The bug is very old, there were a lot of tests to update. The tests in css3/shapes are incorrect W3C tests. I only updated the expected results. The test fast/css/getPropertyValue-returns-empty-on-missing-property.html is the new one covering the bug fix. * animations/script-tests/trigger-parsing.js: (testTriggerRule): * animations/trigger-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * css3/blending/blend-mode-property-parsing-invalid-expected.txt: * css3/blending/script-tests/blend-mode-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: * css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/filter-property-parsing-invalid-expected.txt: * css3/filters/script-tests/filter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: * css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: * css3/shapes/shape-outside/values/shape-margin-004-expected.txt: * css3/shapes/shape-outside/values/shape-margin-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: * fast/backgrounds/repeat/parsing-background-repeat-expected.txt: * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: * fast/backgrounds/size/parsing-background-size-values-expected.txt: * fast/backgrounds/size/resources/parsing-background-size-values.js: * fast/box-decoration-break/box-decoration-break-parsing-expected.txt: * fast/box-decoration-break/box-decoration-break-parsing.html: * fast/box-shadow/box-shadow-parsing-invalid-expected.txt: * fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: (testInvalidFilterRule): * fast/css/background-clip-text-expected.txt: * fast/css/border-spacing-without-vertical-value.html: * fast/css/getPropertyValue-border-expected.txt: * fast/css/getPropertyValue-border.html: * fast/css/getPropertyValue-column-rule-expected.txt: * fast/css/getPropertyValue-column-rule.html: * fast/css/getPropertyValue-columns-expected.txt: * fast/css/getPropertyValue-columns.html: * fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added. * fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added. * fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: * fast/css/getPropertyValue-webkit-margin-collapse.html: * fast/css/getPropertyValue-webkit-marquee-expected.txt: * fast/css/getPropertyValue-webkit-marquee.html: * fast/css/getPropertyValue-webkit-text-stroke-expected.txt: * fast/css/getPropertyValue-webkit-text-stroke.html: * fast/css/line-height-text-autosizing.html: * fast/css/outline-offset-parsing-expected.txt: * fast/css/parsing-color-correction-expected.txt: * fast/css/parsing-object-fit-expected.txt: * fast/css/parsing-object-fit.html: * fast/css/parsing-text-rendering-expected.txt: * fast/css/parsing-webkit-font-smoothing-expected.txt: * fast/css/resources/parsing-color-correction.js: * fast/css/resources/parsing-text-rendering.js: * fast/css/resources/parsing-webkit-font-smoothing.js: * fast/css/script-tests/background-clip-text.js: * fast/css/script-tests/outline-offset-parsing.js: * fast/css/script-tests/transform-origin-parsing.js: * fast/css/sticky/parsing-position-sticky-expected.txt: * fast/css/sticky/resources/parsing-position-sticky.js: * fast/css/transform-origin-parsing-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: * fast/css3-text/font-synthesis-parse-expected.txt: * fast/css3-text/font-synthesis-parse.html: * fast/filter-image/parse-filter-image-expected.txt: * fast/filter-image/parse-filter-image.html: * fast/masking/parsing-clip-path-shape-expected.txt: * fast/masking/parsing-clip-path-shape.html: * fast/masking/parsing-mask-expected.txt: * fast/masking/parsing-mask.html: * fast/shapes/css-shapes-disabled-expected.txt: * fast/shapes/css-shapes-disabled.html: * fast/shapes/parsing/parsing-shape-lengths-expected.txt: * fast/shapes/parsing/parsing-shape-lengths.html: * platform/mac/fast/css/dashboard-region-parser-expected.txt: * platform/mac/fast/css/dashboard-region-parser.html: * platform/mac/fast/text/trailing-word-parse-expected.txt: * platform/mac/fast/text/trailing-word-parse.html: * svg/paint-order/parsing-paint-order-expected.txt: * svg/paint-order/parsing-paint-order.html: Canonical link: https://commits.webkit.org/165676@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-08-04 05:14:43 +00:00
PASS declaration.getPropertyValue('animation-fill-mode') is ""
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
Invalid - fill-mode - List with wrong keyword parameter : none, backwards, left, alternate, forwards
PASS cssRule.type is 1
PASS declaration.length is 0
Returns inconsistent types for el.style.property and el.style.getPropertyValue('color') https://bugs.webkit.org/show_bug.cgi?id=147549 Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-03 Reviewed by Andreas Kling. Source/WebCore: Kudos to Greg Whitworth for finding this bug. Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html * css/CSSStyleDeclaration.idl: Our definition was wrong. Current spec: http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue Current draft: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue Gecko and EdgeHTML follow the spec. LayoutTests: The bug is very old, there were a lot of tests to update. The tests in css3/shapes are incorrect W3C tests. I only updated the expected results. The test fast/css/getPropertyValue-returns-empty-on-missing-property.html is the new one covering the bug fix. * animations/script-tests/trigger-parsing.js: (testTriggerRule): * animations/trigger-parsing-expected.txt: * animations/unprefixed-properties-expected.txt: * animations/unprefixed-properties.html: * css3/blending/blend-mode-property-parsing-invalid-expected.txt: * css3/blending/script-tests/blend-mode-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt: * css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/filters/filter-property-parsing-invalid-expected.txt: * css3/filters/script-tests/filter-property-parsing-invalid.js: (testInvalidFilterRule): * css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: * css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: * css3/shapes/shape-outside/values/shape-margin-004-expected.txt: * css3/shapes/shape-outside/values/shape-margin-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: * css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: * css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: * fast/backgrounds/repeat/parsing-background-repeat-expected.txt: * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: * fast/backgrounds/size/parsing-background-size-values-expected.txt: * fast/backgrounds/size/resources/parsing-background-size-values.js: * fast/box-decoration-break/box-decoration-break-parsing-expected.txt: * fast/box-decoration-break/box-decoration-break-parsing.html: * fast/box-shadow/box-shadow-parsing-invalid-expected.txt: * fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: (testInvalidFilterRule): * fast/css/background-clip-text-expected.txt: * fast/css/border-spacing-without-vertical-value.html: * fast/css/getPropertyValue-border-expected.txt: * fast/css/getPropertyValue-border.html: * fast/css/getPropertyValue-column-rule-expected.txt: * fast/css/getPropertyValue-column-rule.html: * fast/css/getPropertyValue-columns-expected.txt: * fast/css/getPropertyValue-columns.html: * fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added. * fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added. * fast/css/getPropertyValue-webkit-margin-collapse-expected.txt: * fast/css/getPropertyValue-webkit-margin-collapse.html: * fast/css/getPropertyValue-webkit-marquee-expected.txt: * fast/css/getPropertyValue-webkit-marquee.html: * fast/css/getPropertyValue-webkit-text-stroke-expected.txt: * fast/css/getPropertyValue-webkit-text-stroke.html: * fast/css/line-height-text-autosizing.html: * fast/css/outline-offset-parsing-expected.txt: * fast/css/parsing-color-correction-expected.txt: * fast/css/parsing-object-fit-expected.txt: * fast/css/parsing-object-fit.html: * fast/css/parsing-text-rendering-expected.txt: * fast/css/parsing-webkit-font-smoothing-expected.txt: * fast/css/resources/parsing-color-correction.js: * fast/css/resources/parsing-text-rendering.js: * fast/css/resources/parsing-webkit-font-smoothing.js: * fast/css/script-tests/background-clip-text.js: * fast/css/script-tests/outline-offset-parsing.js: * fast/css/script-tests/transform-origin-parsing.js: * fast/css/sticky/parsing-position-sticky-expected.txt: * fast/css/sticky/resources/parsing-position-sticky.js: * fast/css/transform-origin-parsing-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt: * fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: * fast/css3-text/font-synthesis-parse-expected.txt: * fast/css3-text/font-synthesis-parse.html: * fast/filter-image/parse-filter-image-expected.txt: * fast/filter-image/parse-filter-image.html: * fast/masking/parsing-clip-path-shape-expected.txt: * fast/masking/parsing-clip-path-shape.html: * fast/masking/parsing-mask-expected.txt: * fast/masking/parsing-mask.html: * fast/shapes/css-shapes-disabled-expected.txt: * fast/shapes/css-shapes-disabled.html: * fast/shapes/parsing/parsing-shape-lengths-expected.txt: * fast/shapes/parsing/parsing-shape-lengths.html: * platform/mac/fast/css/dashboard-region-parser-expected.txt: * platform/mac/fast/css/dashboard-region-parser.html: * platform/mac/fast/text/trailing-word-parse-expected.txt: * platform/mac/fast/text/trailing-word-parse.html: * svg/paint-order/parsing-paint-order-expected.txt: * svg/paint-order/parsing-paint-order.html: Canonical link: https://commits.webkit.org/165676@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2015-08-04 05:14:43 +00:00
PASS declaration.getPropertyValue('animation-fill-mode') is ""
Support unprefixed animation property names https://bugs.webkit.org/show_bug.cgi?id=138678 <rdar://problem/18943059> Reviewed by Simon Fraser. Source/WebCore: Step 1 of 3 in unprefixing CSS animations: handling the property names and values. Unlike other unprefixing, where we use an alias that effectively removes the prefixed values from the code, for animations we need to keep the old values around so that existing content will not break (e.g. computed style). During testing I noticed that we didn't handle the (relatively) new animation-direction values of "reverse" and "alternate-reverse" when querying computed style. Tests: animations/unprefixed-properties.html animations/unprefixed-shorthand.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Handle the unprefixed values, but also get animation direction to produce the correct results when "reverse" and "alternate-reverse" is specified. * css/CSSParser.cpp: Handle the new values. If necessary, pass a flag around indicating whether it is prefixed or unprefixed. (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationShorthand): Use the flag to decide which of the forms we're going to check. (WebCore::CSSParser::parseAnimationProperty): * css/CSSParser.h: * css/CSSProperty.h: (WebCore::prefixingVariantForPropertyId): Add prefixing/unprefixing variants for all the animation values, and clean up the code a bit. * css/CSSPropertyNames.in: Add new properties. * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): We need handlers for the unprefixed forms. This should move to the new StyleBuilder soon. * css/StyleProperties.cpp: Handle new values. (WebCore::StyleProperties::getPropertyValue): (WebCore::StyleProperties::asText): * css/StylePropertyShorthand.cpp: (WebCore::animationShorthand): (WebCore::animationShorthandForParsing): Decide which list of properties to use. (WebCore::shorthandForProperty): (WebCore::matchingShorthandsForLonghand): (WebCore::webkitAnimationShorthandForParsing): Deleted. * css/StylePropertyShorthand.h: * css/StyleResolver.cpp: Since the new properties come before "background" in alphabetical order, they are earlier in the CSSPropertyNames.in file, and thus we need to update the call sites that think CSSPropertyBackground is the first property. (WebCore::StyleResolver::styleForKeyframe): Replace CSSPropertyBackground with CSSPropertyAnimation. (WebCore::StyleResolver::styleForPage): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::applyProperty): LayoutTests: Tests for unprefixed parsing and calculation of animation properties. Fun fact, this is the first test we have for the computed style of all animation-direction values. * animations/unprefixed-properties-expected.txt: Added. * animations/unprefixed-properties.html: Added. * animations/unprefixed-shorthand-expected.txt: Added. * animations/unprefixed-shorthand.html: Added. Canonical link: https://commits.webkit.org/156530@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-11-13 01:23:15 +00:00
Computed Style - Basic animation-name : waldo
PASS animationStyle.cssText is 'waldo'
Computed Style - Multiple animation-names : waldo, wally
PASS subRule.cssText is 'waldo'
PASS subRule.cssText is 'wally'
Computed Style - Basic animation-duration : 5s
PASS animationStyle.cssText is '5s'
Computed Style - Multiple animation-durations : 10s, 20ms
PASS subRule.cssText is '10s'
PASS subRule.cssText is '0.02s'
Computed Style - Basic animation-delay : 5s
PASS animationStyle.cssText is '5s'
Computed Style - Multiple animation-delays : 10s, 20ms
PASS subRule.cssText is '10s'
PASS subRule.cssText is '0.02s'
Computed Style - Basic animation-timing-function : ease-in-out
PASS animationStyle.cssText is 'ease-in-out'
Computed Style - animation-timing-function with bezier : cubic-bezier(0.2, 0.3, 0.4, 0.5)
PASS animationStyle.cssText is 'cubic-bezier(0.2, 0.3, 0.4, 0.5)'
Computed Style - Multiple animation-timing-functions : ease-in, ease-out
PASS subRule.cssText is 'ease-in'
PASS subRule.cssText is 'ease-out'
Computed Style - Basic animation-iteration-count : 4
PASS animationStyle.cssText is '4'
Computed Style - animation-iteration-count with keyword : infinite
PASS animationStyle.cssText is 'infinite'
Computed Style - Multiple animation-iteration-counts : 2, infinite, 4
PASS subRule.cssText is '2'
PASS subRule.cssText is 'infinite'
PASS subRule.cssText is '4'
Computed Style - Normal animation-direction : normal
PASS animationStyle.cssText is 'normal'
Computed Style - Alternate animation-direction : alternate
PASS animationStyle.cssText is 'alternate'
Computed Style - Reverse animation-direction : reverse
PASS animationStyle.cssText is 'reverse'
Computed Style - Alternate Reverse animation-direction : alternate-reverse
PASS animationStyle.cssText is 'alternate-reverse'
Computed Style - Multiple animation-directions : alternate, alternate, normal
PASS subRule.cssText is 'alternate'
PASS subRule.cssText is 'alternate'
PASS subRule.cssText is 'normal'
Computed Style - None animation-fill-mode : none
PASS animationStyle.cssText is 'none'
Computed Style - Forwards animation-fill-mode : forwards
PASS animationStyle.cssText is 'forwards'
Computed Style - Backwards animation-fill-mode : backwards
PASS animationStyle.cssText is 'backwards'
Computed Style - Both animation-fill-mode : both
PASS animationStyle.cssText is 'both'
Computed Style - Multiple animation-fill-modes : none, forwards, backwards, both
PASS subRule.cssText is 'none'
PASS subRule.cssText is 'forwards'
PASS subRule.cssText is 'backwards'
PASS subRule.cssText is 'both'
PASS successfullyParsed is true
TEST COMPLETE