nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/animations/steps-transform-compositing...

7 lines
87 B
Plaintext
Raw Permalink Normal View History

Avoid triggering redundant compositing updates when trying ot run a steps() animation on transform https://bugs.webkit.org/show_bug.cgi?id=215241 <rdar://problem/62737868> Reviewed by Zalan Bujtas. Source/WebCore: With a steps() timing function and keyframes animating the transform property, KeyframeEffect::applyPendingAcceleratedActions() tries to restart the animation every time because the GraphicsLayer reports that it didn't start an accelerated animation. r264856 patched some of this, but we still call animationFinished() every time, and this triggers a compositing update via the m_owningLayer.setNeeds* calls in RenderLayerBacking::animationFinished(). So don't try to remove the animation if wasn't running. This makes those compositing updates a no-op, which is important because these animations still invalidate style on every frame (webkit.org/b/215229). Test: animations/steps-transform-compositing-updates.html * animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::applyPendingAcceleratedActions): LayoutTests: animations/steps-transform-rendering-updates.html was landed with a bug; it aliased the global 'count' variable, and was thus testing the wrong thing. So land a failing result for the test for now (webkit.org/b/215229 addresses the fix). * animations/steps-transform-compositing-updates-expected.txt: Copied from LayoutTests/animations/steps-transform-rendering-updates-expected.txt. * animations/steps-transform-compositing-updates.html: Copied from LayoutTests/animations/steps-transform-rendering-updates.html. * animations/steps-transform-rendering-updates-expected.txt: * animations/steps-transform-rendering-updates.html: Canonical link: https://commits.webkit.org/228036@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-08-07 00:57:45 +00:00
PASS count is 0
PASS count < 6 is true
PASS successfullyParsed is true
TEST COMPLETE