nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/animations/large-negative-delay-expect...

4 lines
131 B
Plaintext
Raw Permalink Normal View History

Large negative animation-delays may not work depending on machine uptime https://bugs.webkit.org/show_bug.cgi?id=166962 <rdar://problem/30091526> Reviewed by Tim Horton. Source/WebCore: If you set a really negative animation delay, it would cause AnimationBase::m_startTime to become negative, because the delay value was "bigger" than monotonicallyIncreasingTime. However, the state machine was using -1 to mean that the start time hadn't yet been set. Classic cmarrin! Replace all the special values with std::optional, and use nullopt to mean the value doesn't exist yet. Test: animations/large-negative-delay.html * page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine): (WebCore::AnimationBase::fireAnimationEventsIfNeeded): (WebCore::AnimationBase::getTimeToNextEvent): (WebCore::AnimationBase::freezeAtTime): (WebCore::AnimationBase::getElapsedTime): * page/animation/AnimationBase.h: Use std::optional. (WebCore::AnimationBase::paused): LayoutTests: * animations/large-negative-delay-expected.txt: Added. * animations/large-negative-delay.html: Added. Canonical link: https://commits.webkit.org/187769@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@215352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2017-04-14 01:56:35 +00:00
PASS: Saw iteration event. The animation did start.
PASS: Elapsed time is large. The animation thinks it started a long time ago.