nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/accessibility/textarea-insertion-point-li...

22 lines
730 B
Plaintext
Raw Permalink Normal View History

Fix for accessibility/textarea-insertion-point-line-number.html. https://bugs.webkit.org/show_bug.cgi?id=223936 <rdar://problem/76007361> Reviewed by Chris Fleizach. Source/WebCore: Test: accessibility/textarea-insertion-point-line-number.html Added AXCoreObject::insertionPointLineNumber to support this functionality. This replaces the previous implementation in the wrapper's accessibilityAttributeValue. There were several problems with the previous implementation that was doing an unnecessary and buggy round trip from Ranges to indexes and back to VisiblePositions. * accessibility/AccessibilityObject.h: * accessibility/AccessibilityObjectInterface.h: * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::insertionPointLineNumber const): * accessibility/AccessibilityRenderObject.h: * accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::insertionPointLineNumber const): (WebCore::AXIsolatedObject::selectionStart const): Deleted. (WebCore::AXIsolatedObject::selectionEnd const): Deleted. * accessibility/isolatedtree/AXIsolatedObject.h: * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): LayoutTests: Updated this test and corrected several issues where the expected returned values were incorrect. * accessibility/textarea-insertion-point-line-number-expected.txt: * accessibility/textarea-insertion-point-line-number.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275217 268f45cc-cd09-0410-ab3c-d52691b4dbfc Canonical link: https://commits.webkit.org/235911@main
2021-03-30 18:47:17 +00:00
Line1
Line3
Make AccessibilityObject::lineForPosition return the correct value for cases where the position is not within the current object. https://bugs.webkit.org/show_bug.cgi?id=71348 Reviewed by Chris Fleizach. Source/WebCore: * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::lineForPosition): * accessibility/mac/WebAccessibilityObjectWrapper.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): LayoutTests: * accessibility/textarea-insertion-point-line-number-expected.txt: * accessibility/textarea-insertion-point-line-number.html: Canonical link: https://commits.webkit.org/91561@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-12-19 01:12:27 +00:00
This tests that lineNumberForPosition is reported correctly for textarea and contenteditable elements.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Fix for accessibility/textarea-insertion-point-line-number.html. https://bugs.webkit.org/show_bug.cgi?id=223936 <rdar://problem/76007361> Reviewed by Chris Fleizach. Source/WebCore: Test: accessibility/textarea-insertion-point-line-number.html Added AXCoreObject::insertionPointLineNumber to support this functionality. This replaces the previous implementation in the wrapper's accessibilityAttributeValue. There were several problems with the previous implementation that was doing an unnecessary and buggy round trip from Ranges to indexes and back to VisiblePositions. * accessibility/AccessibilityObject.h: * accessibility/AccessibilityObjectInterface.h: * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::insertionPointLineNumber const): * accessibility/AccessibilityRenderObject.h: * accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::insertionPointLineNumber const): (WebCore::AXIsolatedObject::selectionStart const): Deleted. (WebCore::AXIsolatedObject::selectionEnd const): Deleted. * accessibility/isolatedtree/AXIsolatedObject.h: * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): LayoutTests: Updated this test and corrected several issues where the expected returned values were incorrect. * accessibility/textarea-insertion-point-line-number-expected.txt: * accessibility/textarea-insertion-point-line-number.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275217 268f45cc-cd09-0410-ab3c-d52691b4dbfc Canonical link: https://commits.webkit.org/235911@main
2021-03-30 18:47:17 +00:00
PASS area1AXUIElement.insertionPointLineNumber is currentLine
PASS area1AXUIElement.insertionPointLineNumber is currentLine
PASS area1AXUIElement.insertionPointLineNumber is currentLine
PASS area2AXUIElement.insertionPointLineNumber is 0
PASS contenteditableAXUIElement.insertionPointLineNumber is 0
PASS contenteditableAXUIElement.insertionPointLineNumber is 1
PASS contenteditableAXUIElement.insertionPointLineNumber is 2
Make AccessibilityObject::lineForPosition return the correct value for cases where the position is not within the current object. https://bugs.webkit.org/show_bug.cgi?id=71348 Reviewed by Chris Fleizach. Source/WebCore: * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::lineForPosition): * accessibility/mac/WebAccessibilityObjectWrapper.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): LayoutTests: * accessibility/textarea-insertion-point-line-number-expected.txt: * accessibility/textarea-insertion-point-line-number.html: Canonical link: https://commits.webkit.org/91561@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-12-19 01:12:27 +00:00
PASS textareaAXUIElement.insertionPointLineNumber is 0
PASS successfullyParsed is true
TEST COMPLETE
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00