nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/accessibility/table-with-aria-role-expect...

7 lines
198 B
Plaintext
Raw Permalink Normal View History

Regression: AX: Don't expose role or notifications for invalid menus https://bugs.webkit.org/show_bug.cgi?id=129814 Reviewed by Mario Sanchez Prada. Source/WebCore: If a role=menu has no menuitem children, it should not be a menu. This was a bit tricky to implement since we need to update the role after the children are created, but it means we have to be a bit more aggressive about when to updateChildren, so that the role is known to be valid. Test: platform/mac/accessibility/invalid-menu-role-does-not-send-notification.html * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::notificationPostTimerFired): * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation): (WebCore::AccessibilityRenderObject::addChildren): * accessibility/AccessibilityRenderObject.h: * accessibility/mac/WebAccessibilityObjectWrapperBase.mm: (-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]): LayoutTests: * accessibility/table-with-aria-role.html: Modify test so that tests only what we want (that the role is correct). No longer use role=menu on the table, since the table won't have menuitems and won't be a valid menu. * platform/mac/accessibility/invalid-menu-role-does-not-send-notification-expected.txt: Added. * platform/mac/accessibility/invalid-menu-role-does-not-send-notification.html: Added. * platform/mac/accessibility/table-with-aria-role-expected.txt: Canonical link: https://commits.webkit.org/148725@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2014-03-24 21:26:25 +00:00
Table1 should not have a table role because it's a button: AXRole: AXButton
Table2 should not have a table role because it's a group: AXRole: AXGroup
PASS successfullyParsed is true
TEST COMPLETE