nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/accessibility/mac/selected-visible-position-r...

20 lines
391 B
Plaintext
Raw Permalink Normal View History

Web content process hangs in AccessibilityRenderObject::setSelectedVisiblePositionRange in some corner cases. https://bugs.webkit.org/show_bug.cgi?id=214017 Source/WebCore: <rdar://problem/63000006> Reviewed by Chris Fleizach. Ensures that in the case of collapsed ranges, the VisiblePosition that the selection is being set to, is contained in the Element object. Test: accessibility/mac/selected-visible-position-range.html * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange const): LayoutTests: Reviewed by Chris Fleizach. * accessibility/mac/resources/accessibility-helper.js: (selectTextInNode): * accessibility/mac/selected-visible-position-range-expected.txt: Added. * accessibility/mac/selected-visible-position-range.html: Added. * accessibility/mac/text-marker-p-tags.html: Canonical link: https://commits.webkit.org/226850@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-07-07 19:49:55 +00:00
First paragraph.
Last paragraph.
This tests getting and setting the selected VisiblePosition range.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Make accessibility/Mac/selected-visible-position-range.html time-deterministic. https://bugs.webkit.org/show_bug.cgi?id=214154 Reviewed by Chris Fleizach. Tools: * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Check passed parameter for null. (WTR::AccessibilityUIElement::selectedTextMarkerRange): Use attributeValue to run on secondary AX thread. LayoutTests: [WebAccessibilityObjectWrapper accessibilitySetValue] sets the selection range and other properties asynchronously by dispatching the call to another cycle of the run loop using callOnMainThread. thus for the JS to retrieve the new value, it is necessary to wait until the value is updated. this is even more so in isolated tree mode where all wrapper calls come on the secondary AX thread. JS setTimeout doesn't help with synchronizing these calls, so instead we are using Promises in the function waitFor in accessibility-helper.js (thanks to Geoff Garen for showing the way). * accessibility/mac/selected-visible-position-range-expected.txt: * accessibility/mac/selected-visible-position-range.html: MOved waitFor(condition) to the accessibility-helper.js file to be used in multiple tests. * accessibility/textarea-selected-text-range.html: * resources/accessibility-helper.js: (waitFor): Canonical link: https://commits.webkit.org/226975@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-07-10 01:27:19 +00:00
PASS current selection is 'Last paragraph.'
PASS current selection is 'First paragraph.
Web content process hangs in AccessibilityRenderObject::setSelectedVisiblePositionRange in some corner cases. https://bugs.webkit.org/show_bug.cgi?id=214017 Source/WebCore: <rdar://problem/63000006> Reviewed by Chris Fleizach. Ensures that in the case of collapsed ranges, the VisiblePosition that the selection is being set to, is contained in the Element object. Test: accessibility/mac/selected-visible-position-range.html * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange const): LayoutTests: Reviewed by Chris Fleizach. * accessibility/mac/resources/accessibility-helper.js: (selectTextInNode): * accessibility/mac/selected-visible-position-range-expected.txt: Added. * accessibility/mac/selected-visible-position-range.html: Added. * accessibility/mac/text-marker-p-tags.html: Canonical link: https://commits.webkit.org/226850@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-07-07 19:49:55 +00:00
Make accessibility/Mac/selected-visible-position-range.html time-deterministic. https://bugs.webkit.org/show_bug.cgi?id=214154 Reviewed by Chris Fleizach. Tools: * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Check passed parameter for null. (WTR::AccessibilityUIElement::selectedTextMarkerRange): Use attributeValue to run on secondary AX thread. LayoutTests: [WebAccessibilityObjectWrapper accessibilitySetValue] sets the selection range and other properties asynchronously by dispatching the call to another cycle of the run loop using callOnMainThread. thus for the JS to retrieve the new value, it is necessary to wait until the value is updated. this is even more so in isolated tree mode where all wrapper calls come on the secondary AX thread. JS setTimeout doesn't help with synchronizing these calls, so instead we are using Promises in the function waitFor in accessibility-helper.js (thanks to Geoff Garen for showing the way). * accessibility/mac/selected-visible-position-range-expected.txt: * accessibility/mac/selected-visible-position-range.html: MOved waitFor(condition) to the accessibility-helper.js file to be used in multiple tests. * accessibility/textarea-selected-text-range.html: * resources/accessibility-helper.js: (waitFor): Canonical link: https://commits.webkit.org/226975@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-07-10 01:27:19 +00:00
'
PASS current selection is ''
Source/WebCore: Range::contains does not work correctly when the common ancestor node is a Document. https://bugs.webkit.org/show_bug.cgi?id=215714 Reviewed by Darin Adler. Test: accessibility/mac/selected-visible-position-range.html. For a Range with a Document object as common ancestor, Range::contains(otherRange) would return false for any given other range in the same document. This causes problems in VoiceOver navigation and Braille functionality in the MacOS Mail.app. * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange const): Use SimpleRange::isNull instead of repeating its implementation. * dom/Range.cpp: (WebCore::Range::contains const): Compare the Documents of the ranges' common ancesstor nodes instead of their ownerDocuments. LayoutTests: Range::contains(const Range&) should compare the Documents to which the Ranges belong, not the ownerDocuments. https://bugs.webkit.org/show_bug.cgi?id=215714 Reviewed by Darin Adler. Revamped the following test to check that a collapsed selection range is set to the correct character offset in the text content. In addition, properly used the Promise returned by waitFor in order to make the test timing independent and work in isolated tree mode. * accessibility/mac/selected-visible-position-range-expected.txt: * accessibility/mac/selected-visible-position-range.html: Canonical link: https://commits.webkit.org/228485@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-08-21 11:42:49 +00:00
PASS current selection index is 19
Web content process hangs in AccessibilityRenderObject::setSelectedVisiblePositionRange in some corner cases. https://bugs.webkit.org/show_bug.cgi?id=214017 Source/WebCore: <rdar://problem/63000006> Reviewed by Chris Fleizach. Ensures that in the case of collapsed ranges, the VisiblePosition that the selection is being set to, is contained in the Element object. Test: accessibility/mac/selected-visible-position-range.html * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange const): LayoutTests: Reviewed by Chris Fleizach. * accessibility/mac/resources/accessibility-helper.js: (selectTextInNode): * accessibility/mac/selected-visible-position-range-expected.txt: Added. * accessibility/mac/selected-visible-position-range.html: Added. * accessibility/mac/text-marker-p-tags.html: Canonical link: https://commits.webkit.org/226850@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-07-07 19:49:55 +00:00
PASS successfullyParsed is true
TEST COMPLETE