nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/accessibility/accessibility-object-update...

5 lines
156 B
Plaintext
Raw Permalink Normal View History

Release assert in updateLayout() via AXObjectCache::childrenChanged https://bugs.webkit.org/show_bug.cgi?id=182279 <rdar://problem/36994456> Reviewed by Antti Koivisto. Source/WebCore: Disable the assertion in Document::updateLayout and Document::updateStyle* in this particular circumstance as fixing it would require a large architectural refactoring of the accessibility code. Test: accessibility/accessibility-object-update-during-style-resolution-crash.html * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::childrenChanged): Disabled the release assertion here. * dom/Document.cpp: (WebCore::Document::isSafeToUpdateStyleOrLayout const): Check LayoutAssertionDisableScope::shouldDisable. * dom/ScriptDisallowedScope.h: (WebCore::ScriptDisallowedScope::LayoutAssertionDisableScope): Added. (WebCore::ScriptDisallowedScope::LayoutAssertionDisableScope::LayoutAssertionDisableScope): Added. (WebCore::ScriptDisallowedScope::LayoutAssertionDisableScope::~LayoutAssertionDisableScope): Added. (WebCore::ScriptDisallowedScope::LayoutAssertionDisableScope::shouldDisable): Added. * page/LayoutContext.cpp: (WebCore::LayoutContext::layout): Check LayoutAssertionDisableScope::shouldDisable. LayoutTests: Added a regression test. * accessibility/accessibility-object-update-during-style-resolution-crash-expected.txt: Added. * accessibility/accessibility-object-update-during-style-resolution-crash.html: Added. Canonical link: https://commits.webkit.org/198109@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@227858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2018-01-30 22:47:05 +00:00
This tests invoking updateLayout durign a live region update from the style recalc.
WebKit should not hit a release assertion.
PASS. WebKit did not crash.