nephele
/
haikuwebkit
1
0
Fork 0
Code Issues Releases Activity
haikuwebkit/LayoutTests/accessibility/accessibility-node-memory-m...

17 lines
527 B
Plaintext
Raw Permalink Normal View History

AX: Calls to AXObjectCache should prefer Node over Renderer https://bugs.webkit.org/show_bug.cgi?id=91794 Reviewed by Chris Fleizach. Source/WebCore: Now that it's possible for nodes inside a canvas subtree to be focused and represent accessible content, accessibility notifications should be triggered with a Node* rather than with a RenderObject* whenever possible. Every public API in AXObjectCache that took a RenderObject* before now either takes a Node* instead, or has a parallel method that takes a Node*. Tests: accessibility/accessibility-node-memory-management.html accessibility/accessibility-node-reparent.html accessibility/canvas-fallback-content.html * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::focusedImageMapUIElement): (WebCore::AXObjectCache::focusedUIElementForPage): (WebCore::AXObjectCache::get): (WebCore::AXObjectCache::getOrCreate): (WebCore::AXObjectCache::contentChanged): (WebCore): (WebCore::AXObjectCache::updateCacheAfterNodeIsAttached): (WebCore::AXObjectCache::childrenChanged): (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::checkedStateChanged): (WebCore::AXObjectCache::selectedChildrenChanged): (WebCore::AXObjectCache::nodeTextChangeNotification): (WebCore::AXObjectCache::handleAriaExpandedChange): (WebCore::AXObjectCache::handleActiveDescendantChanged): (WebCore::AXObjectCache::handleAriaRoleChanged): (WebCore::AXObjectCache::textMarkerDataForVisiblePosition): (WebCore::AXObjectCache::rootAXEditableElement): (WebCore::AXObjectCache::nodeIsTextControl): * accessibility/AXObjectCache.h: (AXObjectCache): (WebCore::AXObjectCache::setNodeInUse): (WebCore::AXObjectCache::removeNodeForUse): (WebCore::AXObjectCache::isNodeInUse): (WebCore::AXObjectCache::checkedStateChanged): (WebCore::AXObjectCache::childrenChanged): (WebCore::AXObjectCache::contentChanged): (WebCore::AXObjectCache::updateCacheAfterNodeIsAttached): (WebCore::AXObjectCache::handleActiveDescendantChanged): (WebCore::AXObjectCache::handleAriaExpandedChange): (WebCore::AXObjectCache::handleAriaRoleChanged): (WebCore::AXObjectCache::handleFocusedUIElementChanged): (WebCore::AXObjectCache::nodeTextChangeNotification): (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::selectedChildrenChanged): * accessibility/AccessibilityListBoxOption.cpp: (WebCore::AccessibilityListBoxOption::parentObject): * accessibility/AccessibilityObject.cpp: (WebCore::appendAccessibilityObject): (WebCore::replacedNodeNeedsCharacter): * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::menuForMenuButton): (WebCore::AccessibilityRenderObject::menuButtonForMenu): (WebCore::AccessibilityRenderObject::checkboxOrRadioRect): (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers): (WebCore::AccessibilityRenderObject::titleUIElement): (WebCore::AccessibilityRenderObject::isTabItemSelected): (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap): (WebCore::AccessibilityRenderObject::nodeIsTextControl): (WebCore::AccessibilityRenderObject::activeDescendant): (WebCore::AccessibilityRenderObject::correspondingControlForLabelElement): (WebCore::AccessibilityRenderObject::correspondingLabelForControlElement): * accessibility/AccessibilityRenderObject.h: (AccessibilityRenderObject): * accessibility/AccessibilityScrollView.cpp: (WebCore::AccessibilityScrollView::webAreaObject): (WebCore::AccessibilityScrollView::parentObject): (WebCore::AccessibilityScrollView::parentObjectIfExists): * accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::handleFocusedUIElementChanged): * accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleFocusedUIElementChanged): * accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::handleFocusedUIElementChanged): * accessibility/win/AXObjectCacheWin.cpp: (WebCore::AXObjectCache::handleFocusedUIElementChanged): * bindings/cpp/WebDOMCustomVoidCallback.cpp: (toWebCore): * dom/Document.cpp: (WebCore::Document::setFocusedNode): * dom/Element.cpp: (WebCore::Element::attributeChanged): * dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::attach): * editing/AppendNodeCommand.cpp: (WebCore::sendAXTextChangedIgnoringLineBreaks): * editing/DeleteFromTextNodeCommand.cpp: (WebCore::DeleteFromTextNodeCommand::doApply): (WebCore::DeleteFromTextNodeCommand::doUnapply): * editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): (WebCore::Editor::markAndReplaceFor): * editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::doApply): (WebCore::InsertIntoTextNodeCommand::doUnapply): * editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply): (WebCore::InsertNodeBeforeCommand::doUnapply): * editing/chromium/FrameSelectionChromium.cpp: (WebCore::FrameSelection::notifyAccessibilityForSelectionChange): * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::childrenChanged): (WebCore::HTMLSelectElement::optionElementChildrenChanged): * html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::setInnerTextValue): * html/InputType.cpp: (WebCore::InputType::applyStep): * html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): * page/FocusController.cpp: (WebCore::FocusController::setInitialFocus): LayoutTests: New tests: - canvas-fallback-content tests that objects in a canvas subtree can be focused and then you can retrieve the role of the accessible object. - accessibility-node-memory-management ensures that an AccessibilityNodeObject is detached when its node is destroyed. - accessibility-node-reparent ensures that if an AccessibilityNodeObject is created for a node without a renderer, but the node later gets a renderer, the AccessibilityNodeObject is detached and an AccessibilityRenderObject is created instead. * accessibility/accessibility-node-memory-management-expected.txt: Added. * accessibility/accessibility-node-memory-management.html: Added. * accessibility/accessibility-node-reparent-expected.txt: Added. * accessibility/accessibility-node-reparent.html: Added. * accessibility/canvas-fallback-content-expected.txt: Added. * accessibility/canvas-fallback-content.html: Added. * platform/gtk/TestExpectations: Canonical link: https://commits.webkit.org/111968@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-08-15 21:31:35 +00:00
This test makes sure that AccessibilityNodeObjects are properly detached when the node they point to is deleted.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
REGRESSION: (r257915?) [ Mac ] accessibility/accessibility-node-memory-management.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=208930 Source/WebCore: Reviewed by Chris Fleizach. Test: accessibility/accessibility-node-memory-management.html In some cases, such as the empty canvas in this test, the algorithm in AXIsolatedTree::updateChildren to only update the children that are added or removed does not work. In those cases, fallback to updating the entire subtree. * accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::updateChildren): LayoutTests: <rdar://problem/60173203> Reviewed by Chris Fleizach. Using setTimeout and waitFor/Promises to make this test work in both isolated tree mode on and off. * accessibility/accessibility-node-memory-management-expected.txt: * accessibility/accessibility-node-memory-management.html: * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/227085@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-07-13 23:15:18 +00:00
Button role: AXRole: AXButton
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
Button role after being detached: AXRole:
REGRESSION: (r257915?) [ Mac ] accessibility/accessibility-node-memory-management.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=208930 Source/WebCore: Reviewed by Chris Fleizach. Test: accessibility/accessibility-node-memory-management.html In some cases, such as the empty canvas in this test, the algorithm in AXIsolatedTree::updateChildren to only update the children that are added or removed does not work. In those cases, fallback to updating the entire subtree. * accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::updateChildren): LayoutTests: <rdar://problem/60173203> Reviewed by Chris Fleizach. Using setTimeout and waitFor/Promises to make this test work in both isolated tree mode on and off. * accessibility/accessibility-node-memory-management-expected.txt: * accessibility/accessibility-node-memory-management.html: * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/227085@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-07-13 23:15:18 +00:00
PASS buttonRole != detachedRole is true
Canvas button role: AXRole: AXButton
PASS canvasButtonRole is buttonRole
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many) https://bugs.webkit.org/show_bug.cgi?id=217016 Reviewed by Zalan Bujtas. Done with this command: find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/^CONSOLE MESSAGE:/ { next }; /^<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$//g' This affects many files, and it's not helpful to clog the change log with a list of them. Canonical link: https://commits.webkit.org/229803@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-09-27 02:15:19 +00:00
Canvas button role after being detached: AXRole:
REGRESSION: (r257915?) [ Mac ] accessibility/accessibility-node-memory-management.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=208930 Source/WebCore: Reviewed by Chris Fleizach. Test: accessibility/accessibility-node-memory-management.html In some cases, such as the empty canvas in this test, the algorithm in AXIsolatedTree::updateChildren to only update the children that are added or removed does not work. In those cases, fallback to updating the entire subtree. * accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::updateChildren): LayoutTests: <rdar://problem/60173203> Reviewed by Chris Fleizach. Using setTimeout and waitFor/Promises to make this test work in both isolated tree mode on and off. * accessibility/accessibility-node-memory-management-expected.txt: * accessibility/accessibility-node-memory-management.html: * platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/227085@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2020-07-13 23:15:18 +00:00
PASS detachedCanvasButtonRole is detachedRole
AX: Calls to AXObjectCache should prefer Node over Renderer https://bugs.webkit.org/show_bug.cgi?id=91794 Reviewed by Chris Fleizach. Source/WebCore: Now that it's possible for nodes inside a canvas subtree to be focused and represent accessible content, accessibility notifications should be triggered with a Node* rather than with a RenderObject* whenever possible. Every public API in AXObjectCache that took a RenderObject* before now either takes a Node* instead, or has a parallel method that takes a Node*. Tests: accessibility/accessibility-node-memory-management.html accessibility/accessibility-node-reparent.html accessibility/canvas-fallback-content.html * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::focusedImageMapUIElement): (WebCore::AXObjectCache::focusedUIElementForPage): (WebCore::AXObjectCache::get): (WebCore::AXObjectCache::getOrCreate): (WebCore::AXObjectCache::contentChanged): (WebCore): (WebCore::AXObjectCache::updateCacheAfterNodeIsAttached): (WebCore::AXObjectCache::childrenChanged): (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::checkedStateChanged): (WebCore::AXObjectCache::selectedChildrenChanged): (WebCore::AXObjectCache::nodeTextChangeNotification): (WebCore::AXObjectCache::handleAriaExpandedChange): (WebCore::AXObjectCache::handleActiveDescendantChanged): (WebCore::AXObjectCache::handleAriaRoleChanged): (WebCore::AXObjectCache::textMarkerDataForVisiblePosition): (WebCore::AXObjectCache::rootAXEditableElement): (WebCore::AXObjectCache::nodeIsTextControl): * accessibility/AXObjectCache.h: (AXObjectCache): (WebCore::AXObjectCache::setNodeInUse): (WebCore::AXObjectCache::removeNodeForUse): (WebCore::AXObjectCache::isNodeInUse): (WebCore::AXObjectCache::checkedStateChanged): (WebCore::AXObjectCache::childrenChanged): (WebCore::AXObjectCache::contentChanged): (WebCore::AXObjectCache::updateCacheAfterNodeIsAttached): (WebCore::AXObjectCache::handleActiveDescendantChanged): (WebCore::AXObjectCache::handleAriaExpandedChange): (WebCore::AXObjectCache::handleAriaRoleChanged): (WebCore::AXObjectCache::handleFocusedUIElementChanged): (WebCore::AXObjectCache::nodeTextChangeNotification): (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::selectedChildrenChanged): * accessibility/AccessibilityListBoxOption.cpp: (WebCore::AccessibilityListBoxOption::parentObject): * accessibility/AccessibilityObject.cpp: (WebCore::appendAccessibilityObject): (WebCore::replacedNodeNeedsCharacter): * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::menuForMenuButton): (WebCore::AccessibilityRenderObject::menuButtonForMenu): (WebCore::AccessibilityRenderObject::checkboxOrRadioRect): (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers): (WebCore::AccessibilityRenderObject::titleUIElement): (WebCore::AccessibilityRenderObject::isTabItemSelected): (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap): (WebCore::AccessibilityRenderObject::nodeIsTextControl): (WebCore::AccessibilityRenderObject::activeDescendant): (WebCore::AccessibilityRenderObject::correspondingControlForLabelElement): (WebCore::AccessibilityRenderObject::correspondingLabelForControlElement): * accessibility/AccessibilityRenderObject.h: (AccessibilityRenderObject): * accessibility/AccessibilityScrollView.cpp: (WebCore::AccessibilityScrollView::webAreaObject): (WebCore::AccessibilityScrollView::parentObject): (WebCore::AccessibilityScrollView::parentObjectIfExists): * accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::handleFocusedUIElementChanged): * accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleFocusedUIElementChanged): * accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::handleFocusedUIElementChanged): * accessibility/win/AXObjectCacheWin.cpp: (WebCore::AXObjectCache::handleFocusedUIElementChanged): * bindings/cpp/WebDOMCustomVoidCallback.cpp: (toWebCore): * dom/Document.cpp: (WebCore::Document::setFocusedNode): * dom/Element.cpp: (WebCore::Element::attributeChanged): * dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::attach): * editing/AppendNodeCommand.cpp: (WebCore::sendAXTextChangedIgnoringLineBreaks): * editing/DeleteFromTextNodeCommand.cpp: (WebCore::DeleteFromTextNodeCommand::doApply): (WebCore::DeleteFromTextNodeCommand::doUnapply): * editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): (WebCore::Editor::markAndReplaceFor): * editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::doApply): (WebCore::InsertIntoTextNodeCommand::doUnapply): * editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply): (WebCore::InsertNodeBeforeCommand::doUnapply): * editing/chromium/FrameSelectionChromium.cpp: (WebCore::FrameSelection::notifyAccessibilityForSelectionChange): * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::childrenChanged): (WebCore::HTMLSelectElement::optionElementChildrenChanged): * html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::setInnerTextValue): * html/InputType.cpp: (WebCore::InputType::applyStep): * html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): * page/FocusController.cpp: (WebCore::FocusController::setInitialFocus): LayoutTests: New tests: - canvas-fallback-content tests that objects in a canvas subtree can be focused and then you can retrieve the role of the accessible object. - accessibility-node-memory-management ensures that an AccessibilityNodeObject is detached when its node is destroyed. - accessibility-node-reparent ensures that if an AccessibilityNodeObject is created for a node without a renderer, but the node later gets a renderer, the AccessibilityNodeObject is detached and an AccessibilityRenderObject is created instead. * accessibility/accessibility-node-memory-management-expected.txt: Added. * accessibility/accessibility-node-memory-management.html: Added. * accessibility/accessibility-node-reparent-expected.txt: Added. * accessibility/accessibility-node-reparent.html: Added. * accessibility/canvas-fallback-content-expected.txt: Added. * accessibility/canvas-fallback-content.html: Added. * platform/gtk/TestExpectations: Canonical link: https://commits.webkit.org/111968@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-08-15 21:31:35 +00:00
PASS successfullyParsed is true
TEST COMPLETE